Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

Hi Dave, I have found the issue, it was in Backform control itself :) Issue: We were passing today's date value as minDate option in pgAgent schedule schema while rendering the control, So when server was sending previous datetime value it was not displaying it causing sync problem. -- Regards, M

Re: RM3079 fix for wrong sql datetime/time related datatypes

Hi, On Tue, Feb 27, 2018 at 8:54 PM, Dave Page wrote: > Hi > > On Tue, Feb 27, 2018 at 2:36 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Please find patch to fix wrong sql issue for time related type. >> >> Steps to reproduce: >> >> Alter any time/datetime array

Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query

On Mon, Feb 26, 2018 at 10:02 PM, Dave Page wrote: > Argh, I ran some tests, but didn't spot any lost messages in the tests I > ran. I'll revert the patch. > > Khushboo; > > Please look at the following: > > - Fix the patch so it doesn't drop messages. > Fixed. By default, the notice attribute of

Feature #3061

Hi, I am Neethu Mariya Joy, an undergraduate sophomore pursuing BE(Hons) in Computer Engineering from BITS Pilani, India. I would like to work on the feature #3061, "Dashboard Customisation". Kindly provide suggestions for the same. Sincerely, Neethu Mariya Joy GitHub

Re: RM3079 fix for wrong sql datetime/time related datatypes

Hello Harshal, I tried the example you showed and it works. Also passed the patch through our CI Pipeline and everything is good. Thanks Joao On Wed, Feb 28, 2018 at 6:25 AM Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > On Tue, Feb 27, 2018 at 8:54 PM, Dave Page wrote: > >

Re: RM3079 fix for wrong sql datetime/time related datatypes

Great, thanks! On Feb 28, 2018 8:15 PM, "Joao De Almeida Pereira" < jdealmeidapere...@pivotal.io> wrote: > Hello Harshal, > > I tried the example you showed and it works. Also passed the patch through > our CI Pipeline and everything is good. > > Thanks > Joao > > On Wed, Feb 28, 2018 at 6:25 AM

Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

Hello Murtuza, I do not have the pgAgent installed so it was a little it hard to test this. After looking into the code I think we are missing some testing coverage around the pga_job Javascript part so that we can catch these problems. Even some code extraction can be done around the pg_jobset cha

Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query

Hello Khushboo, After reviewing the patch I have the gut feeling that we do not have enough test coverage on this issue, specially due to the intricate while loop and conditions around the polling. I think that this deserve Unit tests around it, When I say Unit Test I am not talking about executing

Re: Feature #3061

Hello Neethu Welcome to the pgadmin-hackers, nice to see you here. In order to start this story, I believe that we need to talk with some users to understand what does this story mean. At this point the issue is to broad and I personally do not understand what customization means. But feel free t

[pgAdmin4][RM#3161] Fix PEP-8 issues

Hi, PFA patch to fix the PEP8 issues in Casts, Event triggers, Extensions and Languages module. pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/languages/ pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/extensions/ pycodestyle --

Re: [pgAdmin4][RM#3161] Fix PEP-8 issues

Hello Murtuza, I passed the patch through our CI and all test are green. Also run the codestyle in all those folders and everything is clean. 575 issues to go Thanks Joao On Wed, Feb 28, 2018 at 1:05 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix t

Re: Feature #3061

Hello, First of all I'm assuming that you have some degree of knowledge about Python, HTML, JS & Git. We have had added similar feature recently. Check: https://redmine.postgresql.org/issues/2951 for more details. Code location of Dashboard module in git repository: ../pgadmin4/web/pgadmin/dashbo

Re: [pgAdmin4][RM#3161] Fix PEP-8 issues

Thank you Joao for reviewing. On Thu, Mar 1, 2018 at 3:10 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Murtuza, > > I passed the patch through our CI and all test are green. Also run the > codestyle in all those folders and everything is clean. > > 575 issues to go >

Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query

Hi Joao, Thanks for reviewing. On Wed, Feb 28, 2018 at 8:55 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Khushboo, > After reviewing the patch I have the gut feeling that we do not have > enough test coverage on this issue, specially due to the intricate while > loo

[pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayed when user try to insert data on table where primray key is in captial letters and table contains OIDS

Hi, Please find the attached patch to fix RM # 3135 - [Web based] Syntax error displayed when user try to insert data on table where primray key is in captial letters and table contains OIDS Thanks, Khushboo diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor/sql/default/insert.sql b/web