Allow dashboard tables and charts to be enabled/disabled. Fixes #2951
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=801a2084e9337e4bf07355a074f3adfbdcb9a334
Author: Murtuza Zabuawala
Modified Files
--
.../en_US/images/preference
Thanks, patch applied with minor changes to the description strings for the
options.
Chethana, could you please send me an update of the appropriate image from
this patch (with my changed strings), and send a short howto on creating
the images properly, including the specs for them please? I'll in
Fix table statistics for Greenplum. Fixes #3059
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5ebd9ee8d30a32bfbe9deb39fc3c6da224dfcff9
Author: Joao Pedro De Almeida Pereira
Modified Files
--
.../tables/templates/table/sql/9.1_pl
Thanks, patch applied.
On Fri, Feb 23, 2018 at 9:57 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hi Hackers,
> The attached patch fixes the statistics retrieval of tables in GreenPlum
>
> Thanks
> Joao
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
FYI, in an attempt not to be the one reviewing everything, I'm leaving this
for Joao to pick up again. Moving forwards, I'd like to make that the
default - if (better yet, when) someone reviews someone else's patch, we
should expect that person to review any followups as well, unless they
explicitl
Hi Joao,
I tried the solution/patch you suggested but it is not working for me, I
always get *undefined* for preferences values.
Thanks,
Murtuza
On Thu, Feb 22, 2018 at 3:17 AM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello Murtuza,
> I created a small patch on the way
2018-02-25 20:59 GMT+03:00 Dave Page :
> Hi
>
> On Sat, Feb 24, 2018 at 9:04 PM, Максим Кольцов wrote:
>>
>> Hi
>>
>> 2018-02-19 12:13 GMT+03:00 Dave Page :
>> > Hi
>> >
>> > On Sun, Feb 18, 2018 at 5:41 PM, Максим Кольцов
>> > wrote:
>> >>
>> >> Hi!
>> >>
>> >> I accidentially sent this email to
Hi,
PFA minor patch to fix the issue in utils folder.
pycodestyle --config=.pycodestyle ./pgadmin/utils/
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadmin/utils/compile_template_name.py
b/web/pgadmin/utils/compile_
Hi
On Mon, Feb 26, 2018 at 10:09 AM, Максим Кольцов wrote:
> 2018-02-25 20:59 GMT+03:00 Dave Page :
> > Hi
> >
> > On Sat, Feb 24, 2018 at 9:04 PM, Максим Кольцов
> wrote:
> >>
> >> Hi
> >>
> >> 2018-02-19 12:13 GMT+03:00 Dave Page :
> >> > Hi
> >> >
> >> > On Sun, Feb 18, 2018 at 5:41 PM, Макс
Hi,
Please find the attached patch to fix the RM #3094: Notices from query n
are shown in messages from query n+1
Thanks,
Khushboo
diff --git a/web/pgadmin/utils/driver/abstract.py b/web/pgadmin/utils/driver/abstract.py
index 32e1c97..1722e21 100644
--- a/web/pgadmin/utils/driver/abstract.py
+++
Hi,
Please find the updated patch for keyboard navigation.
In this patch I have reduced delay which is required until current tab
navigation is completed.
Extracted class dialogTabNavigator and put it in new file.
Added jasmine test cases.
Fixed linting issues, variable naming convention issues.
Hi,
Please find the attached patch to fix PEP-8 issues in the below modules:
1. about
2. feature_tests
3. misc
4. utils
Thanks,
Khushboo
diff --git a/web/pgadmin/about/__init__.py b/web/pgadmin/about/__init__.py
index 98a4dd6..6d1e0b2 100644
--- a/web/pgadmin/about/__init__.py
+++ b/web/pgadmin/
Hi,
Please find patch to fix pep-8 issues for given modules.
1. help (__init__.py)
2. pgadmin (__init__.py)
3. browser (__init__.py, collection.py, utils.py)
--
*Harshal Dhumal*
*Sr. Software Engineer*
EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --gi
PEP8 fixes.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fa9aebadbd1ec90dacc40bdb590fd6699b66e7f1
Author: Murtuza Zabuawala
Modified Files
--
web/pgadmin/utils/compile_template_name.py | 8 +++--
.../utils/tests/test_co
Thanks, applied.
On Mon, Feb 26, 2018 at 10:32 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi,
>
> PFA minor patch to fix the issue in utils folder.
> pycodestyle --config=.pycodestyle ./pgadmin/utils/
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.ent
Ensure we pick up the messages from the current query and not a previous one.
Fixes #3094
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=08b3ccc01a4d57e8ea3657f8882a53dcd1b99386
Author: Khushboo Vashi
Modified Files
--
web/pgadm
Thanks, applied.
On Mon, Feb 26, 2018 at 11:05 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi,
>
> Please find the attached patch to fix the RM #3094: Notices from query n
> are shown in messages from query n+1
>
> Thanks,
> Khushboo
>
--
Dave Page
Blog: http://pgsnake.blog
Hello
That is unfortunate. Can you run directly the python app?
Go to the folder where you installed the application using a
terminal/PowerShell/cmd and use the python from the venv folder to run the
pgadmin4.py file and let me know the error that you are getting.
venv/bin/python pgadmin4/pgadmin4
Hi
On Mon, Feb 26, 2018 at 12:03 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:
> Hi,
>
> Please find the updated patch for keyboard navigation.
>
> In this patch I have reduced delay which is required until current tab
> navigation is completed.
> Extracted class dialogTabNavigator
Hi,
PFA patch to fix the issue where user was not able to create pgAgent job
from UI without entering End date in schedule section.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git
a/web/pgadmin/browser/server_groups/servers/pga
Can you rebase this please? It doesn't apply against master.
On Mon, Feb 26, 2018 at 12:04 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi,
>
> Please find the attached patch to fix PEP-8 issues in the below modules:
>
> 1. about
> 2. feature_tests
> 3. misc
> 4. utils
>
> Thank
Update dashboard display options screenshots.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=51811a451d1f7d4c852372cb6088918dd44bd42f
Author: Chethana Kumar
Modified Files
--
.../en_US/images/preferences_dashboard_display.png | B
Hi
On Mon, Feb 26, 2018 at 12:55 PM, Chethana Kumar <
chethana.ku...@enterprisedb.com> wrote:
> Hi Dave,
>
> I am attaching the patch that is requested and also a short note on "*How
> to resize images for documentation*".
>
Thanks, applied.
>
> *Applicable for popups only -*
> 1. First of all
Thanks, applied.
On Mon, Feb 26, 2018 at 1:38 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:
> Hi,
>
> Please find patch to fix pep-8 issues for given modules.
>
> 1. help (__init__.py)
> 2. pgadmin (__init__.py)
> 3. browser (__init__.py, collection.py, utils.py)
>
>
> --
> *Harsha
PEP8 fixes.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=43d3e0ca64179da4e52a8746085de01292972f1d
Author: Harshal Dhumal
Modified Files
--
web/pgadmin/__init__.py | 42 +++--
web/pgadmin/browser/__init__.py
Hi Khushboo/Dave,
With given commit, I'm again seeing the issue raised in
https://redmine.postgresql.org/issues/1523 :(
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, Feb 26, 2018 at 7:49 PM, Dave Page wrote:
> Ensure we pi
Sent bit early,
You can run 'VACUUM FULL VERBOSE' in query tool and verify the populated
messages (pgAdmin3 vs. pgAdmin4).
On Mon, Feb 26, 2018 at 9:48 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi Khushboo/Dave,
>
> With given commit, I'm again seeing the issue raised
Argh, I ran some tests, but didn't spot any lost messages in the tests I
ran. I'll revert the patch.
Khushboo;
Please look at the following:
- Fix the patch so it doesn't drop messages.
- Add regression tests to make sure it doesn't break in the future. This
may require creating one or more func
Revert "Ensure we pick up the messages from the current query and not a
previous one. Fixes #3094"
This reverts commit 08b3ccc01a4d57e8ea3657f8882a53dcd1b99386.
It was found that this fix inadvertently re-introduces #1523
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=
Hello Murtuza,
We just passed the patch through our CI pipeline and all tests pass. The
patch looks good.
Sorry that the patch I sent didn't help. Nevertheless when I finish the
tasks that we want to try to get accepted for pgAdmin4 3.0 release I will
try to change the way the preferences are retr
Thanks Murtuza,
Looks like something is wrong with the venv for windows at least. Tomorrow
I will give it a try again in a VM to see if I can understand what is
happening, maybe I will need some help to understand what is added on the
current windows build to ensure we have all the required librari
Thank you Joao for reviewing.
On Mon, Feb 26, 2018 at 10:43 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello Murtuza,
> We just passed the patch through our CI pipeline and all tests pass. The
> patch looks good.
>
> Sorry that the patch I sent didn't help. Nevertheless
FYI, This is what I'm receiving(attachments) when I'm running vacuum full
verbose on my PG10.
On Mon, Feb 26, 2018 at 10:02 PM, Dave Page wrote:
> Argh, I ran some tests, but didn't spot any lost messages in the tests I
> ran. I'll revert the patch.
>
> Khushboo;
>
> Please look at the follo
Hi,
Please find the updated patch.
On Mon, Feb 26, 2018 at 8:03 PM, Dave Page wrote:
> Hi
>
> On Mon, Feb 26, 2018 at 12:03 PM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the updated patch for keyboard navigation.
>>
>> In this patch I have reduced del
Thanks for the stearing, I finally found out the problem. I was missing an
's' in the end of one of the names
Joao
On Fri, Feb 23, 2018 at 10:19 PM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi Joao,
>
> On Fri, Feb 23, 2018 at 11:23 PM, Joao De Almeida Pereira <
> jdealmei
PEP8 fixes for the pgAgent and Tables nodes (and subnodes). Fixes #3148
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6753cd7334dbe91f19373833756f8e57f98323d0
Author: Murtuza Zabuawala
Modified Files
--
.../servers/databases/sch
Thanks, applied.
On Mon, Feb 26, 2018 at 5:28 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi,
>
> PFA fix the issues in pgAgent node and Tables node (including its all
> subnodes)
>
> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/
> servers/pgagent/
> py
Hi,
I'm still able to make it get stuck, if I tab back and forth quickly.
On Mon, Feb 26, 2018 at 6:04 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:
> Hi,
>
> Please find the updated patch.
>
> On Mon, Feb 26, 2018 at 8:03 PM, Dave Page wrote:
>
>> Hi
>>
>> On Mon, Feb 26, 2018 a
Hi hackers,
Attached you can find the correct for the bug #3150. The functions SQL tab
stopped working after #3060, this patch changes the SQL to ensure that the
tab is working again.
Thanks
Joao
functions-display-sql-greenplum.diff
Description: Binary data
Hi,
On Tue, Feb 27, 2018 at 1:08 AM, Dave Page wrote:
> Hi,
>
> I'm still able to make it get stuck, if I tab back and forth quickly.
>
Quickly switching tabs was causing to switch to next tab before previous
navigation was completed and
this was leading to lose focus on tab pane.
Now I have mad
Hi,
Please find patch to fix pep-8 issues for given modules.
1. server group (__init__.py)
2. server (__init__.py, gpdb.py, types.py, utils.py)
--
*Harshal Dhumal*
*Sr. Software Engineer*
EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadmi
41 matches
Mail list logo
