Re: [pgAdmin4][Patch]: RM #3077 - ERROR: invalid byte sequence for encoding "LATIN1":0x00

2018-02-22 Thread Dave Page
On Thu, Feb 22, 2018 at 4:11 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, Feb 21, 2018 at 10:51 PM, Dave Page wrote: > >> >> >> On Wed, Feb 21, 2018 at 3:45 PM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>> Hi >>> The patch looks good, do w

Re: [pgadmin4] PEP-8 on pgadmin/tools

2018-02-22 Thread Joao De Almeida Pereira
Not 100% working, sorry I will send the patch again as soon as I have a fix On Wed, Feb 21, 2018 at 6:17 PM Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi hackers, > Attached, you can find the PEP-8 the pgadmin/tools fixes. > > Thanks > Joao >

pgAdmin 4 commit: Don't use the webpack cache with production builds.

2018-02-22 Thread Dave Page
Don't use the webpack cache with production builds. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5a49fbd11fbc50ab9e3a9863220d96225b3c42e7 Author: Khushboo Vashi Modified Files -- web/webpack.config.js | 1 - 1 file changed, 1 de

Re: [pgAdmin4][Patch]: Remove webpack plugin hardSourceWebpackPlugin from the production environment

2018-02-22 Thread Dave Page
Thanks, patch applied. On Thu, Feb 22, 2018 at 7:36 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to remove webpack plugin > hardSourceWebpackPlugin from the production environment. > > Thanks, > Khushboo > -- Dave Page Blog: http://pgsn

Re: [pgadmin4] PEP-8 on pgadmin/tools

2018-02-22 Thread Joao De Almeida Pereira
Hello, I fixed the issues from the previous patch. This new patch should be working as expected. Thanks Joao On Thu, Feb 22, 2018 at 9:19 AM Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Not 100% working, sorry I will send the patch again as soon as I have a fix > > On Wed, Fe

Re: [pgAdmin4][Patch]: RM #3077 - ERROR: invalid byte sequence for encoding "LATIN1":0x00

2018-02-22 Thread Khushboo Vashi
On Thu, Feb 22, 2018 at 5:32 PM, Dave Page wrote: > > > On Thu, Feb 22, 2018 at 4:11 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Wed, Feb 21, 2018 at 10:51 PM, Dave Page wrote: >> >>> >>> >>> On Wed, Feb 21, 2018 at 3:45 PM, Joao De Almeida Pereira < >>> jdealmei

Re: [pgAdmin4][Patch]: RM #3077 - ERROR: invalid byte sequence for encoding "LATIN1":0x00

2018-02-22 Thread Khushboo Vashi
On Fri, Feb 23, 2018 at 9:45 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Feb 22, 2018 at 5:32 PM, Dave Page wrote: > >> >> >> On Thu, Feb 22, 2018 at 4:11 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Wed, Feb 21, 2018 at 10:51 PM