pgAdmin 4 commit: Add keyboard navigation in Query tool module via Tab/

2018-01-25 Thread Dave Page
Add keyboard navigation in Query tool module via Tab/Shift-Tab key. Fixes #2896 Note: 1) Once the keyboard shortcut infrastructure is ready we will add generic shortcut to focus out from CodeMirror editor and set foucs to next element, Right now there is no way of doing this, For testing purpose

Re: [pgAdmin4][Patch#2896] Add support for Tab/Shift Tab navigation in Query tool

2018-01-25 Thread Dave Page
Thanks, patch applied. On Wed, Jan 24, 2018 at 1:18 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to add keyboard navigation in Query tool module via > Tab/Shift-Tab key. > RM#2896 > > Please review. > > *Note:* > 1) Once the keyboard shortcut infrastructu

pgAdmin 4 commit: Correct display of RE-SQL for partitioned tables in G

2018-01-25 Thread Dave Page
Correct display of RE-SQL for partitioned tables in Greenplum. Fixes #3050 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7c985695b75606576dcc4b193049ab98cb0f2b42 Author: Joao Pedro De Almeida Pereira Modified Files -- .../templa

Re: [pgadmin4][patch] Correct Bug #3050

2018-01-25 Thread Dave Page
Hi On Wed, Jan 24, 2018 at 10:28 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > We corrected the SQL tab display of partitioned table in GreenPlum, with > the attached diff. > Thanks, applied. > > I was able to create the Issue in Redmine and assign it to me

pgAdmin 4 commit: Add infrastructure for managing configurable keyboard

2018-01-25 Thread Dave Page
Add infrastructure for managing configurable keyboard shortcuts. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=66341e6947b0999b66c46078bf31f89851597fd6 Author: Harshal Dhumal Modified Files -- web/pgadmin/preferences/static/css/

Build failed in Jenkins: pgadmin4-master-python35 #458

2018-01-25 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Add keyboard navigation in Query tool module via Tab/Shift-Tab key. [Dave Page] Correct display of RE-SQL for partitioned tables in Greenplum. Fixes [Dave Page] Add infrastruct

[pgAdmin4][Patch#3046] To display connection status in IE11 & Firefox properly

2018-01-25 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where connection status was not displaying in query tool when open with IE11 and Firefox, apparently found that these browser do not support displaying svg as content in div element directly. Now I have tested new changes with Chrome, Firefox, Opera, Safari, Edge &

pgAdmin 4 commit: Fix connection status indicator on IE/FF. Fixes #3046

2018-01-25 Thread Dave Page
Fix connection status indicator on IE/FF. Fixes #3046 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=abcb8c36a3be2c2cd8d2854a2f22453888b59542 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/tools/sqleditor/static/css/sqle

Re: [pgAdmin4][Patch#3046] To display connection status in IE11 & Firefox properly

2018-01-25 Thread Dave Page
Thanks, applied. On Thu, Jan 25, 2018 at 1:25 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where connection status was not displaying in > query tool when open with IE11 and Firefox, apparently found that these > browser do not support di

Build failed in Jenkins: pgadmin4-master-python35 #459

2018-01-25 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix connection status indicator on IE/FF. Fixes #3046 -- [...truncated 386.37 KB...] ResourceGroupsAddTestCase (Add resou

pgAdmin 4 commit: Remove redundant proxy/SSL handling code.

2018-01-25 Thread Dave Page
Remove redundant proxy/SSL handling code. Branch -- runtime-revamp Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c0380e99c5082ea13495692d9e838d76e73f3c91 Modified Files -- runtime/Server.cpp | 1 + runtime/pgAdmin4.cpp | 141 --

pgAdmin 4 commit: Pause before checking for startup errors. Hacky, but

2018-01-25 Thread Dave Page
Pause before checking for startup errors. Hacky, but not much else we can do here without a significant rewrite. Branch -- runtime-revamp Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ebd1959d528601c3c5e28e5eb925255ac832bef0 Modified Files -- ru

[pgadmin][patch] Make Feature and Unit tests Green Again

2018-01-25 Thread Joao De Almeida Pereira
Hi Hackers, Attached you can find a diff with the correction of Bug 3057. With the latest changes to display some information in GP some Feature Tests stopped working when run against a GP instance. Also we found out that the Feature Test(PGDataType) against 9.2 is failing for some time as well. S