[pgAdmin4][Patch#3013] Fixed minor UI issue on Dashboard

2018-01-15 Thread Murtuza Zabuawala
Hi, PFA patch to fix the minor UI issue on dashboard while displaying subnode control in Backgrid. RM#3013 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/dashboard/static/css/dashboard.css b/web/pgadmin/dashboard

pgAdmin 4 commit: Support Properties on Greenplum databases. Fixes #301

2018-01-15 Thread Dave Page
Support Properties on Greenplum databases. Fixes #3015 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=56e922f5abff35e6904d59c2173fd127ac336285 Author: Joao Pedro De Almeida Pereira Modified Files -- .../templates/databases/sql/9.

Re: [pgadmin4][Patch] Access Database properties

2018-01-15 Thread Dave Page
Thanks - patch applied! On Fri, Jan 12, 2018 at 5:46 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > This patch tackles the visualization of properties on a GreenPlum > Database. Previously when you tried to access these properties a SQL error > was displayed. >

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

2018-01-15 Thread Dave Page
Hi Unfortunately there's variation in the spec of the images. Can you please check with Chethana on the correct sizing and resolution etc? For example, query_sql_editor.png was previously 755x209, but now is 2042x402. Thanks! On Mon, Jan 15, 2018 at 7:21 AM, Murtuza Zabuawala < murtuza.zabuaw...

[pgAdmin4][Patch]: RM #2904: As a visually impaired user I need all buttons in the application to have appropriate tooltips for my screen reader to interpret

2018-01-15 Thread Khushboo Vashi
Hi, Please find the attached patch for RM # 2904: As a visually impaired user I need all buttons in the application to have appropriate tooltips for my screen reader to interpret. Thanks, Khushboo diff --git a/web/pgadmin/about/static/js/about.js b/web/pgadmin/about/static/js/about.js index 1e72c

pgAdmin 4 commit: Doc updates for connection status monitoring.

2018-01-15 Thread Dave Page
Doc updates for connection status monitoring. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=03605bf9bed44585396541373e521619ddfb02bb Author: Murtuza Zabuawala Modified Files -- docs/en_US/images/preferences_sql_display.png

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

2018-01-15 Thread Dave Page
Thanks, applied. On Mon, Jan 15, 2018 at 11:35 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Mon, Jan 15, 2018 at 2:57 PM, Dave Page wrote: > >> Hi >> >> Unfortunately there's variation in the spec of the images. Can you please >> check with Chethana on the

pgAdmin 4 commit: Fix a minor UI issue on dashboard while displaying su

2018-01-15 Thread Dave Page
Fix a minor UI issue on dashboard while displaying subnode control in Backgrid. Fixes #3013 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ad46d61bd3a26d6d1cef3b7e764125382b186068 Author: Murtuza Zabuawala Modified Files -- web/

Re: [pgAdmin4][Patch#3013] Fixed minor UI issue on Dashboard

2018-01-15 Thread Dave Page
Thanks, patch applied. On Mon, Jan 15, 2018 at 7:59 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the minor UI issue on dashboard while displaying subnode > control in Backgrid. > RM#3013 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://

Re: [pgAdmin4][Patch]: RM #2904: As a visually impaired user I need all buttons in the application to have appropriate tooltips for my screen reader to interpret

2018-01-15 Thread Dave Page
Hi On Mon, Jan 15, 2018 at 10:23 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch for RM # 2904: As a visually impaired user > I need all buttons in the application to have appropriate tooltips for my > screen reader to interpret. > Unfortunat

Re: pgadmin4 server error message processing

2018-01-15 Thread Ioseph Kim
This bug was not fixed still,   File "/usr/lib/python2.7/site-packages/pgadmin4-web/pgadmin/utils/driver/psycopg2/__init__.py", line 1541, in _formatted_exception_msg     self.decode_to_utf8(exception_obj.diag.message_primary) UnicodeDecodeError: 'ascii' codec can't decode byte 0xec in positio

Re: ESLINT: On pgAdmin static javascripts

2018-01-15 Thread Fahar Abbas
Hi Ashesh, I have finished smoke verification for all the modules and no issue found so far and currently doing testing in detail. Kind Regards, On Mon, Jan 15, 2018 at 10:17 AM, Fahar Abbas wrote: > > > On Fri, Jan 12, 2018 at 12:35 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote:

Re: ESLINT: On pgAdmin static javascripts

2018-01-15 Thread Ashesh Vashi
On Tue, Jan 16, 2018 at 11:10 AM, Fahar Abbas wrote: > Hi Ashesh, > > I have finished smoke verification for all the modules and no issue found > so far and currently doing testing in detail. > Thanks Fahar for the update! -- Thanks & Regards, Ashesh Vashi > > Kind Regards, > > > On Mon, Jan 1