[pgAdmin4][Patch#2902] To add ALT tags for images in pgAdmin4

Hi, PFA patch to add ALT tags in all the images for accessibility. RM#2902 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/about/templates/about/index.html b/web/pgadmin/about/templates/about/index.html index ece

Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

Hi On Fri, Jan 5, 2018 at 7:50 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Further details: > > 1. If session is expired and user performs any action from sqleditor that > makes ajax call > then in ajax error call back user can check and handle login related error > using code

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Hi On Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch, > > > On Wed, Jan 3, 2018 at 10:44 PM, Dave Page wrote: > >> Hi >> >> On Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wr

Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

On Mon, Jan 8, 2018 at 4:34 PM, Dave Page wrote: > Hi > > On Fri, Jan 5, 2018 at 7:50 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Further details: >> >> 1. If session is expired and user performs any action from sqleditor that >> makes ajax call >> then in ajax error call

Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

HI On Mon, Jan 8, 2018 at 11:41 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > On Mon, Jan 8, 2018 at 4:34 PM, Dave Page wrote: > >> Hi >> >> On Fri, Jan 5, 2018 at 7:50 AM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote: >> >>> Further details: >>> >>> 1. If session

Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

On Mon, Jan 8, 2018 at 5:15 PM, Dave Page wrote: > HI > > On Mon, Jan 8, 2018 at 11:41 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> On Mon, Jan 8, 2018 at 4:34 PM, Dave Page wrote: >> >>> Hi >>> >>> On Fri, Jan 5, 2018 at 7:50 AM, Harshal Dhumal < >>> harshal.dhu...@enterp

Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

On Mon, Jan 8, 2018 at 12:37 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > On Mon, Jan 8, 2018 at 5:15 PM, Dave Page wrote: > >> HI >> >> On Mon, Jan 8, 2018 at 11:41 AM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote: >> >>> On Mon, Jan 8, 2018 at 4:34 PM, Dave Page

Re: [pgAdmin4][Patch#2902] To add ALT tags for images in pgAdmin4

Thanks, patch applied. On Mon, Jan 8, 2018 at 9:54 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to add ALT tags in all the images for accessibility. > RM#2902 > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterp

pgAdmin 4 commit: Add ALT tags to images for accessibility. Fixes #2902

Add ALT tags to images for accessibility. Fixes #2902 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aec86970f2620295a444d20958f53206fe1ec24d Author: Murtuza Zabuawala Modified Files -- web/pgadmin/about/templates/about/index.htm

Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

On Mon, Jan 8, 2018 at 6:11 PM, Dave Page wrote: > > > On Mon, Jan 8, 2018 at 12:37 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> On Mon, Jan 8, 2018 at 5:15 PM, Dave Page wrote: >> >>> HI >>> >>> On Mon, Jan 8, 2018 at 11:41 AM, Harshal Dhumal < >>> harshal.dhu...@enterpri

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Hi Dave, PFA updated patch. On Mon, Jan 8, 2018 at 5:11 PM, Dave Page wrote: > Hi > > On Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> PFA updated patch, >> >> >> On Wed, Jan 3, 2018 at 10:44 PM, Dave Page wrote: >> >>> Hi >>> >>> On Thu, Dec 28,

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch. > > On Mon, Jan 8, 2018 at 5:11 PM, Dave Page wrote: > >> Hi >> >> On Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >>

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

On Mon, Jan 8, 2018 at 7:21 PM, Dave Page wrote: > > > On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> PFA updated patch. >> >> On Mon, Jan 8, 2018 at 5:11 PM, Dave Page wrote: >> >>> Hi >>> >>> On Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala < >

Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

On Mon, Jan 8, 2018 at 1:18 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > > On Mon, Jan 8, 2018 at 6:11 PM, Dave Page wrote: > >> >> >> On Mon, Jan 8, 2018 at 12:37 PM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote: >> >>> On Mon, Jan 8, 2018 at 5:15 PM, Dave Page w

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Yes, I agree, it's a good idea to have it optional, I'll work on it and send updated patch. by the way what should be default behaviour? Should we make it disabled by default? On Mon, Jan 8, 2018 at 7:26 PM, Ashesh Vashi wrote: > On Mon, Jan 8, 2018 at 7:21 PM, Dave Page wrote: > >> >> >> On M

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

On Mon, Jan 8, 2018 at 2:04 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Yes, I agree, it's a good idea to have it optional, I'll work on it and > send updated patch. > by the way what should be default behaviour? Should we make it disabled by > default? > No - users proba

Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

On Mon, Jan 8, 2018 at 7:26 PM, Dave Page wrote: > > > On Mon, Jan 8, 2018 at 1:18 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> >> On Mon, Jan 8, 2018 at 6:11 PM, Dave Page wrote: >> >>> >>> >>> On Mon, Jan 8, 2018 at 12:37 PM, Harshal Dhumal < >>> harshal.dhu...@enterpris

Re: ESLINT: On pgAdmin static javascripts

Hi I think these are impossibly big to properly review by hand, especially where much of them are whitespace changes. I think the best option is to check the regression tests all pass, do some manual testing yourself, and then commit. On Mon, Jan 8, 2018 at 1:55 PM, Ashesh Vashi wrote: > Hi Da

Re: ESLINT: On pgAdmin static javascripts

On Mon, Jan 8, 2018 at 8:31 PM, Dave Page wrote: > Hi > > I think these are impossibly big to properly review by hand, especially > where much of them are whitespace changes. > I ran both jasmine test framework, and feature tests. Both are running fine. > > I think the best option is to check th

Re: ESLINT: On pgAdmin static javascripts

Hi On Mon, Jan 8, 2018 at 3:18 PM, Ashesh Vashi wrote: > On Mon, Jan 8, 2018 at 8:31 PM, Dave Page wrote: > >> Hi >> >> I think these are impossibly big to properly review by hand, especially >> where much of them are whitespace changes. >> > I ran both jasmine test framework, and feature tests

Re: ESLINT: On pgAdmin static javascripts

On Mon, Jan 8, 2018 at 8:52 PM, Dave Page wrote: > Hi > > On Mon, Jan 8, 2018 at 3:18 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Mon, Jan 8, 2018 at 8:31 PM, Dave Page wrote: >> >>> Hi >>> >>> I think these are impossibly big to properly review by hand, especially >>> whe

Re: ESLINT: On pgAdmin static javascripts

​Hi Ashesh, I'm not able to apply patch :( murtuza@debian:~/projects/pgadmin4$ git apply ~/Desktop/*.patch error: patch failed: web/pgadmin/misc/file_manager/static/js/utility.js:10 error: web/pgadmin/misc/file_manager/static/js/utility.js: patch does not apply murtuza@debain:~/projects/pgadmin

Re: ESLINT: On pgAdmin static javascripts

Please try rest of the patches... They are independent of each other. -- Thanks, Ashesh On Jan 8, 2018 23:45, "Murtuza Zabuawala" < murtuza.zabuaw...@enterprisedb.com> wrote: > ​Hi Ashesh, > > I'm not able to apply patch :( > > murtuza@debian:~/projects/pgadmin4$ git apply ~/Desktop/*.patch > er

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Hi Dave, Please find updated patch. On Mon, Jan 8, 2018 at 7:21 PM, Dave Page wrote: > > > On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi Dave, >> >> PFA updated patch. >> >> On Mon, Jan 8, 2018 at 5:11 PM, Dave Page wrote: >> >>> Hi >>