pgAdmin 4 commit: Add a missing screenshot, and remove personal info fr

2017-11-30 Thread Dave Page
Add a missing screenshot, and remove personal info from another. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=709f646f5e0f6020afe94f844379898e38a991f4 Author: Chethana Kumar Modified Files -- docs/en_US/images/role_membership.p

Re: [pgAdmin4][RM2922] Login desktop user only once in runtime

2017-11-30 Thread Dave Page
Hi Does this resolve the suggestion in https://redmine.postgresql.org/issues/2919 about creating new sessions? On Thu, Nov 30, 2017 at 7:58 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch to fix issue where desktop user was logged in > each reque

pgAdmin 4 commit: Cleanup the layout of the filter data dialogue. Fixes

2017-11-30 Thread Dave Page
Cleanup the layout of the filter data dialogue. Fixes #2924 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=389cf01af753e6c96a558131779312c0e177340b Author: Murtuza Zabuawala Modified Files -- web/pgadmin/tools/datagrid/static/js/

pgAdmin 4 commit: Fix the width of Role dialogue so tabs don't wrap.

2017-11-30 Thread Dave Page
Fix the width of Role dialogue so tabs don't wrap. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2995d6e9c5e93901ff47fe193129efb5d4494580 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/browser/server_groups/servers/role

pgAdmin 4 commit: Refuse password changes (and tell the user) if the no

2017-11-30 Thread Dave Page
Refuse password changes (and tell the user) if the notification email cannot be sent. Fixes #2892 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=35a5cf22d5094645b1e2e66e7d2fbe1c40847232 Author: Harshal Dhumal Modified Files -- w

Re: [pgAdmin4][RM2892] Handle password changes properly if error occurs during sending email

2017-11-30 Thread Dave Page
Thanks - applied with minor changes to localise the messages and make it clear to the user that their password wasn't changed if there was an error. On Thu, Nov 30, 2017 at 6:11 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Unlike flask login-manager flask-security does n

Re: [pgAdmin4][RM2892] Handle password changes properly if error occurs during sending email

2017-11-30 Thread Dave Page
Oh, nuts - turns out this breaks the regression tests (the Python API tests) if they're run with SERVER_MODE = True. Can you take a look ASAP please? Traceback (most recent call last): File "regression/runtests.py", line 325, in test_utils.login_tester_account(test_client) File "/Users/dp

Re: [pgAdmin4][RM2892] Handle password changes properly if error occurs during sending email

2017-11-30 Thread Harshal Dhumal
sure Dave, looking in it now. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Nov 30, 2017 at 5:01 PM, Dave Page wrote: > Oh, nuts - turns out this breaks the regression tests (the Python API > tests) if the

Re: [pgAdmin4][RM2922] Login desktop user only once in runtime

2017-11-30 Thread Dave Page
Thanks, applied. On Thu, Nov 30, 2017 at 7:58 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch to fix issue where desktop user was logged in > each request > in runtime. > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: ht

pgAdmin 4 commit: Don't login the user with every request in desktop mo

2017-11-30 Thread Dave Page
Don't login the user with every request in desktop mode. Just do it once. Fixes #2922 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f3256aef712faee6744c404415ff9afc8c248490 Author: Harshal Dhumal Modified Files -- web/pgadmin/_

Patch for pgAdmin docs (role_dialog.rst, resource_group_dialog.rst)

2017-11-30 Thread Susan Douglas
Hi All, I've attached a patch that updates the following files (correcting minor problems, adding missing tabs, etc.): resource_group_dialog.rst role_dialog.rst Dave has checked in the screenshots that go with these updates - Let me know if there are any problems! Thanks! -- Susan pgadmin

Re: Patch for pgAdmin docs (role_dialog.rst, resource_group_dialog.rst)

2017-11-30 Thread Dave Page
Hi On Thu, Nov 30, 2017 at 12:04 PM, Susan Douglas < susan.doug...@enterprisedb.com> wrote: > Hi All, > > I've attached a patch that updates the following files (correcting minor > problems, adding missing tabs, etc.): > > resource_group_dialog.rst > role_dialog.rst > > Dave has checked in the sc

Re: [pgAdmin4][Patch]: RM #2849 - Allow editing of data on tables with OIDs but no primary key

2017-11-30 Thread Khushboo Vashi
Hi, Please find the attached updated patch. On Mon, Nov 27, 2017 at 5:15 PM, Dave Page wrote: > Hi > > On Thu, Nov 23, 2017 at 1:28 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch for RM #2849: Allow editing of data on >> tables with

pgAdmin 4 commit: Doc updates for resource groups and roles.

2017-11-30 Thread Dave Page
Doc updates for resource groups and roles. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=54389595da90513a60b08775d30a1e667f6c9633 Author: Susan Douglas Modified Files -- docs/en_US/resource_group_dialog.rst | 15 ---

Re: Patch for pgAdmin docs (role_dialog.rst, resource_group_dialog.rst)

2017-11-30 Thread Susan Douglas
Hi All, Dave helped me through this problem on chat... Thanks! -- Susan > On Nov 30, 2017, at 7:09 AM, Dave Page wrote: > > Hi > > On Thu, Nov 30, 2017 at 12:04 PM, Susan Douglas > mailto:susan.doug...@enterprisedb.com>> > wrote: > Hi All, > > I've attached a patch that updates the follo

[pgAdmin4][Patch]: To fix the issue in Debugger module

2017-11-30 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where debugger failed to run when user tries to debug the function which call itself recursively. RM#2524 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/debugger/templates/debu

Re: [pgAdmin4][RM2892] Handle password changes properly if error occurs during sending email

2017-11-30 Thread Harshal Dhumal
Hi Dave, Please find patch to fix testsuite. Changes: 1. Set config parameters SECURITY_RECOVERABLE and SECURITY_CHANGEABLE to True if SERVER_MODE is True while running testsuite (Though we have set these parameters to True in create_app function but regression testsuite initialises (imports) bro

pgAdmin 4 commit: Fix regression tests for password reset in server mod

2017-11-30 Thread Dave Page
Fix regression tests for password reset in server mode Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1a4e21e6dd689aa6e5c53f1453f342529850aaa3 Author: Harshal Dhumal Modified Files -- web/pgadmin/browser/__init__.py

Re: [pgAdmin4][RM2892] Handle password changes properly if error occurs during sending email

2017-11-30 Thread Dave Page
Thanks, applied. On Thu, Nov 30, 2017 at 1:04 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > Please find patch to fix testsuite. > > Changes: > 1. Set config parameters SECURITY_RECOVERABLE and SECURITY_CHANGEABLE to > True if SERVER_MODE is True > while running tests

Re: [pgAdmin4][RM2922] Login desktop user only once in runtime

2017-11-30 Thread Harshal Dhumal
Dave, On Thu, Nov 30, 2017 at 3:38 PM, Dave Page wrote: > Hi > > Does this resolve the suggestion in https://redmine.postgresql. > org/issues/2919 about creating new sessions? > Do you think we should allow endpoint /misc/ping to be accessible outside of Qt application as long as user passes PG

[pgAdmin4][Patch]: Remove default 'Altertify JS' header from debugger related error alerts

2017-11-30 Thread Murtuza Zabuawala
Hi, PFA patch to remove default 'Altertify JS' header from debugger related error notifications. RM#2098 Also fixed similar issue in other modules. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/debugger/st