Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

2017-11-17 Thread Neel Patel
Hi Dave, On Thu, Nov 16, 2017 at 8:13 PM, Dave Page wrote: > Hi > > On Thu, Nov 16, 2017 at 1:47 PM, Neel Patel > wrote: > >> Hi, >> >> Adding information. >> >> With this patch, RM#2715 should also be resolved. >> >> Thanks, >> Neel Patel >> >> On Thu, Nov 16, 2017 at 7:01 PM, Neel Patel >> w

Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

2017-11-17 Thread Dave Page
On Fri, Nov 17, 2017 at 8:45 AM, Neel Patel wrote: > Hi Dave, > > On Thu, Nov 16, 2017 at 8:13 PM, Dave Page wrote: > >> Hi >> >> On Thu, Nov 16, 2017 at 1:47 PM, Neel Patel >> wrote: >> >>> Hi, >>> >>> Adding information. >>> >>> With this patch, RM#2715 should also be resolved. >>> >>> Thanks

Re: Next release

2017-11-17 Thread Dave Page
Hi The entire point of this patch was to allow an older version of pgAdmin to run against a newer version of the database without throwing errors like this. Of course, it'll only work if we're careful to ensure we don't make any backward-incompatible changes, but adding columns such as this change

Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

2017-11-17 Thread Neel Patel
Hi Dave, On Fri, Nov 17, 2017 at 2:42 PM, Dave Page wrote: > > > On Fri, Nov 17, 2017 at 8:45 AM, Neel Patel > wrote: > >> Hi Dave, >> >> On Thu, Nov 16, 2017 at 8:13 PM, Dave Page wrote: >> >>> Hi >>> >>> On Thu, Nov 16, 2017 at 1:47 PM, Neel Patel >> > wrote: >>> Hi, Adding in

Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

2017-11-17 Thread Dave Page
On Fri, Nov 17, 2017 at 9:36 AM, Neel Patel wrote: > Hi Dave, > > On Fri, Nov 17, 2017 at 2:42 PM, Dave Page wrote: > >> >> >> On Fri, Nov 17, 2017 at 8:45 AM, Neel Patel >> wrote: >> >>> Hi Dave, >>> >>> On Thu, Nov 16, 2017 at 8:13 PM, Dave Page wrote: >>> Hi On Thu, Nov 16, 2

Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

2017-11-17 Thread Neel Patel
Hi Dave, On Fri, Nov 17, 2017 at 3:09 PM, Dave Page wrote: > > > On Fri, Nov 17, 2017 at 9:36 AM, Neel Patel > wrote: > >> Hi Dave, >> >> On Fri, Nov 17, 2017 at 2:42 PM, Dave Page wrote: >> >>> >>> >>> On Fri, Nov 17, 2017 at 8:45 AM, Neel Patel >> > wrote: >>> Hi Dave, On Thu,

Re: Next release

2017-11-17 Thread Surinder Kumar
Hi On Fri, Nov 17, 2017 at 2:46 PM, Dave Page wrote: > Hi > > The entire point of this patch was to allow an older version of pgAdmin to > run against a newer version of the database without throwing errors like > this. Of course, it'll only work if we're careful to ensure we don't make > any ba

Re: Next release

2017-11-17 Thread Dave Page
On Fri, Nov 17, 2017 at 10:04 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > On Fri, Nov 17, 2017 at 2:46 PM, Dave Page wrote: > >> Hi >> >> The entire point of this patch was to allow an older version of pgAdmin >> to run against a newer version of the database without thr

Re: [pgAdmin4][Patch]: To make error message uniform for Create schema action

2017-11-17 Thread Murtuza Zabuawala
Hi, PFA updated. On Thu, Nov 16, 2017 at 5:12 PM, Dave Page wrote: > > > On Tue, Nov 14, 2017 at 5:56 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> PFA minor patch to make error message uniform for 'Create schema' in both >> query tool and create schema dia

[Patch]: Installer: pgAdmin4 should not install in special character path

2017-11-17 Thread Paresh More
Hello Team, I have made three changes for installer generation scripts. 1) Modified Make-MinGW.bat to support yarn and nodejs validation in the script and also QT 5.9.1 support. 2) Bug fix for RM1365. Currently string datatypes used in Inno tool does not support regular expression, so added a us

[pgAdmin4][Patch]: Add support for time without time zone

2017-11-17 Thread Murtuza Zabuawala
Hi, PFA minor patch to add support for time without time zone. RM#2881 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/utils/driver/psycopg2/__init__.py b/web/pgadmin/utils/driver/psycopg2/__init__.py index eabe3b

Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

2017-11-17 Thread Neel Patel
Hi Dave, I have tried for 350K rows with query given by you but not able to reproduce the hang issue. I have put some debug statement in Qt Signal's handler. Can you please apply this debug patch and provide me console output if possible ? Thanks, Neel Patel On Fri, Nov 17, 2017 at 3:13 PM, Neel