pgAdmin 4 commit: Properly set the hostname for SSL use in containers.

Properly set the hostname for SSL use in containers. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cf1440f41d1c8f6352b7a563ec8fcf62af86b4e1 Modified Files -- pkg/docker/pgadmin4.conf.j2 | 2 +- 1 file changed, 1 insertion(+), 1 de

[pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

Hi, Please find the attached patch for RM #2781 : New option to set the quotation mark for copying to clipboard. This patch includes: - Provide options in preferences to control the CSV output which includes copy to clipboard and download as CSV features in Query Tool - Modified related jasmine

pgAdmin 4 commit: Focus on the filter textarea when opening filter opti

Focus on the filter textarea when opening filter options in the query tool. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=af2722faa3a083ebb3fb0004901b162353cc8fde Author: Murtuza Zabuawala Modified Files -- web/pgadmin/tools/sql

Re: [pgAdmin4][Patch]: Set focus on Filter window when opened by user

Thanks, applied. When you get a minute, could you also look at the View Filtered Data menu option? The initial filter dialogue there seems to have the same problem, plus the layout is a little messed up. On Tue, Nov 14, 2017 at 5:25 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrot

Re: [pgAdmin4][Patch]: To make error message uniform for Create schema action

On Tue, Nov 14, 2017 at 5:56 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to make error message uniform for 'Create schema' in both > query tool and create schema dialog. > RM#2094 > The error message is definitely an improvement, but the dialogue t

pgAdmin 4 commit: Display long names appropriately in dialogue headers.

Display long names appropriately in dialogue headers. Fixes #2278 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=537f6f0ab1fccaae80b1e0300d66190dc525ce48 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/scss/_alerti

Re: [pgAdmin4][Patch]: Display long object name on alertify dialog header

Thanks, patch applied. On Wed, Nov 15, 2017 at 9:51 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to display database object names on alertify dialog header > if they are long and user have low screen resolution. > RM#2278 > > -- > Regards, > Murtuza

pgAdmin 4 commit: Python tests don't need to have JS dependencies insta

Python tests don't need to have JS dependencies installed. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3c27d2fd7eeb08fc3dd0b27a48db1f3f947eaa33 Modified Files -- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Current versions of Chrome need a newer driver for se

Current versions of Chrome need a newer driver for selenium tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=afd65018db1048fa703cb0a2a37ed60fc65a2f98 Modified Files -- web/regression/requirements.txt | 2 +- 1 file changed, 1

Re: Fix for minor issue RM2868

Thanks, applied. On Wed, Nov 15, 2017 at 10:35 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Path to fix minor issue "local variable 'password' referenced before > assignment." > > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterp

pgAdmin 4 commit: Fix a referenced before assignment bug in connection

Fix a referenced before assignment bug in connection management. Fixes #2868 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=051788d040049682cbde78c4bb5343f92b4eb5a2 Author: Harshal Dhumal Modified Files -- web/pgadmin/browser/ser

[pgAdmin4][Patch]: To upgrade Selenium

Hi, PFA patch to upgrade Selenium module to latest version. Tested on Python3.6 and working fine with latest chrome webdriver. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/regression/requirements.txt b/web/regression/re

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

Hi Looks good. A few changes/suggestions: - There seem to be some debugger calls left in the code, e.g. in editors.js - Instead of bgcolor and font_color, lets use bgcolor and fgcolor (foreground). - The docs are (technically) en_US, so we should use color not colour in them. - If the colours hav

Re: Next release

On Fri, Aug 25, 2017 at 9:34 AM, Dave Page wrote: > > > On Fri, Aug 25, 2017 at 9:28 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> One more thing that this will only work for future pgAdmin4 versions >> > > > Yeah :-( > Hmm, can you check this please? I'm getting the error

[pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

Hi, I am able to reproduce the crash while downloading and save data in CSV file from query tool. Please find attached updated patch with below changes after reading Qt documentation. - Added new signal "readyRead". As per the Qt documentation, this signal will be emitted when data is read

Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

Hi, Adding information. With this patch, RM#2715 should also be resolved. Thanks, Neel Patel On Thu, Nov 16, 2017 at 7:01 PM, Neel Patel wrote: > Hi, > > I am able to reproduce the crash while downloading and save data in CSV > file from query tool. > > Please find attached updated patch with

[pgAdmin4][Patch]: To fix issues in Boolean editor

Hi, PFA patch to fix the issue in boolean editor & also corrected feature test. RM#2848 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/feature_tests/view_data_dml_queries.py b/web/pgadmin/feature_tests/view_data_

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

Hi On Thu, Nov 16, 2017 at 10:01 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch for RM #2781 : New option to set the > quotation mark for copying to clipboard. > > This patch includes: > > - Provide options in preferences to control the CSV o

pgAdmin 4 commit: Update selenium version

Update selenium version Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2f17ecba760dcb210b6bf70b259860dd569a7888 Author: Murtuza Zabuawala Modified Files -- web/regression/requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1

Re: [pgAdmin4][Patch]: To upgrade Selenium

Thanks, applied. On Thu, Nov 16, 2017 at 12:52 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to upgrade Selenium module to latest version. > Tested on Python3.6 and working fine with latest chrome webdriver. > > -- > Regards, > Murtuza Zabuawala > Enterpri

Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

Hi On Thu, Nov 16, 2017 at 1:47 PM, Neel Patel wrote: > Hi, > > Adding information. > > With this patch, RM#2715 should also be resolved. > > Thanks, > Neel Patel > > On Thu, Nov 16, 2017 at 7:01 PM, Neel Patel > wrote: > >> Hi, >> >> I am able to reproduce the crash while downloading and save

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

Hi Dave, Thanks for reviewing the patch. On Thu, Nov 16, 2017 at 7:42 PM, Dave Page wrote: > Hi > > On Thu, Nov 16, 2017 at 10:01 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch for RM #2781 : New option to set the >> quotation mark f

Build failed in Jenkins: pgadmin4-master-python26 #510

See Changes: [Dave Page] Update selenium version -- Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change Started by

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

Hi On Thu, Nov 16, 2017 at 2:04 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue in boolean editor & also corrected feature test. > RM#2848 > Testing in webkit on Mac (Qt 5.8), the problem does not appear to be solved for me. I have run make

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

Hi Dave, On Thu, Nov 16, 2017 at 8:59 PM, Dave Page wrote: > Hi > > On Thu, Nov 16, 2017 at 2:04 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to fix the issue in boolean editor & also corrected feature >> test. >> RM#2848 >> > > Testing in webkit on Mac (Qt 5.8), the

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

On Thu, Nov 16, 2017 at 4:30 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Thu, Nov 16, 2017 at 8:59 PM, Dave Page wrote: > >> Hi >> >> On Thu, Nov 16, 2017 at 2:04 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA

Re: Next release

Hi Dave, There is no programmatic way of fixing the issue if you have already deleted the new migration file without downgrading via alembic downgrade command. The only way I know is to manually update 'alembic_version' table in pgAdmin4.db to current revision which is 'ef590e979b0d' ​-- Murtuza​