[pgAdmin4][Patch]: To fix the issues in Explain module

2017-11-06 Thread Murtuza Zabuawala
Hi, PFA patch to fix the following issues, 1) Node label alignment issue in Sub-plans if the database object has long name. RM#2843 2) Node label not displaying properly if the database object has long name. RM#2842 3) Node label was incorrect if we run "Explain Analyze" on a query that invokes

Re: [pgAdmin4][Patch]: To fix the issues in Explain module

2017-11-06 Thread Murtuza Zabuawala
Hi, Please disregard previous patch, here is the correct patch. On Mon, Nov 6, 2017 at 3:04 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the following issues, > > 1) Node label alignment issue in Sub-plans if the database object has long > name.

Re: Fixes for pgAdmin4 messages

2017-11-06 Thread Alexander Lakhin
Hello, 05.11.2017 16:36, Dave Page wrote: That looks like it - thanks, applied! Thank you! And another one. (I've processed onText/offText instances, alertify.*  calls and depends.js) Please look at it. -- Alexander Lakhin Postgres Professional: http://www.postgrespro.com The Russian Post

Re: Fixes for pgAdmin4 messages

2017-11-06 Thread Alexander Lakhin
Hello, 05.11.2017 16:36, Dave Page wrote: That looks like it - thanks, applied! Thank you! And another one. (I've processed onText/offText instances, alertify.*  calls and depends.js) Please look at it. -- Alexander Lakhin Postgres Professional: http://www.postgrespro.com The Russian Post

Re: Fixes for pgAdmin4 messages

2017-11-06 Thread Dave Page
Hi I think you forgot to attach the patch. Thanks, Dave On Mon, Nov 6, 2017 at 9:00 AM, Alexander Lakhin wrote: > Hello, > > 05.11.2017 16:36, Dave Page wrote: > > That looks like it - thanks, applied! > > Thank you! > > And another one. > (I've processed onText/offText instances, alertify.*

pgAdmin 4 commit: Further missing translation fixes. Stats now:

2017-11-06 Thread Dave Page
Further missing translation fixes. Stats now: 1481 of 1831 messages (80%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po 1694 of 1831 messages (92%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po 1748 of 1831 messages (95%) translated in pgadmin/translations/pl/LC_

Re: Fixes for pgAdmin4 messages

2017-11-06 Thread Dave Page
Thanks, applied with some wording tweaks. On Mon, Nov 6, 2017 at 9:13 AM, Alexander Lakhin wrote: > Hello, > > 05.11.2017 16:36, Dave Page wrote: > > That looks like it - thanks, applied! > > Thank you! > > And another one. > (I've processed onText/offText instances, alertify.* calls and depend

Re: [pgAdmin4][Patch]: To fix the issues in Explain module

2017-11-06 Thread Dave Page
Thanks, applied! On Mon, Nov 6, 2017 at 4:42 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Please disregard previous patch, here is the correct patch. > > > On Mon, Nov 6, 2017 at 3:04 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to fix t

pgAdmin 4 commit: Fix a number of graphical explain rendering issues. F

2017-11-06 Thread Dave Page
Fix a number of graphical explain rendering issues. Fixes #2824. Fixes #2842. Fixes #2843. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8b543a58fe516ed0a35a22b1dad57eef93e52c98 Author: Murtuza Zabuawala Modified Files -- web/p

[pgAdmin4][patch][runtime]: RM#2443 - No prompt while exiting application

2017-11-06 Thread Neel Patel
Hi, Please find attached patch to fix RM#2443 - No prompt while existing from main pgAdmin4 runtime browser window. Do review it and let me know for comments. Thanks, Neel Patel RM_2443.patch Description: Binary data