pgAdmin 4 commit: Support React v15.5 and later where the code fails to

Support React v15.5 and later where the code fails to run because React's PropTypes is no more part of React Module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=026ef7b8b7effe001ccfe2eabb562bcae0ca716b Author: Surinder Kumar Modified Fil

Re: [pgAdmin4][Patch]: Use standalone modules prop-types as React.PropTypes has moved into a different package since React v15.5

Thanks, applied. On Mon, Sep 18, 2017 at 6:28 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > While looking into a React bug, I tried running pgAdmin4 code with > Reactv15.5 or with Reactv16-RC-3, the code fails to run. > Because React's PropTypes is no more part of React Mo

pgAdmin 4 commit: Fix filtering of system schemas so pg_* is hidden but

Fix filtering of system schemas so pg_* is hidden but pg* is not. Fixes #2709 Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ca1dd9d15fbd04dde153c1c5221386a13e0f8d9a Author: Murtuza Zabuawala Modified Files -- .../template

pgAdmin 4 commit: Support React v15.5 and later where the code fails to

Support React v15.5 and later where the code fails to run because React's PropTypes is no more part of React Module. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4035fab6e7d1bcbd84115a963072b3de5be25485 Author: Surinder Kumar Modif

pgAdmin 4 commit: Fix menu left-hand margin.

Fix menu left-hand margin. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3485f5b607d11188c83d0b4d2841b93808da50a6 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/css/bootstrap.overrides.css | 6 +- 1 fil

pgAdmin 4 commit: Changed array representation and formatting for the d

Changed array representation and formatting for the data types in Query Tool and View Data. Fixes #2671 Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=79e6e11668e7762f1f2759091eb109cbfa9f4932 Author: Harshal Dhumal Modified Files ---

pgAdmin 4 commit: Replace the "Roboto" font family with "Open Sans" for

Replace the "Roboto" font family with "Open Sans" for alertify dialogs. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0b5b684652293ba85138f0d9d02f9cab5d8e37f6 Author: Atul Sharma Modified Files -- web/pgadmin/static/css/p

pgAdmin 4 commit: Ensure builtins.SERVER_MODE is set in the WSGI wrappe

Ensure builtins.SERVER_MODE is set in the WSGI wrapper. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a317df1351f1f9c1cd2adc38e002a54fd837cf58 Modified Files -- web/pgAdmin4.wsgi | 8 1 file changed, 8 insertions(+)

Re: [pgAdmin4][Patch]: Properly handle builtins.SERVER_MODE variable when SERVER_MODE is not set

Hi I'd already sent a suggested fix for this to Ashesh. I've just pushed that (it updates the WSGI file, not the config file). On Mon, Sep 18, 2017 at 6:46 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > While configuring pgAdmin4 with Apache mod_wsgi, it fails to run apach

Re: [pgAdmin4][Patch]: Properly handle builtins.SERVER_MODE variable when SERVER_MODE is not set

On Mon, Sep 18, 2017 at 7:18 AM, Harshal Dhumal wrote: > I think this is similar issue.. > https://redmine.postgresql.org/issues/2134 > > I don't think that's relevant any more - it's certainly working for me. Can you check please? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsna

pgAdmin 4 commit: Ensure builtins.SERVER_MODE is set in the WSGI wrappe

Ensure builtins.SERVER_MODE is set in the WSGI wrapper. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9c1a28121da2012b80dabea4457a9d7b75c2218c Author: Dave Page Modified Files -- web/pgAdmin4.wsgi | 8 1 file chan

[pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

Hi, PFA minor patch to fix the issue where logic to extract the error using RegEX from error message was incorrect in Query tool(History tab). RM#2700 Another minor issue which I observed on login page is that close button on alert is little misaligned(screenshot attached). -- Regards, Murtuza Z

Re: [pgAdmin4][Patch]: Properly handle builtins.SERVER_MODE variable when SERVER_MODE is not set

Hi On Mon, Sep 18, 2017 at 3:05 PM, Dave Page wrote: > Hi > > I'd already sent a suggested fix for this to Ashesh. I've just pushed that > (it updates the WSGI file, not the config file). > ​Yes, It's a proper fix.​ ​I have tested with latest git pull and it works.​ > > On Mon, Sep 18, 2017 at

pgAdmin 4 commit: Support Flask-Security 3.0

Support Flask-Security 3.0 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=765e1303363a03e64dd6b440b0d7429ab1df3b05 Author: Harshal Dhumal Modified Files -- web/pgadmin/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[pgAdmin4][Patch]: Fix the Enabale/Disbale trigger functionality

Hi, PFA minor patch which fixes, 1) To fix the Enable/Disable trigger functionality. RM#2707 2) Corrected the typo in gettext string causing malformed string in TableSpace module. RM#2708 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix user manager role handling. Fixes #2641

Fix user manager role handling. Fixes #2641 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=da40573f0b4c104e17bbec89835449248fb0a260 Author: Harshal Dhumal Modified Files -- .../user_management/static/js/user_management.js | 24

Re: [PATCH] Work with newer Flask-Security.

Thanks, applied. On Wed, Aug 9, 2017 at 3:19 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > I tested this change with Flask-Security 3.0.0 and 1.7.5 (we ship pgAdmin4 > with 1.7.5) and with 2.7 and 3.0+. > This is working as expected. > > Apart from this I also found some

pgAdmin 4 commit: Fix error message regexp in the query tool that could

Fix error message regexp in the query tool that could fail in some cases. Fixes #2700 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bc5a5a5b45052ba99e56a75f4d22a87df7222bd1 Author: Murtuza Zabuawala Modified Files -- web/pgadmi

pgAdmin 4 commit: Correct alignment of the X button on dismissable aler

Correct alignment of the X button on dismissable alerts. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5ebfd88f11048bfde586d2caeaef63f51745b2bf Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/css/bootstrap.overrid

Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

Hi On Mon, Sep 18, 2017 at 10:54 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the issue where logic to extract the error using > RegEX from error message was incorrect in Query tool(History tab). > RM#2700 > Thanks - applied, but - Coul

pgAdmin 4 commit: Fix tablespace move prompt message. Fixes #2708

Fix tablespace move prompt message. Fixes #2708 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e64c52a4467af24a20512e849756f89947ed6084 Author: Murtuza Zabuawala Modified Files -- .../browser/server_groups/servers/tablespaces/sta

Re: [pgAdmin4][Patch]: Fix the Enabale/Disbale trigger functionality

Thanks, applied. On Mon, Sep 18, 2017 at 11:43 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch which fixes, > > 1) To fix the Enable/Disable trigger functionality. > RM#2707 > > 2) Corrected the typo in gettext string causing malformed string in > Tabl

pgAdmin 4 commit: Fix disable trigger menu option. Fixes #2707

Fix disable trigger menu option. Fixes #2707 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8bededa859041ee6384a6dff22b93c67dbeeedc8 Author: Murtuza Zabuawala Modified Files -- .../schemas/tables/triggers/static/js/trigger.js |

[pgAdmin4][Patch] RM 2691 View data option is missing from pgAdmin4 2.0 version

Hi Attached is the patch file to fix RM 2691 View data option is missing from pgAdmin4 2.0 version. Apart from the RM this patch includes following fixes: 1) Fixed issue in foreign_table where variable is not declare so it throws an error. 2) Columns and Constraints tab are empty, remove "visible

Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

Hi Dave, PFA patch. On Mon, Sep 18, 2017 at 4:34 PM, Dave Page wrote: > Hi > > On Mon, Sep 18, 2017 at 10:54 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA minor patch to fix the issue where logic to extract the error using >> RegEX from error message was incorrect in Query

Fix for Exception when the server is restarted [RM2713][pgAdmin4]

Hi, This issue was caused because we recently added session_write_delay in session. So session won't be written/updated to disk from memory until specified seconds are elapsed. However we must forcefully write/update session to disk if user loges in or out irrespective of session_write_delay to k

Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

Hi Dave, Please disregard my previous patch and instead attaching updated patch. In my previous patch I used `let` keyword instead of `var` for defining variable, for consistency & backward compatibility I have used `var` in my latest patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www

pgAdmin 4 commit: Fix View Data option and column config for Foreign Ta

Fix View Data option and column config for Foreign Tables. Fixes #2691 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bdc08d94c494301c20135371c59356fac5c40f1c Author: Akshay Joshi Modified Files -- .../databases/schemas/foreign_t

Re: [pgAdmin4][Patch] RM 2691 View data option is missing from pgAdmin4 2.0 version

Thanks, applied. On Mon, Sep 18, 2017 at 1:52 PM, Akshay Joshi wrote: > Hi > > Attached is the patch file to fix RM 2691 View data option is missing from > pgAdmin4 2.0 version. Apart from the RM this patch includes following fixes: > > 1) Fixed issue in foreign_table where variable is not decla

pgAdmin 4 commit: Fix for Exception when the server is restarted. Fixes

Fix for Exception when the server is restarted. Fixes #2713 This issue was caused because we recently added session_write_delay in session. So session won't be written/updated to disk from memory until specified seconds are elapsed. However we must forcefully write/update session to disk if user

Re: Fix for Exception when the server is restarted [RM2713][pgAdmin4]

Thanks, applied. On Mon, Sep 18, 2017 at 2:12 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > This issue was caused because we recently added session_write_delay in > session. > So session won't be written/updated to disk from memory until specified > seconds are elapsed. >

Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

Hi On Mon, Sep 18, 2017 at 2:20 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please disregard my previous patch and instead attaching updated patch. > > In my previous patch I used `let` keyword instead of `var` for defining > variable, for consistency & backw

Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

Hi Dave, Sorry my bad, I didn't check the backend code, I assumed that it is coming from psycopg2 and so I was focusing it to remove from client side :( PFA updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Sep 18,

Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

Hi On Mon, Sep 18, 2017 at 3:08 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Sorry my bad, I didn't check the backend code, I assumed that it is coming > from psycopg2 and so I was focusing it to remove from client side :( > > PFA updated patch. > I think it

pgAdmin 4 commit: Bump version for RC2 release.

Bump version for RC2 release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5ae681f2baffdef551c9a0c4359657066c7c8743 Modified Files -- web/config.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgAdmin 4 commit: Remove unused import that was causing a hard error on

Remove unused import that was causing a hard error on Windows Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=62d7a1044e58fd2f5a65ac41c70bd0cd8df55464 Modified Files -- web/pgadmin/static/jsx/react_shapes.jsx | 1 - 1 file changed,

v2.0 RC2 test builds

I've put v2.0-rc2 test builds at https://developer.pgadmin.org/~dpage/2.0-rc2/ for anyone who needs them. Please report any show-stopper issues ASAP! Devrim; these includes the WSGI fix needed for the problem I ran into when testing the RPMs in web mode. Thanks. -- Dave Page Blog: http://pgsnak

pgAdmin 4 commit: Bump version for RC2 release.

Bump version for RC2 release. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=af3b11533fa5dd82ae16ae58721bef8bff873f9a Author: Dave Page Modified Files -- web/config.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

pgAdmin 4 commit: Remove unused import that was causing a hard error on

Remove unused import that was causing a hard error on Windows Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c4855abd4ff586c4136ed750f2249a45011fa585 Author: Dave Page Modified Files -- web/pgadmin/tools/sqleditor/static/j

pgAdmin 4 commit: Fix disable trigger menu option. Fixes #2707

Fix disable trigger menu option. Fixes #2707 Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c6c9ae9853ce53c5cbb147f7c319378f3891977d Author: Murtuza Zabuawala Modified Files -- .../schemas/tables/triggers/static/js/trigger

pgAdmin 4 commit: Correct alignment of the X button on dismissable aler

Correct alignment of the X button on dismissable alerts. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=64be708b8d281216194d1cf0869953d1ded0eb44 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/css/bootstrap.

pgAdmin 4 commit: Fix View Data option and column config for Foreign Ta

Fix View Data option and column config for Foreign Tables. Fixes #2691 Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c9897d46debb22061a2044954852da9fa8e5eb2e Author: Akshay Joshi Modified Files -- .../databases/schemas/fo

pgAdmin 4 commit: Fix user manager role handling. Fixes #2641

Fix user manager role handling. Fixes #2641 Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6fbaaf3d06ec3a8d4fc83fd7691f02aac8e9d78d Author: Harshal Dhumal Modified Files -- .../user_management/static/js/user_management.js

pgAdmin 4 commit: Fix for Exception when the server is restarted. Fixes

Fix for Exception when the server is restarted. Fixes #2713 This issue was caused because we recently added session_write_delay in session. So session won't be written/updated to disk from memory until specified seconds are elapsed. However we must forcefully write/update session to disk if user

pgAdmin 4 commit: Support Flask-Security 3.0

Support Flask-Security 3.0 Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4853f25c1433196c3c99925429754083c17941ed Author: Harshal Dhumal Modified Files -- web/pgadmin/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 d

pgAdmin 4 commit: Fix tablespace move prompt message. Fixes #2708

Fix tablespace move prompt message. Fixes #2708 Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=28f97f957f0062245cb462d0c042217d34ddb734 Author: Murtuza Zabuawala Modified Files -- .../browser/server_groups/servers/tablespa

pgAdmin 4 commit: Fix error message regexp in the query tool that could

Fix error message regexp in the query tool that could fail in some cases. Fixes #2700 Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5cc068f2bf6d0cf5f5aec1a18f8eed6b44145ea7 Author: Murtuza Zabuawala Modified Files -- ...

Re: v2.0 RC2 test builds

Hi Dave, On Mon, 2017-09-18 at 17:12 +0100, Dave Page wrote: > Devrim; these includes the WSGI fix needed for the problem I ran into when > testing the RPMs in web mode. Built and pushed packages to testing repo, will test tomorrow morning. Regards, -- Devrim Gündüz EnterpriseDB: https://www.e

Re: v2.0 RC2 test builds

No show-stoppers to report. Just to say that it looks great and loads fast. Nice work! Only stylistic item is that the column names in the result grid used to be bold but are now the same weight as the data type. Anthony On September 18, 2017 at 12:13:03 PM, Dave Page (dp...@pgadmin.org) wrote:

Re: v2.0 RC2 test builds

Hi Today I downloaded the pgAdmin4 build(pgadmin4-2.0-rc2.dmg ) for Mac but it is failed to open. When I double click on pgAdmin4 icon to open pgAdmin4, I got an error, please refer the screenshot attached. *OS details:* Mac OS X

Re: v2.0 RC2 test builds

Hi Surinder, I tested pgAdmin4 Build on MAC 10.10 and i don't see any issue related to this. Steps: 1. Downloaded MAC OS Build on 10.12 Firefox Browser and then scp on MAC 10.10 fresh VM. Note: pgAdmin4 will not work on MAC 10.9 and we have already dropped this support. Can you please share the

pgAdmin 4 commit: Filtered Rows dialog not opened from the context menu

Filtered Rows dialog not opened from the context menu. Fixes #2699 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe757c384bac26ca97e7a6c5d735d0b787ad0796 Modified Files -- web/pgadmin/tools/datagrid/static/js/datagrid.js | 7