Re: pgAdmin4: Cleanup in role dependency test cases

2017-08-30 Thread Dave Page
Hi On Wed, Aug 30, 2017 at 6:34 AM, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave, > > Role dependency test cases are failing due to database error *'ERROR: > cache lookup failed for database XX'. *Test-suite throwing error on* > "DROP ROLE ".* > This is intermittent issu

Re: [pgAdmin4][Patch]: Allow user to provide custom SSL certificates and provide .pgpass file

2017-08-30 Thread Dave Page
Hi On Wed, Aug 30, 2017 at 6:49 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch with new screenshots and docs accordingly. > > RM > ​#​ > 2649 > ​ & RM#​ > 2650 > > On Tue, Aug 29, 2017 at 7:51 PM, Dave Page wrote: > >> Hi >> >> On Fri, Aug 25,

pgAdmin 4 commit: Rename the debugger XSS test function to 'a_test_func

2017-08-30 Thread Dave Page
Rename the debugger XSS test function to 'a_test_function' to ensure it appears near the top of the tree and not off-screen. This should not be a permanent fix (the test should be able to scroll the treeview), but works for now to stop tests failing. Branch -- master Details --- https:

pgAdmin 4 commit: GPDB compatibility fixes:

2017-08-30 Thread Dave Page
GPDB compatibility fixes: When connected to a Greenplum database server - Hide items that not work with GPDB, such as Triggers, FDW, FTS_*, etc - Tables/Views/Catalogs/Language node can expand correctly - Views/Languages/Catalogs can show properties dialog with correct information - Show a greenpl

Re: [pgAdmin4][Patch] ACI tree compatible with Greenplum

2017-08-30 Thread Dave Page
Thanks, I've applied the patch, but have only eyeball-reviewed and tested for negative effects on PG servers (of which there seem to be none). Please ensure everything looks good against GPDB as I'm unable to test that at present. On Wed, Aug 30, 2017 at 7:31 AM, Teng Zhang wrote: > Hi Hackers,

[pgAdmin4][Patch]: Fix internal server error on Trigger module

2017-08-30 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where it was throwing internal server error on SQL panel when trigger is of update event type. I have updated sample code to re-produce the issue on RM. RM#2668 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL

Fix for RM2670

2017-08-30 Thread Harshal Dhumal
Hi, Please find minor patch to improve datamodel validations for default Validator if user (developer) do not implement validate function in datamodel. Without this default validation error messages were suppressing if no validation function was provided. -- *Harshal Dhumal* *Sr. Software Engin

fix get_types for GPDB

2017-08-30 Thread Dave Cramer
This patch allows create column to see available types in the dropdown Dave Cramer diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py index 11d40dd..ef08d48 100644 --- a/web/pgad

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-30 Thread Robert Eckhardt
How does this reflect actual user workflow? I have never quite understood how a user was supposed to navigate through this, it seems like the expectation is to continually click until they see the thing they want rather than just going through as though it were a wizard. Is this something that coul

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-30 Thread Shirley Wang
+1 to Rob. By the time a user drills into seeing column properties, she'll have gone through 5 layers of navigation. Is there another way to display this information so that it's not nested? If this is a visual design revamp that's a different conversation. What kind of feedback are you looking fo

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-30 Thread Dave Page
It's a visual design update. As for the actual dialogue; a wizard really isn't appropriate as the typical workflow will be very inconsistent and often non-linear. I have no idea how to improve it further, except through improving the visuals to make it clearer. It's 100x easier to use than the pgA

[pgAdmin4][Patch]: RM_2637 - Copy functionality in Query Tool doesn't work after copying from Data Output

2017-08-30 Thread Surinder Kumar
Hi While working on webpacking pgAdmin4, I had removed `document.removeEventListener(...)` temporarily as it was not working in `strict` mode, giving type error and I forgot to include its fix, because of this copy/paste functionality didn't work properly which is now taken care in this patch. P