[pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X

2017-07-28 Thread Surinder Kumar
Hi, I inspect the react code and in call stacks, found `process.env.NODE_ENV` is undefined due to which 'SyntheticEvent.call' is not callable. So, to fix this, i add 'definePlugin' to plugins for `dev` environment in `webpack.config.js`. Initially it was added only for `production` environment. b

Re: Discussion on improving alertify notifications logic

2017-07-28 Thread Dave Page
On Thu, Jul 27, 2017 at 2:41 PM, Akshay Joshi wrote: > Hi All > > As in commit "Update alertify alerts to use the styling defined in > the style guide": > > https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdiff;h= > 2a30a86e7d5e562040500f448fbb0d143ff2cff9 > > https://git.postgresql.org/

Re: [pgAdmin4][Patch]: Fixed RM #2603 - Import/Export File issues

2017-07-28 Thread Dave Page
Ashesh, can you deal with this please? Thanks. On Thu, Jul 27, 2017 at 5:08 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM #2603: Import/Export File > issues. > > Fixed Issues: > 1. Couldn't click on the File Control once gets

Re: [pgAdmin4][Patch]: Dashboard requests don't stop even after closing the panel

2017-07-28 Thread Dave Page
Ashesh, can you deal with this please? Thanks. On Thu, Jul 27, 2017 at 6:20 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > If we close the Dashboard tab even then the requests don't stop. This is > the regression of web-packing of browser.js file. > Please find the attache

Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X

2017-07-28 Thread Dave Page
Ashesh, can you deal with this please? Thanks. On Fri, Jul 28, 2017 at 8:12 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > I inspect the react code and in call stacks, found `process.env.NODE_ENV` > is undefined due to which 'SyntheticEvent.call' is not callable. > > So, t

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-28 Thread Murtuza Zabuawala
Hi Dave, PFA patch to display additional information from pg_stat_activity table using subnode control. RM#2597 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jul 25, 2017 at 10:56 AM, Shirley Wang wrote: > >> O

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-28 Thread Murtuza Zabuawala
++ Attaching the patch -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jul 28, 2017 at 4:02 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA patch to display additional information from pg_stat

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-28 Thread Dave Page
Hi I took a quick look at this and have a couple of thoughts: - Instead of the "edit" icon to open the subnode, we should use something more appropriate - a "properties" icon perhaps. - There seems to be a lot of different shades of grey on there (maybe a subnode design in general that just show

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-28 Thread Murtuza Zabuawala
Hi Dave, On Fri, Jul 28, 2017 at 4:11 PM, Dave Page wrote: > Hi > > I took a quick look at this and have a couple of thoughts: > > - Instead of the "edit" icon to open the subnode, we should use something > more appropriate - a "properties" icon perhaps. > > I used default subnode's edit icon fo

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-28 Thread Dave Page
On Fri, Jul 28, 2017 at 12:24 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Fri, Jul 28, 2017 at 4:11 PM, Dave Page wrote: > >> Hi >> >> I took a quick look at this and have a couple of thoughts: >> >> - Instead of the "edit" icon to open the subnode, we sho

Re: Error using pgadmin4 HEAD

2017-07-28 Thread Dave Cramer
Hi Kushboo, Thanks for the quick reply. I compiled it from HEAD. I will follow the instructions for deployment and get back to you . Dave Dave Cramer On 27 July 2017 at 21:59, Khushboo Vashi wrote: > Hi Dave, > > Please provide below information to investigate: > > 1. OS Details > 2. pgAdmin

Re: Error using pgadmin4 HEAD

2017-07-28 Thread Dave Cramer
OK, I am running macos 10.12.6 compiled from source using QT5.5clang using current HEAD version followed the instructions config_local has SERVER_MODE = False python setup.py does not error from the runtime dir executed 'open pgadmin4.app' The error message is the same "The application server co

Re: Error using pgadmin4 HEAD

2017-07-28 Thread Murtuza Zabuawala
Hi, With pgAdmin4 version 1.6, we have changed the way we bundle and serve the javascript and other static files. Refer steps in this email thread , if you want to use it from git repository,