[pgAdmin4][Patch]: Stop Flask from initialising service twice in Debug mode

Hi When pgAdmin4 runs in DEBUG mode, Flask initialise service twice, while in non-DEBUG mode, once. It is pain while development because `yarn run bundle` also runs twice. It is because the parameter `use_reloader` = True in Debug Mode. If `os.environ` variable `WERKZEUG_RUN_MAIN` is set to None

Re: [pgAdmin4][Patch]: Stop Flask from initialising service twice in Debug mode

Hi In this patch, i have added reference to the implementation. Please find updated patch and review. Thanks, Surinder On Fri, Jul 21, 2017 at 12:32 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > When pgAdmin4 runs in DEBUG mode, Flask initialise service twice, while in >

[pgAdmin4][Patch]: Using editorconfig to maintain consistent coding styles between different IDE's

Hi All, In pgAdmin4 codebase, the coding styles at many places is inconsistent, in some files standard coding conventions are followed and in some not. It is difficult to take care of 'tabs', 'spaces', 'trailing white-spaces', 'max_line_length' while development. So adding .editorconfig to pgAdm

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi Dave, Please find updated patch. On Thu, Jul 20, 2017 at 10:35 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > > On Thu, Jul 20, 2017 at 10:29 PM, Dave Page wrote: > >> Hi >> >> On Thu, Jul 20, 2017 at 3:33 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> w

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

Hi, Currently if user clicks on empty white area below history entry then arrow navigation does not work. Attached patch fixes this issue. [image: Inline image 1] -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company O

pgAdmin 4 commit: Add an editorconfig file to help maintain coding stan

Add an editorconfig file to help maintain coding standards. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ede6765f6b2688719349f5d369123acd6c25dcd9 Author: Surinder Kumar Modified Files -- web/.editorconfig | 30 +

Re: [pgAdmin4][Patch]: Using editorconfig to maintain consistent coding styles between different IDE's

Thanks, applied. On Fri, Jul 21, 2017 at 8:43 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi All, > > In pgAdmin4 codebase, the coding styles at many places is inconsistent, in > some files standard coding conventions are followed and in some not. > > It is difficult to take ca

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi Robert, Just to make shortcut keys uniform across all the platforms. On Fri, Jul 21, 2017 at 1:25 AM, Robert Eckhardt wrote: > Murtuza, > > Is there a particular reason you choose the keyboard shortcuts that you > choose. When we were looking at this earlier to see what was being used > else

pgAdmin 4 commit: Prevent the Werkzeug reloader from causing a "double

Prevent the Werkzeug reloader from causing a "double start" at init time. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a49a3103e298fcc4373856abe057dac09bc1df14 Author: Surinder Kumar Modified Files -- web/pgAdmin4.py | 10 +

Re: [pgAdmin4][Patch]: Stop Flask from initialising service twice in Debug mode

Thanks, applied. The reloader has always been a little temperamental for me, so I couldn't prove this doesn't break it. If someone finds it does, please yelp. On Fri, Jul 21, 2017 at 8:27 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > In this patch, i have added reference t

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

Hi On Fri, Jul 21, 2017 at 9:38 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Currently if user clicks on empty white area below history entry then > arrow navigation does not work. > Attached patch fixes this issue. > This fixes that problem, but stops it working if I *

Build failed in Jenkins: pgadmin4-master-python27 #258

See Changes: [Dave Page] Add an editorconfig file to help maintain coding standards. [Dave Page] Prevent the Werkzeug reloader from causing a "double start" at init

[pgAdmin4][Patch]: To fix database disconnect option

Hi, PFA minor patch to fix the issue where database disconnect option is not working. *Steps to re-produce:* 1) Create a "test" database 2) Connect to "test" database 3) Right click on "test" database and try to disconnect it, you will get an error on console. -- Regards, Murtuza Zabuawala Enter

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Thanks, applied. On Fri, Jul 21, 2017 at 8:50 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch. > > On Thu, Jul 20, 2017 at 10:35 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> >> On Thu, Jul 20, 2017 at 10:29 PM, Dave Page wrote:

pgAdmin 4 commit: Fix regression tests after Dave broke them.

Fix regression tests after Dave broke them. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b313cbce0d37c741f12762b1d1e24a68a926d4fa Author: Murtuza Zabuawala Modified Files -- .../feature_tests/pg_datatype_validation_test.py |

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

Hi, On Fri, Jul 21, 2017 at 2:24 PM, Dave Page wrote: > Hi > > On Fri, Jul 21, 2017 at 9:38 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Currently if user clicks on empty white area below history entry then >> arrow navigation does not work. >> Attached patch fix

pgAdmin 4 commit: Fix disconnection of new databases. Fixes #2594

Fix disconnection of new databases. Fixes #2594 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=acaa79cf6b7363297ee8344ea1c758c60ccb44f7 Author: Murtuza Zabuawala Modified Files -- .../server_groups/servers/databases/static/js/dat

Re: [pgAdmin4][Patch]: To fix database disconnect option

Thanks, applied. On Fri, Jul 21, 2017 at 10:08 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the issue where database disconnect option is not > working. > > *Steps to re-produce:* > 1) Create a "test" database > 2) Connect to "test" database

Re: [pgAdmin4][Patch]: To fix database disconnect option

Hi As discussed the disconnect option is not working due to javascript error: "obj is undefined" and which is after web packing. so in some files global variables needs to convert into local var. We need to run eslint on each file to find out such issues and fix all at once. So i am writing a new

Jenkins build is back to normal : pgadmin4-master-python27 #259

See

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

On Fri, Jul 21, 2017 at 11:05 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > On Fri, Jul 21, 2017 at 2:24 PM, Dave Page wrote: > >> Hi >> >> On Fri, Jul 21, 2017 at 9:38 AM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Currently if user cl

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

I'm not sure what you mean by across platforms. Do you mean that those are the keyboard shortcuts in pgAdmin 3? Rob On Jul 21, 2017 4:42 AM, "Murtuza Zabuawala" < murtuza.zabuaw...@enterprisedb.com> wrote: Hi Robert, Just to make shortcut keys uniform across all the platforms. On Fri, Jul 21,

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi Robert, I mean rather than using cmd key for Mac and CTRL key for Windows/Linux, I used "CTRL" key for all the platforms. And regarding choosing comma & period keys, they all are near each to each other so user can remember them easily. Let me know If my thinking was wrong for shortcut keys, I

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

On Jul 21, 2017 4:23 PM, "Dave Page" wrote: On Fri, Jul 21, 2017 at 11:05 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > On Fri, Jul 21, 2017 at 2:24 PM, Dave Page wrote: > >> Hi >> >> On Fri, Jul 21, 2017 at 9:38 AM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com

pgAdmin 4 commit: Add a field to the Server Dialogue allowing users to

Add a field to the Server Dialogue allowing users to specify a subset of databases they'd like to see in the treeview. Fixes #1918 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=70418144cfcc32036167ab10713653e98d221514 Author: Atul Sharma M

Re: [pgAdmin4][Patch][RM_1918] : Implement the DB restriction field from pgAdmin III

Thanks, patch applied! A couple of tips for the future: - Please ensure screenshots are of a comparable size to the ones around them or that they replace. We sometimes see extra-large screenshots where they've been taken on hi-res screens, often in an VM. - Please be more generous with spaces, e

Build failed in Jenkins: pgadmin4-master-python34 #249

See Changes: [Dave Page] Add a field to the Server Dialogue allowing users to specify a subset of -- [...truncated 336.11 KB...]

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

On Fri, Jul 21, 2017 at 12:34 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > > > On Jul 21, 2017 4:23 PM, "Dave Page" wrote: > > > > On Fri, Jul 21, 2017 at 11:05 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> On Fri, Jul 21, 2017 at 2:24 PM, Dave Pa

pgAdmin 4 commit: Ensure arrow keys work correctly when the pane is foc

Ensure arrow keys work correctly when the pane is focused instead of the tab in the query tool history. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7182b5997627405449bdd0fed65aeb6de19c0a4f Author: Harshal Dhumal Modified Files --

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

And... applied. Thanks. On Fri, Jul 21, 2017 at 1:28 PM, Dave Page wrote: > > > On Fri, Jul 21, 2017 at 12:34 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> >> >> On Jul 21, 2017 4:23 PM, "Dave Page" wrote: >> >> >> >> On Fri, Jul 21, 2017 at 11:05 AM, Harshal Dhumal < >> h

[pgAdmin4][patch][RM#2593]: Query Tool/ Debugger won't load with Qt-5.1 with webkit

Hi When an instance of query tool and debugger is opened, it fails to load and gives following error in console: `Promise is undefined.` The reason is: These instances are loaded in an iframe and their bundles don't include `babel-polyfill` library. Babel-polyfill must be loaded first. Please fi

Build failed in Jenkins: pgadmin4-master-python27-feature #9

See Changes: [Dave Page] Add controls and shortcuts for commenting/uncommenting code in the SQL [Dave Page] Fix typo in filename. [Dave Page] Webpacking cleanups [Dave Page] Fix regressions int

Jenkins build is back to normal : pgadmin4-master-python34 #250

See

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi! We looked at the patch and realized that the function to check if an element is not clickable because it's out of view was using an incorrect assertion. We changed it and created a small patch. We also realized that on the current master the yarn.lock is causing changes when running the app. I

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

I wouldn't say wrong, it just wasn't what I was expecting. I guess I'd like to hear what others are expecting. If I had my way we would use Ctrl+/ single line comment and uncomment (prepend with --) Ctrl+Shift+/ block comment and uncomment (bracket with /* and */) where Ctrl == command on

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

On Fri, Jul 21, 2017 at 4:08 PM, Robert Eckhardt wrote: > I wouldn't say wrong, it just wasn't what I was expecting. > > I guess I'd like to hear what others are expecting. If I had my way we > would use > > Ctrl+/ single line comment and uncomment (prepend with --) > Ctrl+Shift+/ block com

Re: [pgAdmin4][patch][RM#2593]: Query Tool/ Debugger won't load with Qt-5.1 with webkit

Thanks, applied. On Fri, Jul 21, 2017 at 2:06 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > When an instance of query tool and debugger is opened, it fails to load > and gives following error in console: > `Promise is undefined.` > > The reason is: These instances are load

pgAdmin 4 commit: Ensure babel-polyfill is loaded in older qWebKits. Fi

Ensure babel-polyfill is loaded in older qWebKits. Fixes #2593 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=03657df82ae1149ab92c6bfdad9f51d11f1feb7c Author: Surinder Kumar Modified Files -- web/pgadmin/tools/debugger/templates/

pgAdmin 4 commit: Fix test assertion.

Fix test assertion. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ebb40819534d79376a577a149a8a5db124b Author: Sarah McAlear Modified Files -- web/pgadmin/feature_tests/query_tool_journey_test.py | 2 +- 1 file changed, 1 ins

pgAdmin 4 commit: Update yarn.lock

Update yarn.lock Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=eb5bb5fcc0f83bbd6be455ea3491fab3d26d770c Modified Files -- web/yarn.lock | 449 -- 1 file changed, 439 insertio

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Thanks, patch applied and yarn.lock updated. On Fri, Jul 21, 2017 at 3:52 PM, Sarah McAlear wrote: > Hi! > > We looked at the patch and realized that the function to check if an > element is not clickable because it's out of view was using an incorrect > assertion. We changed it and created a sm

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

I hope you're overthinking. Having not implemented it yet I'm not sure. Block commenting will look like the below /* CREATE TABLE foo ( id serial, data text ); -- Index required on data for finding Wumpus' quickly CREATE INDEX foo_idx ON foo (data); */ -- Rob On Fri, Jul 21, 2017 at 11:13

Build failed in Jenkins: pgadmin4-master-python26 #380

See Changes: [Dave Page] Ensure babel-polyfill is loaded in older qWebKits. Fixes #2593 [Dave Page] Fix test assertion. -- [...truncated 339.62 KB...]

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

On Fri, Jul 21, 2017 at 4:21 PM, Robert Eckhardt wrote: > I hope you're overthinking. Having not implemented it yet I'm not sure. > > Block commenting will look like the below > > /* > CREATE TABLE foo ( > id serial, > data text > ); > > -- Index required on data for finding Wumpus' quickly >

Build failed in Jenkins: pgadmin4-master-python36 #256

See Changes: [Dave Page] Ensure babel-polyfill is loaded in older qWebKits. Fixes #2593 [Dave Page] Fix test assertion. [Dave Page] Update yarn.lock -- [...trun

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

I understand now. If any one line is different then the entire thing will be commented so in your example: --CREATE TABLE foo ( -- id serial, -- data text --); ---- Index required on data for finding Wumpus' quickly . (not sure if there should be spaces or not) --CREATE INDEX foo_idx ON fo

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

On Fri, Jul 21, 2017 at 4:43 PM, Robert Eckhardt wrote: > I understand now. > > If any one line is different then the entire thing will be commented so in > your example: > > --CREATE TABLE foo ( > -- id serial, > -- data text > --); > > ---- Index required on data for finding Wumpus' quick

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

> > Right - we lose the ability to uncomment multiple levels though, which may > also be useful. > Well yes. I would argue that simplicity trumps potential use. I'd also argue that attempting to maintain consistency across environments (IDEs, etc. ) is advantageous. This was the philosophy we wer

Jenkins build is back to normal : pgadmin4-master-python26 #381

See

Re: [pgAdmin4][Patch]: Stop Flask from initialising service twice in Debug mode

Surinder, you are my hero! 🎁 On Fri, Jul 21, 2017 at 4:47 AM, Dave Page wrote: > Thanks, applied. The reloader has always been a little temperamental for > me, so I couldn't prove this doesn't break it. If someone finds it does, > please yelp. > > On Fri, Jul 21, 2017 at 8:27 AM, Surinder Kumar

Re: [pgAdmin4][Patch] Font sizes to 13 px and not bolded

Oh whoa I didn't realize they became all wonky. It also looks like headers in the statistics table is still bold, so perhaps there's something missing in our patch. We'll take a look. On Thu, Jul 20, 2017 at 4:01 PM Dave Page wrote: > Hi > > On Thu, Jul 20, 2017 at 7:55 PM, Shirley Wang wrote:

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Until we learn definitively from users that the current implementation of commenting/uncommenting in other tools is not working, we should use what is common practice. We can use that as a baseline and then if we learn that there needs to be another shortcut, we can add additional functionality. It

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

On Fri, Jul 21, 2017 at 8:57 PM, Shirley Wang wrote: > Until we learn definitively from users that the current implementation of > commenting/uncommenting in other tools is not working, we should use what > is common practice. We can use that as a baseline and then if we learn that > there needs

[pgadmin-hackers][patch]

Hi hackers, With the last commits, the behavior of focusing on a selected entry when entering the History Tab was not working as expected. This patch will bring this behavior back. Thanks Joao & Matt focus-on-entry-when-enter-history.diff Description: Binary data

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

I'd say we should go with Cmd+/ and Cmd+Shift+/ as that seems the most common by a small margin - however, I'm still not convinced that we don't need two keys for optimal behaviour of line commenting. To be clear, I'm not 100% convinced either. I am, however, convinced that it is the right first