On Tue, Mar 30, 2021 at 1:45 PM Ashesh Vashi
wrote:
> On Fri, Feb 26, 2021 at 12:06 PM Neel Patel
> wrote:
>
>> Hi Dave/Ashesh,
>>
>> Do you have any further comments ?
>>
> Apologies for late response. Committed the patch.
>
> Dave,
>
> I've also updated the pgAgent's patch version (new version
On Fri, Feb 26, 2021 at 12:06 PM Neel Patel
wrote:
> Hi Dave/Ashesh,
>
> Do you have any further comments ?
>
Apologies for late response. Committed the patch.
Dave,
I've also updated the pgAgent's patch version (new version: 4.2.1), and
copyright information.
-- Thanks, Ashesh
>
> Thanks,
>
On Fri, Feb 26, 2021 at 6:36 AM Neel Patel
wrote:
> Hi Dave/Ashesh,
>
> Do you have any further comments ?
>
Thanks Sergey, Neel. I have no further comments.
>
> Thanks,
> Neel Patel
>
> On Wed, Feb 24, 2021 at 8:14 PM Sergey Burladyan
> wrote:
>
>> Neel Patel writes:
>>
>> > Thanks for the
Hi Dave/Ashesh,
Do you have any further comments ?
Thanks,
Neel Patel
On Wed, Feb 24, 2021 at 8:14 PM Sergey Burladyan
wrote:
> Neel Patel writes:
>
> > Thanks for the review. Please find the attached updated patch.
> > Do review it and let me know in case of any comments.
>
> Looks good, tha
Neel Patel writes:
> Thanks for the review. Please find the attached updated patch.
> Do review it and let me know in case of any comments.
Looks good, thanks!
--
Sergey Burladyan
Hi Sergey,
Thanks for the review. Please find the attached updated patch.
Do review it and let me know in case of any comments.
Thanks,
Neel Patel
On Wed, Feb 24, 2021 at 5:12 PM Sergey Burladyan
wrote:
> Sergey Burladyan writes:
>
> > Maybe it should look something like this:
> > +wc
Sergey Burladyan writes:
> Maybe it should look something like this:
> +wcstombs_s(&charsConverted, mbs, mb_len + 1, wchar_str, mb_len);
Ah, and we missed check for error.
Something like this, maybe:
+#ifdef __WIN32__
+size_t charsConverted = 0;
+if (wcstombs_s(&charsCon
Neel Patel writes:
> Do you have any comments for this updated patch ? Let us know ASAP so that
> we can commit it.
Sorry about the delay.
It looks better than my patch, thanks!
There is only two comments, about wcstombs_s and about setlocale.
About win32 wcstombs_s:
+wcstombs_s(&char
Hi Sergey,
Do you have any comments for this updated patch ? Let us know ASAP so that
we can commit it.
Thanks,
Neel Patel
On Thu, Feb 18, 2021 at 5:12 PM Neel Patel
wrote:
> Hi Sergey,
>
> Thank you for the patch. It looks good to me except below.
>
> We have modified the patch as we fixed th
Hi Sergey,
Thank you for the patch. It looks good to me except below.
We have modified the patch as we fixed the memory leak ( review comment
given by Ashesh ) and also fixed the compilation warnings.
Can you please review and let us know ?
Thanks,
Neel Patel
On Mon, Feb 15, 2021 at 6:15 PM Nee
Thanks Sergey for the patch.
Sure Dave.
There is some compilation warning in linux, I will fix those and test
pgAgent in windows and update the thread.
On Mon, Feb 8, 2021 at 2:55 PM Dave Page wrote:
> Hi
>
> On Sat, Feb 6, 2021 at 5:00 AM Sergey Burladyan
> wrote:
>
>> Currently pgagent doesn
Hi
On Sat, Feb 6, 2021 at 5:00 AM Sergey Burladyan wrote:
> Currently pgagent doesn't handle unicode correctly.
>
> CharToWString function corrupt multibyte characters because it processes
> string one byte at a time:
> 148 std::string s = std::string(cstr);
> 149 std::wstring
Currently pgagent doesn't handle unicode correctly.
CharToWString function corrupt multibyte characters because it processes
string one byte at a time:
148 std::string s = std::string(cstr);
149 std::wstring wsTmp(s.begin(), s.end());
WStringToChar function does not take into ac
13 matches
Mail list logo
