Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the

2019-12-06 Thread Akshay Joshi
Thanks, patch applied. On Tue, Dec 3, 2019 at 3:38 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to change toolbar icon for opening query tool inline > with execute button change. > Icon for table filter button on the toolbar is also chang

Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the

2019-12-05 Thread Dave Page
Yes, go ahead. On Wed, Dec 4, 2019 at 11:24 PM Akshay Joshi wrote: > Dave, > > Any update on this? Should I commit the patch? > > On Wed, 4 Dec, 2019, 11:57 Akshay Joshi, > wrote: > >> Hi Dave, >> >> Should I commit this patch, are you happy with the new icons? >> >> On Tue, Dec 3, 2019 at 4:13

Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the

2019-12-04 Thread Akshay Joshi
Dave, Any update on this? Should I commit the patch? On Wed, 4 Dec, 2019, 11:57 Akshay Joshi, wrote: > Hi Dave, > > Should I commit this patch, are you happy with the new icons? > > On Tue, Dec 3, 2019 at 4:13 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Dave, >> >>

Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the

2019-12-03 Thread Akshay Joshi
Hi Dave, Should I commit this patch, are you happy with the new icons? On Tue, Dec 3, 2019 at 4:13 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > I've sent a patch for the new icon. It is not a play icon but thoughts on > the sent patch ? Below is the icon: > [ima

Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the

2019-12-03 Thread Aditya Toshniwal
Hi Dave, I've sent a patch for the new icon. It is not a play icon but thoughts on the sent patch ? Below is the icon: [image: toolbar.png] On Tue, Dec 3, 2019 at 4:09 PM Dave Page wrote: > I intentionally didn't change that one as I wasn't sure what icon would be > better. I'm far from convinc

Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the

2019-12-03 Thread Dave Page
I intentionally didn't change that one as I wasn't sure what icon would be better. I'm far from convinced that it should also be a play icon. On Tue, Dec 3, 2019 at 5:08 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to change toolbar icon

pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the

2019-12-02 Thread Dave Page
Use a 'play' icon for the Execute Query button in the Query Tool for greater consistency with other applications. Fixes #4711 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ac2bd5e6ee7c41d5fc2f4ee0036042ac79ff9320 Modified Files