Re: pgAdmin 4 commit: Port preferences dialog to React. Fixes #7149

2022-03-21 Thread Aditya Toshniwal
Hi Nikhil, You have called a ReactDOM.render inside a React component. ReactDOM.render is used only to mount the top React component. I remember we had discussed this and I told you to change. This may lead to unpredictable behaviour. Please change it. On Mon, Mar 21, 2022 at 1:30 PM Akshay Josh

pgAdmin 4 commit: Port preferences dialog to React. Fixes #7149

2022-03-21 Thread Akshay Joshi
Port preferences dialog to React. Fixes #7149 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=74e794b4162b771f3ada4cf631bdbe0b43cab91b Author: Nikhil Mohite Modified Files -- docs/en_US/images/preferences_browser_display.png | Bi