Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2019-01-16 Thread Akshay Joshi
Thanks patch applied. On Thu, Jan 17, 2019 at 11:59 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the small patch (and probably the final for this mail chain) > to accommodate the changes suggested in previous mail. > > Kindly review. > > On Wed, Ja

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2019-01-16 Thread Aditya Toshniwal
Hi Hackers, Attached is the small patch (and probably the final for this mail chain) to accommodate the changes suggested in previous mail. Kindly review. On Wed, Jan 16, 2019 at 8:30 PM Dave Page wrote: > > > On Wed, Jan 16, 2019 at 6:29 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrot

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2019-01-16 Thread Dave Page
On Wed, Jan 16, 2019 at 6:29 AM Akshay Joshi wrote: > Thanks patch applied without Tree Changes. > > On Mon, Jan 14, 2019 at 10:55 AM Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch for further design improvements: >> - Process watcher made fixed width with

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2019-01-15 Thread Akshay Joshi
Thanks patch applied without Tree Changes. On Mon, Jan 14, 2019 at 10:55 AM Aditya Toshniwal wrote: > Hi Hackers, > > Attached is the patch for further design improvements: > - Process watcher made fixed width with header changes, time details > rounded to 2 decimals > - Query history will show

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2019-01-15 Thread Aditya Toshniwal
Hi Hackers, Please find the updated, rebased patch. Kindly review. On Mon, Jan 14, 2019 at 10:54 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch for further design improvements: > - Process watcher made fixed width with header changes, time

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2019-01-13 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch for further design improvements: - Process watcher made fixed width with header changes, time details rounded to 2 decimals - Query history will show "No query history" if no query fired. Query editor default size increased. - Tree improvements - right bold border

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2019-01-07 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch for few more changes: - New Folder button was not working in file dialogue. Fixed that. - Color, icon changes in file dialogue - Also replaced the splash screen image (which is used on main dashboard also). It works fine on dashboard. However, I'm not sure of the

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2019-01-07 Thread Dave Page
Thanks - applied! On Mon, Jan 7, 2019 at 10:44 AM Aditya Toshniwal wrote: > > Hi Hackers, > > Attached is the patch to incorporate the changes discussed in trailing > mail(s). > > Kindly review. > > On Fri, Jan 4, 2019 at 3:31 PM Dave Page wrote: >> >> On Fri, Jan 4, 2019 at 9:58 AM Aditya Tosh

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2019-01-06 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to incorporate the changes discussed in trailing mail(s). Kindly review. On Fri, Jan 4, 2019 at 3:31 PM Dave Page wrote: > On Fri, Jan 4, 2019 at 9:58 AM Aditya Toshniwal > wrote: > > > > Hi, > > > > On Fri, Jan 4, 2019 at 2:53 PM Dave Page wrote: > >> > >>

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2019-01-04 Thread Dave Page
On Fri, Jan 4, 2019 at 9:58 AM Aditya Toshniwal wrote: > > Hi, > > On Fri, Jan 4, 2019 at 2:53 PM Dave Page wrote: >> >> Hi >> >> On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal >> wrote: >>> >>> Hi Dave, >>> >>> On Thu, Jan 3, 2019 at 8:39 PM Dave Page wrote: A few other things

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2019-01-04 Thread Aditya Toshniwal
Hi, On Fri, Jan 4, 2019 at 2:53 PM Dave Page wrote: > Hi > > On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Thu, Jan 3, 2019 at 8:39 PM Dave Page wrote: >> >>> >>> A few other things that I noticed (or have been bugging me):

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2019-01-04 Thread Dave Page
Hi On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Thu, Jan 3, 2019 at 8:39 PM Dave Page wrote: > >> >> A few other things that I noticed (or have been bugging me): >> >> - The menu bar seems a little cramped. Taking pg-navbar from 32

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2019-01-03 Thread Dave Page
Hi On Thu, Jan 3, 2019 at 10:20 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Further improvement patch. With this patch, following are fixed: > - Fieldset control design changes > - File dialog - files list header should not scroll with the body and > stick to

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2019-01-03 Thread Aditya Toshniwal
Hi Hackers, Further improvement patch. With this patch, following are fixed: - Fieldset control design changes - File dialog - files list header should not scroll with the body and stick to the top - Debugger input args dialog cancel button should always be enabled - Backup globals dialog controls

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2019-01-02 Thread Akshay Joshi
Thanks patch applied. On Wed, Jan 2, 2019 at 11:23 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Kindly ignore the previous patch. Attaching updated patch with few more > corrections. > The patch includes: > - Base font size changed from 0.815rem to 0.875rem, f

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2018-12-21 Thread Aditya Toshniwal
On Fri, Dec 21, 2018 at 7:46 PM Dave Page wrote: > On Fri, Dec 21, 2018 at 2:14 PM Aditya Toshniwal > wrote: > > > > For the query tool results grid text pop-out, you mean the border size > around it ? > > We don't have any design discussed for it, so could you please propose > what can be done.

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2018-12-21 Thread Dave Page
On Fri, Dec 21, 2018 at 2:14 PM Aditya Toshniwal wrote: > > For the query tool results grid text pop-out, you mean the border size around > it ? > We don't have any design discussed for it, so could you please propose what > can be done. Border, button colours etc. I can't draw anything, but I'

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2018-12-21 Thread Aditya Toshniwal
For the query tool results grid text pop-out, you mean the border size around it ? We don't have any design discussed for it, so could you please propose what can be done. On Fri, Dec 21, 2018 at 7:35 PM Dave Page wrote: > On Fri, Dec 21, 2018 at 2:02 PM Aditya Toshniwal > wrote: > > > > > > >

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2018-12-21 Thread Dave Page
On Fri, Dec 21, 2018 at 2:02 PM Aditya Toshniwal wrote: > > > > On Fri, Dec 21, 2018 at 7:29 PM Dave Page wrote: >> >> One other issue: I'm seeing that standard sized dialogues (e.g. the >> Server or Database Properties dialogues) are wrapping their labels and >> controls at the default size. Tha

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2018-12-21 Thread Aditya Toshniwal
On Fri, Dec 21, 2018 at 7:29 PM Dave Page wrote: > One other issue: I'm seeing that standard sized dialogues (e.g. the > Server or Database Properties dialogues) are wrapping their labels and > controls at the default size. That should not be the case. > Yep. Akshay has logged that in the sheet s

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2018-12-21 Thread Dave Page
And hopefully finally; it looks like the pop-out text editor on the query tool results grid hasn't been updated. On Fri, Dec 21, 2018 at 1:59 PM Dave Page wrote: > > One other issue: I'm seeing that standard sized dialogues (e.g. the > Server or Database Properties dialogues) are wrapping their l

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2018-12-21 Thread Dave Page
One other issue: I'm seeing that standard sized dialogues (e.g. the Server or Database Properties dialogues) are wrapping their labels and controls at the default size. That should not be the case. On Fri, Dec 21, 2018 at 12:46 PM Dave Page wrote: > > Hi > > On Fri, Dec 21, 2018 at 12:29 PM Adity

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2018-12-21 Thread Dave Page
Hi On Fri, Dec 21, 2018 at 12:29 PM Aditya Toshniwal wrote: > > Hi Dave, > > On Fri, Dec 21, 2018 at 5:51 PM Dave Page wrote: >> >> Nice! Thanks Ashesh. >> >> Some small issues I spotted: >> >> - The font looks somewhat small. How does it compare in size to, say, >> Gmail? I think it needs to be

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2018-12-21 Thread Aditya Toshniwal
Hi Dave, On Fri, Dec 21, 2018 at 5:51 PM Dave Page wrote: > Nice! Thanks Ashesh. > > Some small issues I spotted: > > - The font looks somewhat small. How does it compare in size to, say, > Gmail? I think it needs to be increased to at least that size. > Gmail uses 0.875rem (14px) for the left p

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2018-12-21 Thread Dave Page
Nice! Thanks Ashesh. Some small issues I spotted: - The font looks somewhat small. How does it compare in size to, say, Gmail? I think it needs to be increased to at least that size. - Dialogues have 2 close buttons next to each other in the top-right. Looks like an icon and a text version? - W

pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2018-12-21 Thread Ashesh Vashi
Improvement in the look and feel of the whole application Changed the SCSS/CSS for the below third party libraries to adopt the new look 'n' feel: - wcDocker - Alertify dialogs, and notifications - AciTree - Bootstrap Navbar - Bootstrap Tabs - Bootstrap Drop-Down menu - Backgrid - Select2 Adopate