Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn

2018-03-16 Thread Dave Page
Well config_local isn't part of the source tree, so it's easier to just ignore that. I'm happy with ignoring the migrations as well. On Friday, March 16, 2018, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello, > Personally I believe we should fix the config_local pep issues

Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn

2018-03-16 Thread Joao De Almeida Pereira
Hello, Personally I believe we should fix the config_local pep issues and just ignore the migrations. Specially because the migration file should not have a lot of python code. Thanks On Thu, Mar 15, 2018 at 3:32 PM Dave Page wrote: > On Thu, Mar 15, 2018 at 12:25 PM, Murtuza Zabuawala < > murt

Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn

2018-03-15 Thread Dave Page
On Thu, Mar 15, 2018 at 12:25 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Thu, Mar 15, 2018 at 9:42 PM, Dave Page wrote: > >> >> >> On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> On Thu, Mar 15, 20

Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn

2018-03-15 Thread Murtuza Zabuawala
Hi Dave, On Thu, Mar 15, 2018 at 9:42 PM, Dave Page wrote: > > > On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> On Thu, Mar 15, 2018 at 4:53 PM, Dave Page wrote: >> >>> Hi >>> >>> On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi < >>> ashesh.va...@enterprisedb.co

Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn

2018-03-15 Thread Dave Page
On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > On Thu, Mar 15, 2018 at 4:53 PM, Dave Page wrote: > >> Hi >> >> On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> I have just noticed, we're

Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn

2018-03-15 Thread Murtuza Zabuawala
On Thu, Mar 15, 2018 at 4:53 PM, Dave Page wrote: > Hi > > On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi, >> >> I have just noticed, we're ignoring migrations directory too. >> Should we not also check code styling for migrations directory? >> > >

Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn

2018-03-15 Thread Dave Page
Hi On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi wrote: > Hi, > > I have just noticed, we're ignoring migrations directory too. > Should we not also check code styling for migrations directory? > Yeah, I was going to ask about that :-). Is there a specific reason why we're ignoring the migratio

Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn

2018-03-15 Thread Ashesh Vashi
Hi, I have just noticed, we're ignoring migrations directory too. Should we not also check code styling for migrations directory? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi*

pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn

2018-03-15 Thread Dave Page
Ignore config_local.py and config_distro.py when running PEP-8 checks. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53ae960aeba0dde6109b91c171f22758b1b04ebe Modified Files -- web/.pycodestyle | 2 +- 1 file changed, 1 insertion(+