pgAdmin 4 commit: Fixed following SonarQube issues:

2020-08-19 Thread Akshay Joshi
Fixed following SonarQube issues: 1. String literals should not be duplicated. 2. Cognitive Complexity of functions should not be too high. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0668a52c6bbc919c33575ebeb3e47dd71ffcb6e6 Author: Yoges

pgAdmin 4 commit: Fixed following SonarQube issues:

2020-08-03 Thread Akshay Joshi
Fixed following SonarQube issues: - Remove this assignment to the local variable, the value is never used. - Rename local variables to match the regular expression - Add logic to this except clause or eliminate it and rethrow the exception automatically. - Rename fields to match the regula

pgAdmin 4 commit: Fixed following SonarQube issues:

2020-07-30 Thread Akshay Joshi
Fixed following SonarQube issues: - Refactor functions to not always return the same value. - Rename "cls" to "self" or add the missing "self" parameter. - Remove useless assignment to variables. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitd

pgAdmin 4 commit: Fixed following SonarQube issues:

2020-07-27 Thread Akshay Joshi
Fixed following SonarQube issues:   1) Define a constant instead of duplicating this literal.   2) Reduce cognitive complexity (Patch by Aditya) Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fb0bc65cedcf00d5e539ae7e4eaad0786438fbb1 Modified

pgAdmin 4 commit: Fixed following SonarQube issues:

2020-06-26 Thread Akshay Joshi
Fixed following SonarQube issues: 1) Refactor function to reduce its Cognitive Complexity. 2) Rename variable to match the regular expression ^[_a-z][a-z0-9_]*$. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=115657a465405be94c8c25dab3f88c9a

pgAdmin 4 commit: Fixed following SonarQube issues:

2020-06-26 Thread Akshay Joshi
Fixed following SonarQube issues: 1. Boolean checks should not be inverted. 2. The comma operator should not be used. 3. Arguments to built-in functions should match documented types. 4. Redundant pairs of parentheses should be removed. 5. A conditionally executed single line should be denoted by i

pgAdmin 4 commit: Fixed following SonarQube issues:

2020-06-26 Thread Akshay Joshi
Fixed following SonarQube issues: 1. Method/Field names should comply with a naming convention. 2. Conditionals should start on new lines Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=830ac1cc9177c8b9ebed2304924cec1db22e45c3 Author: Satish

pgAdmin 4 commit: Fixed following SonarQube issues:

2020-06-24 Thread Akshay Joshi
Fixed following SonarQube issues: 1) TypeError can be thrown as might be null or undefined here. 2) Unexpected duplicate "white-space". 3) Unexpected missing generic font family. 4) Unexpected shorthand "padding" after "padding-left". Branch -- master Details --- https://git.postgresql.o