Thanks, patch applied.
On Fri, Aug 28, 2020 at 5:50 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi,
>
> Problem doesn't seem to go away for the newly added test cases. The
> default roles like pg_monitor, etc. do not exist for PG9.6 and below, and
> so the RESQL test cases a
Hi,
Problem doesn't seem to go away for the newly added test cases. The default
roles like pg_monitor, etc. do not exist for PG9.6 and below, and so the
RESQL test cases are failing :(.
I've modified the test cases to add 2 new roles for testing and then drop
them later.
Please review.
On Thu,
Thanks, patch applied.
On Thu, Aug 27, 2020 at 4:31 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Attached patch introduces a new key - replace_regex_pattern for RE-SQL
> test cases. It will synchronize the expected SQL with the backend SQL based
> on the regex
Hi Hackers,
Attached patch introduces a new key - replace_regex_pattern for RE-SQL test
cases. It will synchronize the expected SQL with the backend SQL based on
the regex string.
This will help fix the timezone mismatch issue occurring in RESQL test cases
for roles.
Please review.
On Thu, Aug 2
Hi,
I'll look into it.
On Thu, Aug 27, 2020 at 2:41 PM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi,
>
> RE-SQL test for the role node is failing if the timezone of DB is
> different.
>
> Traceback (most recent call last):
> File
> "/home/murtuza/projects/PEM/web/regress
Hi,
RE-SQL test for the role node is failing if the timezone of DB is different.
Traceback (most recent call last):
File
"/home/murtuza/projects/PEM/web/regression/re_sql/tests/test_resql.py",
line 500, in check_re_sql
self.assertEquals(sql, resp_sql)
File "/usr/lib/python3.6/unittest/cas
Fixed cognitive complexity issues and added some more RESQL test cases for
roles module.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53a54103379840795fc03f5940cb53dd99ff0ee9
Author: Aditya Toshniwal
Modified Files
--
.../serv
