Re: pgAdmin 4 commit: Fixed an issue where the validation error message is

2020-12-02 Thread Murtuza Zabuawala
On Thu, Dec 3, 2020 at 12:29 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > > > On Thu, Dec 3, 2020 at 11:18 AM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hello, >> >> Another observation, >> >> +if(msg && handler) { >> + msg = msg || _.valu

Re: pgAdmin 4 commit: Fixed an issue where the validation error message is

2020-12-02 Thread Rahul Shirsat
On Thu, Dec 3, 2020 at 11:18 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hello, > > Another observation, > > +if(msg && handler) { > + msg = msg || _.values(handler.errorModel.attributes)[0]; > + > + handler.trigger('pgadmin-session:model:invalid',

Re: pgAdmin 4 commit: Fixed an issue where the validation error message is

2020-12-02 Thread Murtuza Zabuawala
Hello, Another observation, +if(msg && handler) { + msg = msg || _.values(handler.errorModel.attributes)[0]; + + handler.trigger('pgadmin-session:model:invalid', msg, handler); + $(parentTr).addClass('error-in-grid'); +} +return this; + }, 1

Re: pgAdmin 4 commit: Fixed an issue where the validation error message is

2020-12-02 Thread Murtuza Zabuawala
Hello, What is the reason for adding delay *setTimeout(, 120)*? This is causing issues in automation testing and makes buttons enable/disable with slight delay. -- Regards, Murtuza Zabuawala *EDB* *POWER TO POSTGRES* https://www.edbpostgres.com On Fri, Oct 30, 2020 at 3:10 PM Akshay Joshi wro

pgAdmin 4 commit: Fixed an issue where the validation error message is

2020-10-30 Thread Akshay Joshi
Fixed an issue where the validation error message is shown twice. Fixes #5736 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=183c83f0d2b2cb8dd33f9e8c41a030bc4cdaa4b2 Author: Rahul Shirsat Modified Files -- docs/en_US/release_note