Thanks - patch applied.
On Tue, Mar 6, 2018 at 2:57 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello Khushboo,
> Thanks for the changes here. Now everything looks good, and the tests all
> pass.
>
> Thanks
> Joao
>
> On Tue, Mar 6, 2018 at 5:09 AM Khushboo Vashi <
> khus
Hello Khushboo,
Thanks for the changes here. Now everything looks good, and the tests all
pass.
Thanks
Joao
On Tue, Mar 6, 2018 at 5:09 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> On Mon, Mar 5, 2018 at 8:42 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
On Mon, Mar 5, 2018 at 8:42 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello Khushboo,
> Looks like we are almost doen, just missing one PEP-8 issue:
> → pycodestyle --config=.pycodestyle pgadmin/tools
> pgadmin/tools/sqleditor/tests/test_poll_query_tool.py:46: [E126]
> c
Hello Khushboo,
Looks like we are almost doen, just missing one PEP-8 issue:
→ pycodestyle --config=.pycodestyle pgadmin/tools
pgadmin/tools/sqleditor/tests/test_poll_query_tool.py:46: [E126]
continuation line over-indented for hanging indent
1 E126 continuation line over-indented for hanging
On Fri, Mar 2, 2018 at 6:55 PM, Dave Page wrote:
> Could you rebase this please? It no longer applies.
>
> Please find the attached updated patch.
> Thanks.
>
> On Thu, Mar 1, 2018 at 5:56 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Joao,
>>
>> Thanks for reviewing.
>>
Hello Dave,
Very well said, I didn't intended to say that Feature Tests are not
important, what I was saying is that when we can do faster and more
thorough tests we should take it. All the tests that we do are important to
ensure that the software we produce is of good quality.
Also the higher y
On Thu, Mar 1, 2018 at 3:21 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello Khushboo,
> The patch runs successfully in our CI with all tests passing.
>
> I see the test that you created, and I do not understand why we need to
> create tests that do HTTP requests in order
Could you rebase this please? It no longer applies.
Thanks.
On Thu, Mar 1, 2018 at 5:56 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi Joao,
>
> Thanks for reviewing.
>
> On Wed, Feb 28, 2018 at 8:55 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hel
Hello Khushboo,
The patch runs successfully in our CI with all tests passing.
I see the test that you created, and I do not understand why we need to
create tests that do HTTP requests in order to check something that is
executed against the database. What I was talking about in my previous
email
Hi Joao,
Thanks for reviewing.
On Wed, Feb 28, 2018 at 8:55 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello Khushboo,
> After reviewing the patch I have the gut feeling that we do not have
> enough test coverage on this issue, specially due to the intricate while
> loo
Hello Khushboo,
After reviewing the patch I have the gut feeling that we do not have enough
test coverage on this issue, specially due to the intricate while loop and
conditions around the polling.
I think that this deserve Unit tests around it, When I say Unit Test I am
not talking about executing
On Mon, Feb 26, 2018 at 10:02 PM, Dave Page wrote:
> Argh, I ran some tests, but didn't spot any lost messages in the tests I
> ran. I'll revert the patch.
>
> Khushboo;
>
> Please look at the following:
>
> - Fix the patch so it doesn't drop messages.
>
Fixed.
By default, the notice attribute of
FYI, This is what I'm receiving(attachments) when I'm running vacuum full
verbose on my PG10.
On Mon, Feb 26, 2018 at 10:02 PM, Dave Page wrote:
> Argh, I ran some tests, but didn't spot any lost messages in the tests I
> ran. I'll revert the patch.
>
> Khushboo;
>
> Please look at the follo
Argh, I ran some tests, but didn't spot any lost messages in the tests I
ran. I'll revert the patch.
Khushboo;
Please look at the following:
- Fix the patch so it doesn't drop messages.
- Add regression tests to make sure it doesn't break in the future. This
may require creating one or more func
Sent bit early,
You can run 'VACUUM FULL VERBOSE' in query tool and verify the populated
messages (pgAdmin3 vs. pgAdmin4).
On Mon, Feb 26, 2018 at 9:48 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi Khushboo/Dave,
>
> With given commit, I'm again seeing the issue raised
Hi Khushboo/Dave,
With given commit, I'm again seeing the issue raised in
https://redmine.postgresql.org/issues/1523 :(
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, Feb 26, 2018 at 7:49 PM, Dave Page wrote:
> Ensure we pi
Ensure we pick up the messages from the current query and not a previous one.
Fixes #3094
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=08b3ccc01a4d57e8ea3657f8882a53dcd1b99386
Author: Khushboo Vashi
Modified Files
--
web/pgadm
17 matches
Mail list logo
