Re: pgAdmin 4 - next gettext usage fixes

Thanks, patch applied. On Sun, Apr 19, 2020 at 5:50 PM Libor M. wrote: > Hi, > I sending patch for slightly modified the use of gettext: > - fixed `%` vs. `.format()` > - unified texts and usage `%s` vs. `{}`/`{0}` > - improved text sentences for translate > - added gettext for next texts > > Be

Re: pgAdmin 4 - next gettext usage fixes

Hi, I sending patch for slightly modified the use of gettext: - fixed `%` vs. `.format()` - unified texts and usage `%s` vs. `{}`/`{0}` - improved text sentences for translate - added gettext for next texts Best regards, Libor M. E-mail: libor...@gmail.com GitHub: https://github.com/liborm85 čt

Re: pgAdmin 4 - next gettext usage fixes

Thanks, patch applied. On Wed, Apr 15, 2020 at 5:17 PM Libor M. wrote: > Hi, > next minor gettext and format fixes in patch. > > Best regards, > > Libor M. > > E-mail: libor...@gmail.com > GitHub: https://github.com/liborm85 > > st 15. 4. 2020 v 13:17 odesílatel Akshay Joshi > napsal: > > > > T

Re: pgAdmin 4 - next gettext usage fixes

Hi, next minor gettext and format fixes in patch. Best regards, Libor M. E-mail: libor...@gmail.com GitHub: https://github.com/liborm85 st 15. 4. 2020 v 13:17 odesílatel Akshay Joshi napsal: > > Thanks, patch applied. > > On Wed, Apr 15, 2020 at 2:55 PM Aditya Toshniwal > wrote: >> >> Hi, >>

Re: pgAdmin 4 - next gettext usage fixes

Thanks, patch applied. On Wed, Apr 15, 2020 at 2:55 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Please find the updated patch. > > On Wed, Apr 15, 2020 at 1:33 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya >> >> I think the fix is incorrect

Re: pgAdmin 4 - next gettext usage fixes

Hi, Please find the updated patch. On Wed, Apr 15, 2020 at 1:33 PM Akshay Joshi wrote: > Hi Aditya > > I think the fix is incorrect. .format method should be applied after > gettext() like gettext().format(). Please check for other places too and > send the updated patch. > > On Wed, Apr 15, 20

Re: pgAdmin 4 - next gettext usage fixes

Hi Aditya I think the fix is incorrect. .format method should be applied after gettext() like gettext().format(). Please check for other places too and send the updated patch. On Wed, Apr 15, 2020 at 11:38 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers/Libor, > > Th

Re: pgAdmin 4 - next gettext usage fixes

On Wed, Apr 15, 2020 at 11:38 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers/Libor, > > The changes like below are incorrect. Try "Count rows" from a table's > context menu. > > -info=gettext("Table rows counted: %s" % count), > > +info=gettext

Re: pgAdmin 4 - next gettext usage fixes

Hi Hackers/Libor, The changes like below are incorrect. Try "Count rows" from a table's context menu. -info=gettext("Table rows counted: %s" % count), +info=gettext("Table rows counted: %s") % count, Attached is the patch to fix all such changes in pgAdmin, to use format

Re: pgAdmin 4 - next gettext usage fixes

Hi Libor Thanks, patch applied. Please make sure to run the PEP8 checks before sending the patch. I have fixed and committed the code. On Wed, Apr 8, 2020 at 9:30 PM Libor M. wrote: > Hello, > I fixed next gettext usage: > > - fixed gettext usage with .format() only for original text with %s >

pgAdmin 4 - next gettext usage fixes

Hello, I fixed next gettext usage: - fixed gettext usage with .format() only for original text with %s - fixed typos - fixed translation yes/no buttons in dialog - improved translating sentences without "connecting" words (eg. see web/pgadmin/dashboard/static/js/dashboard.js, word 'cancel' needs t