Re: oauth2 patch

2021-05-24 Thread Khushboo Vashi
Hi Florian, I have reviewed your patch, some modifications are required as below. I have started working on top of your patch to accommodate the required changes. - Proper handling of Master Password in Server Mode as it was introduced only in Desktop mode. - Encryption/Decryption of the server p

Re: oauth2 patch

2021-05-10 Thread Khushboo Vashi
On Mon, May 10, 2021 at 10:59 AM Akshay Joshi wrote: > Hi Khushboo > > Can you please review the patch? > On it. > > On Sun, May 9, 2021 at 12:53 AM Florian Sabonchi > wrote: > >> Hello in this patch I have implemented OAuth2. Unfortunately I wasn't >> sure how the test should look like, becaus

Re: oauth2 patch

2021-05-09 Thread Akshay Joshi
Hi Khushboo Can you please review the patch? On Sun, May 9, 2021 at 12:53 AM Florian Sabonchi wrote: > Hello in this patch I have implemented OAuth2. Unfortunately I wasn't > sure how the test should look like, because I couldn't find anything in > the developer documentation, so I decided not

oauth2 patch

2021-05-08 Thread Florian Sabonchi
Hello in this patch I have implemented OAuth2. Unfortunately I wasn't sure how the test should look like, because I couldn't find anything in the developer documentation, so I decided not to write one for now. The configuration has to look like this here is an example for github: OAUTH2_NAME =