Re: Runtime refactoring

2020-07-28 Thread Akshay Joshi
Hi Dave/Hackers, Attached is the patch to fix newly introduce SoanrQube code smells. Please review it. On Tue, Jul 28, 2020 at 4:22 PM Akshay Joshi wrote: > Thanks, patch applied with some fixes. I'll work on the SonarQube code > smell and commit them later. > > On Mon, Jul 27, 2020 at 5:55 PM

Re: Runtime refactoring

2020-07-28 Thread Akshay Joshi
Thanks, patch applied with some fixes. I'll work on the SonarQube code smell and commit them later. On Mon, Jul 27, 2020 at 5:55 PM Dave Page wrote: > Hi Akshay, > > Updated patch attached. > > Thanks. > > On Mon, Jul 27, 2020 at 12:08 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: >

Re: Runtime refactoring

2020-07-27 Thread Dave Page
Hi Akshay, Updated patch attached. Thanks. On Mon, Jul 27, 2020 at 12:08 PM Akshay Joshi wrote: > Hi Dave > > The patch is not applied, can you please rebase and send again. > > On Fri, Jul 17, 2020 at 3:40 PM Dave Page wrote: > >> BTW, this will fix https://redmine.postgresql.org/issues/5490

Re: Runtime refactoring

2020-07-27 Thread Akshay Joshi
Hi Dave The patch is not applied, can you please rebase and send again. On Fri, Jul 17, 2020 at 3:40 PM Dave Page wrote: > BTW, this will fix https://redmine.postgresql.org/issues/5490 > > On Thu, Jul 16, 2020 at 10:41 AM Dave Page wrote: > >> Here's a pretty large patch that implements a majo

Re: Runtime refactoring

2020-07-17 Thread Dave Page
BTW, this will fix https://redmine.postgresql.org/issues/5490 On Thu, Jul 16, 2020 at 10:41 AM Dave Page wrote: > Here's a pretty large patch that implements a major refactoring of the > runtime code. Specifically: > > - Move the bulk of the core code from main() into a new Runtime class. > - Br

Runtime refactoring

2020-07-16 Thread Dave Page
Here's a pretty large patch that implements a major refactoring of the runtime code. Specifically: - Move the bulk of the core code from main() into a new Runtime class. - Break up the mass of code that was main() into a number of relatively simple functions. - Make the Configuration dialog synchr