Re: Resql test cases for views and fix for bug: 4650

2019-08-28 Thread Akshay Joshi
Thanks patch applied. On Tue, Aug 27, 2019 at 8:02 PM Usman Muzaffar < usman.muzaf...@enterprisedb.com> wrote: > Hi, > Please find here updated patch with the above required test cases. > > Please review and commit the changes > > On Tue, Aug 27, 2019 at 12:44 PM Akshay Joshi < > akshay.jo...@ent

Re: Resql test cases for views and fix for bug: 4650

2019-08-27 Thread Usman Muzaffar
Hi, Please find here updated patch with the above required test cases. Please review and commit the changes On Tue, Aug 27, 2019 at 12:44 PM Akshay Joshi wrote: > Hi Usman > > I have modified the code, please work on the following test cases: > >- No test case for privileges at all. >-

Re: Resql test cases for views and fix for bug: 4650

2019-08-27 Thread Akshay Joshi
Hi Usman I have modified the code, please work on the following test cases: - No test case for privileges at all. - We should add alter test cases for check_option, security_barrier and privileges. Attached is the modified patch, please continue your work on it. On Tue, Aug 27, 2019 at

Re: Resql test cases for views and fix for bug: 4650

2019-08-26 Thread Usman Muzaffar
Just a correction, bug reference in above mail should be *4486* instead of *4650*. On Mon, Aug 26, 2019 at 7:50 PM Usman Muzaffar < usman.muzaf...@enterprisedb.com> wrote: > Hi Hackers, > > Please find here attached patch for sql re engineering test cases for > views node. As part of this patch I

Resql test cases for views and fix for bug: 4650

2019-08-26 Thread Usman Muzaffar
Hi Hackers, Please find here attached patch for sql re engineering test cases for views node. As part of this patch I have also incorported followings - Fix for bug # 4650 - Also modified views/template/create.sql due to which, apparently same output and input was not matching for test c