Re: pgAdmin 4 commit: Support for external tables in GPDB. Fixes #3168

2018-03-12 Thread Joao De Almeida Pereira
Hello Murtuza, Yes I think it makes sense Thanks Joao On Mon, Mar 12, 2018 at 10:40 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Joao, > > Can we make tests to skip if db is not greenplum? > Like we are doing for resource group > "..web/pgadmin/browser/server_groups/ser

Re: pgAdmin 4 commit: Support for external tables in GPDB. Fixes #3168

2018-03-12 Thread Murtuza Zabuawala
Hi Joao, Can we make tests to skip if db is not greenplum? Like we are doing for resource group "..web/pgadmin/browser/server_groups/servers/resource_groups/tests". On Mon, Mar 12, 2018 at 7:52 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Joao's patch is pen

Re: pgAdmin 4 commit: Support for external tables in GPDB. Fixes #3168

2018-03-12 Thread Murtuza Zabuawala
Hi Dave, Joao's patch is pending, would you please do the needful? I also encounter similar issue on Windows while running tests. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Mar 6, 2018 at 8:25 PM, Joao De Almeida Pereira < j

Re: pgAdmin 4 commit: Support for external tables in GPDB. Fixes #3168

2018-03-06 Thread Joao De Almeida Pereira
Hello Neel, You can find attached the corrections of the path's needed for windows. The fix should correct TestExternalTablesView and TestTemplateCreate but for the ChangePasswordTestCase I need more information to help you out. We need to understand what is the response that the endpoint /user_ma

Re: pgAdmin 4 commit: Support for external tables in GPDB. Fixes #3168

2018-03-05 Thread Neel Patel
Hi Joao, I ran the testsuite in windows 10 with Python 3.4 and it fails for external tables. Linux it is working fine. Let me know if I miss anything. Please check the below logs. python runtests.py --pkg browser --exclude feature_tests