Re: Require suggestions for Issue #2874

2024-09-11 Thread Aditya Toshniwal
Hi Rohit, It is actually the same as existing with only difference is alternate row backgrounds. If later we remove the alternate bg using preferences then issue of distinguishing row numbers will remain un-fixed. On Tue, Sep 10, 2024 at 5:41 PM Rohit Bhati wrote: > Ok, I am applying that. > >

Re: Require suggestions for Issue #2874

2024-09-10 Thread Rohit Bhati
Ok, I am applying that. Thanks for the suggestions. On Tue, Sep 10, 2024 at 5:34 PM Dave Page wrote: > Hi > > > On Tue, 10 Sep 2024 at 12:43, Rohit Bhati > wrote: > >> Hi Dave, >> >> I have made some changes and made the header and serial number row >> column color the same. >> >> Please once

Re: Require suggestions for Issue #2874

2024-09-10 Thread Dave Page
Hi On Tue, 10 Sep 2024 at 12:43, Rohit Bhati wrote: > Hi Dave, > > I have made some changes and made the header and serial number row > column color the same. > > Please once check the attached images. > I think that looks much better! Thanks. > > Thanks > > On Tue, Sep 10, 2024 at 2:42 PM

Re: Require suggestions for Issue #2874

2024-09-10 Thread Dave Page
Hi Shadow is more visible, but it doesn't really follow the material UI styling which is flat rather than 3D. I think Anil's idea is worth exploring; remove the alternating colour for the row number column, and use a different background shade for it entirely. On Tue, 10 Sept 2024 at 08:38, Rohi

Re: Require suggestions for Issue #2874

2024-09-09 Thread Rohit Bhati
I already set weight to 900. If we need to be more distinct then I think we can have some shadow or if anything else please suggest. On Mon, Sep 9, 2024 at 3:29 PM Dave Page wrote: > Hi > > On Mon, 9 Sept 2024 at 10:18, Rohit Bhati > wrote: > >> Hi Dave, >> >> I have made changes as per your su

Re: Require suggestions for Issue #2874

2024-09-09 Thread Anil Sahoo
Hi Rohit/Dave, If we can remove the alternate background color from the row number column and give light grey or different color to the row number column and the column header, that will make the data distinct with the alternate background color from the headers and row number column. Any thought

Re: Require suggestions for Issue #2874

2024-09-09 Thread Dave Page
Hi On Mon, 9 Sept 2024 at 10:18, Rohit Bhati wrote: > Hi Dave, > > I have made changes as per your suggestions. > I have attached screenshots showing how the updates look across all themes > for your reference. > > If the current changes does not fit well with the theme or if you have any > sugg

Re: Require suggestions for Issue #2874

2024-09-06 Thread Dave Page
On Fri, 6 Sept 2024 at 09:25, Rohit Bhati wrote: > I have made some more changes with changing background color. > Yeah, that looks weird again, specifically on the selected rows. I believe the issue is that we should not highlight the row number column when a row is selected at all. That makes

Re: Require suggestions for Issue #2874

2024-09-06 Thread Dave Page
Hi On Fri, 6 Sept 2024 at 09:19, Rohit Bhati wrote: > Hi, > > I have removed the border and background color, just made the row numbers > bold. > > I have attached screenshots showing how the updates look across all themes > . > That doesn't look bold at all to me - and I think we still need so

Re: Require suggestions for Issue #2874

2024-09-06 Thread Khushboo Vashi
On Thu, Sep 5, 2024 at 7:11 PM Dave Page wrote: > Hi > > On Thu, 5 Sept 2024 at 14:38, Rohit Bhati > wrote: > >> Hi, >> >> I have made changes for issue #7863 >> based on theme >> requirements. >> >> I have attached screenshots showing how th

Re: Require suggestions for Issue #2874

2024-09-05 Thread Yogesh Mahajan
On Thu, Sep 5, 2024 at 7:11 PM Dave Page wrote: Hi, Hi > > On Thu, 5 Sept 2024 at 14:38, Rohit Bhati > wrote: > >> Hi, >> >> I have made changes for issue #7863 >> based on theme >> requirements. >> >> I have attached screenshots showing how

Re: Require suggestions for Issue #2874

2024-09-05 Thread Dave Page
Hi On Thu, 5 Sept 2024 at 14:38, Rohit Bhati wrote: > Hi, > > I have made changes for issue #7863 > based on theme > requirements. > > I have attached screenshots showing how the updates look across all themes > for your reference. > > If the

Re: Require suggestions for Issue #2874

2024-09-05 Thread Dave Page
Hi On Thu, 5 Sept 2024 at 12:19, Rohit Bhati wrote: > Hi, > > Currently it is just theme based, whenever the user changes the theme > accordingly the color changes. > Not for any specific preference option for this right now, But if we want > that we can add. > Let's just go with it for now, an

Re: Require suggestions for Issue #2874

2024-09-05 Thread Rohit Bhati
Hi, Currently it is just theme based, whenever the user changes the theme accordingly the color changes. Not for any specific preference option for this right now, But if we want that we can add. And if i am not wrong you are talking about this #7863

Re: Require suggestions for Issue #2874

2024-09-05 Thread Dave Page
Hi On Thu, 5 Sept 2024 at 08:27, Rohit Bhati wrote: > Hi Hackers, > > Please check the updated attached screenshot for an alternate background > color of table rows. > The images also shows alternate row color with some selected rows color > from the table. > > I think that looks good. Are you