Cool - that works. Patch applied.
Thanks!
On Tue, Feb 27, 2018 at 6:30 AM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:
> Hi,
>
> On Tue, Feb 27, 2018 at 1:08 AM, Dave Page wrote:
>
>> Hi,
>>
>> I'm still able to make it get stuck, if I tab back and forth quickly.
>>
> Quickly switc
Hi,
On Tue, Feb 27, 2018 at 1:08 AM, Dave Page wrote:
> Hi,
>
> I'm still able to make it get stuck, if I tab back and forth quickly.
>
Quickly switching tabs was causing to switch to next tab before previous
navigation was completed and
this was leading to lose focus on tab pane.
Now I have mad
Hi,
I'm still able to make it get stuck, if I tab back and forth quickly.
On Mon, Feb 26, 2018 at 6:04 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:
> Hi,
>
> Please find the updated patch.
>
> On Mon, Feb 26, 2018 at 8:03 PM, Dave Page wrote:
>
>> Hi
>>
>> On Mon, Feb 26, 2018 a
Hi,
Please find the updated patch.
On Mon, Feb 26, 2018 at 8:03 PM, Dave Page wrote:
> Hi
>
> On Mon, Feb 26, 2018 at 12:03 PM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the updated patch for keyboard navigation.
>>
>> In this patch I have reduced del
Hi
On Mon, Feb 26, 2018 at 12:03 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:
> Hi,
>
> Please find the updated patch for keyboard navigation.
>
> In this patch I have reduced delay which is required until current tab
> navigation is completed.
> Extracted class dialogTabNavigator
Hi,
Please find the updated patch for keyboard navigation.
In this patch I have reduced delay which is required until current tab
navigation is completed.
Extracted class dialogTabNavigator and put it in new file.
Added jasmine test cases.
Fixed linting issues, variable naming convention issues.
Hi,
On Wed, Feb 21, 2018 at 10:59 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Yep I installed the V2 file
>
> On Wed, Feb 21, 2018 at 11:31 AM Dave Page wrote:
>
>> On Wed, Feb 21, 2018 at 4:22 PM, Joao De Almeida Pereira <
>> jdealmeidapere...@pivotal.io> wrote:
>>
>>>
Yep I installed the V2 file
On Wed, Feb 21, 2018 at 11:31 AM Dave Page wrote:
> On Wed, Feb 21, 2018 at 4:22 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hello Harshal,
>>
>> I passed the patch through our CI and all the tests passed. The changes
>> do not break prev
On Wed, Feb 21, 2018 at 4:22 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello Harshal,
>
> I passed the patch through our CI and all the tests passed. The changes do
> not break previous behavior but because there are no tests on the new
> feature we could not be sure it
Hello Harshal,
I passed the patch through our CI and all the tests passed. The changes do
not break previous behavior but because there are no tests on the new
feature we could not be sure it was really working. So we did some manual
testing and sometimes it doesn't work, like it gets stuck in a
Hi,
--
*Harshal Dhumal*
*Sr. Software Engineer*
EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Tue, Feb 20, 2018 at 10:34 PM, Dave Page wrote:
> Hi
>
> On Tue, Feb 20, 2018 at 7:22 AM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi,
>>
Hi
On Tue, Feb 20, 2018 at 7:22 AM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:
> Hi,
>
> Please find attached patch to enable keyboard navigation in dialog.
>
> To allow navigation from one tab pane (bootstrap tab pane) to another one
> I have added two new shortcut preferences *Dia
12 matches
Mail list logo
