Re: JavaScript Errors in the Query Tool Leads to a False Message

2019-08-05 Thread Yosry Muhammad
On Tue, Aug 6, 2019, 6:42 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Yosry, > > Yes, I have experienced the same but missed to log a bug. You can log a > bug so that someone can work on it. > To simulate the issue, just add some JS code that will cause error. > >> >> Will

Re: JavaScript Errors in the Query Tool Leads to a False Message

2019-08-05 Thread Aditya Toshniwal
Hi Yosry, Yes, I have experienced the same but missed to log a bug. You can log a bug so that someone can work on it. To simulate the issue, just add some JS code that will cause error. On Tue, Aug 6, 2019 at 10:06 AM Avin Kavish wrote: > Is there a way to reproduce this? i.e force a js error d

Re: JavaScript Errors in the Query Tool Leads to a False Message

2019-08-05 Thread Yosry Muhammad
Yes, if you undo this commit: https://redmine.postgresql.org/projects/pgadmin4/repository/revisions/97e39699ead1005a4a5ef8e986d980df8f743db9 This was a fix of a bug that occurred when querying a table with no columns. It displayed the same error mentioned in the original email and was due to a JS

Re: JavaScript Errors in the Query Tool Leads to a False Message

2019-08-05 Thread Avin Kavish
Is there a way to reproduce this? i.e force a js error during query execution? One reason I can think of is using $.ajax({ async: false }) so the ajax request gets handled on the main thread and anything that throws on to the main thread gets caught. On Tue, Aug 6, 2019 at 4:07 AM Yosry Muhammad