Re: ESLINT: On pgAdmin static javascripts

2018-01-15 Thread Ashesh Vashi
On Tue, Jan 16, 2018 at 11:10 AM, Fahar Abbas wrote: > Hi Ashesh, > > I have finished smoke verification for all the modules and no issue found > so far and currently doing testing in detail. > Thanks Fahar for the update! -- Thanks & Regards, Ashesh Vashi > > Kind Regards, > > > On Mon, Jan 1

Re: ESLINT: On pgAdmin static javascripts

2018-01-15 Thread Fahar Abbas
Hi Ashesh, I have finished smoke verification for all the modules and no issue found so far and currently doing testing in detail. Kind Regards, On Mon, Jan 15, 2018 at 10:17 AM, Fahar Abbas wrote: > > > On Fri, Jan 12, 2018 at 12:35 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote:

Re: ESLINT: On pgAdmin static javascripts

2018-01-14 Thread Fahar Abbas
On Fri, Jan 12, 2018 at 12:35 PM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Thu, Jan 11, 2018 at 11:16 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Murtuza, >> >> On Tue, Jan 9, 2018 at 4:08 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote:

Re: ESLINT: On pgAdmin static javascripts

2018-01-11 Thread Ashesh Vashi
On Thu, Jan 11, 2018 at 11:16 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > Hi Murtuza, > > On Tue, Jan 9, 2018 at 4:08 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> All patches looks good to me except one issue as shown in screenshot >> which I observed while opening Preferenc

Re: ESLINT: On pgAdmin static javascripts

2018-01-10 Thread Ashesh Vashi
Hi Murtuza, On Tue, Jan 9, 2018 at 4:08 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > All patches looks good to me except one issue as shown in screenshot which > I observed while opening Preferences dialog subsequently. > I was able to reproduce the issue on 'master' branc

Re: ESLINT: On pgAdmin static javascripts

2018-01-08 Thread Ashesh Vashi
Please try rest of the patches... They are independent of each other. -- Thanks, Ashesh On Jan 8, 2018 23:45, "Murtuza Zabuawala" < murtuza.zabuaw...@enterprisedb.com> wrote: > ​Hi Ashesh, > > I'm not able to apply patch :( > > murtuza@debian:~/projects/pgadmin4$ git apply ~/Desktop/*.patch > er

Re: ESLINT: On pgAdmin static javascripts

2018-01-08 Thread Murtuza Zabuawala
​Hi Ashesh, I'm not able to apply patch :( murtuza@debian:~/projects/pgadmin4$ git apply ~/Desktop/*.patch error: patch failed: web/pgadmin/misc/file_manager/static/js/utility.js:10 error: web/pgadmin/misc/file_manager/static/js/utility.js: patch does not apply murtuza@debain:~/projects/pgadmin

Re: ESLINT: On pgAdmin static javascripts

2018-01-08 Thread Ashesh Vashi
On Mon, Jan 8, 2018 at 8:52 PM, Dave Page wrote: > Hi > > On Mon, Jan 8, 2018 at 3:18 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Mon, Jan 8, 2018 at 8:31 PM, Dave Page wrote: >> >>> Hi >>> >>> I think these are impossibly big to properly review by hand, especially >>> whe

Re: ESLINT: On pgAdmin static javascripts

2018-01-08 Thread Dave Page
Hi On Mon, Jan 8, 2018 at 3:18 PM, Ashesh Vashi wrote: > On Mon, Jan 8, 2018 at 8:31 PM, Dave Page wrote: > >> Hi >> >> I think these are impossibly big to properly review by hand, especially >> where much of them are whitespace changes. >> > I ran both jasmine test framework, and feature tests

Re: ESLINT: On pgAdmin static javascripts

2018-01-08 Thread Ashesh Vashi
On Mon, Jan 8, 2018 at 8:31 PM, Dave Page wrote: > Hi > > I think these are impossibly big to properly review by hand, especially > where much of them are whitespace changes. > I ran both jasmine test framework, and feature tests. Both are running fine. > > I think the best option is to check th

Re: ESLINT: On pgAdmin static javascripts

2018-01-08 Thread Dave Page
Hi I think these are impossibly big to properly review by hand, especially where much of them are whitespace changes. I think the best option is to check the regression tests all pass, do some manual testing yourself, and then commit. On Mon, Jan 8, 2018 at 1:55 PM, Ashesh Vashi wrote: > Hi Da