Re: [pgadmin4][patch] Use pytest test runner for unit tests

2018-06-17 Thread Khushboo Vashi
Hi, The supported versions of Pytest: Python 2.7, Python 3.4+, PyPy 2.3, Jython 2.5 (untested); Grappa: Python 2.7+, 3+ References: https://docs.pytest.org/en/latest/ https://github.com/grappa-py/grappa So, how are we going to handle unsupported versions (PY 2.6 and 3.3) ? Thanks, Khushboo On

Re: [pgadmin4][patch] Use pytest test runner for unit tests

2018-06-13 Thread Dave Page
Hi On Tue, Jun 12, 2018 at 3:41 PM, Victoria Henry wrote: > Hi Dave, > > Attached are four different patches that should be applied in order. > Included is a fix for the failing test above. > This is no longer failing :-) However, I'm still seeing problems that need to be resolved: - Password

Re: [pgadmin4][patch] Use pytest test runner for unit tests

2018-06-13 Thread Dave Page
Hi On Tue, Jun 12, 2018 at 8:39 PM, Victoria Henry wrote: > Hi Dave, > > >> >> No, because it's firewalled to the nines inside our network. There's no >> chance I'm making production build machines internet-accessible. >> > > For a Open Source project, if the community cannot see the place where

Re: [pgadmin4][patch] Use pytest test runner for unit tests

2018-06-11 Thread Dave Page
Hi On Mon, Jun 4, 2018 at 3:26 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Known issues: >>> >>>- Python 2.7, the library we are using for assertions (Grappa) is >>>failing while trying to assert on strings. We created a PR to the >>> library: >>>https://gith

Re: [pgadmin4][patch] Use pytest test runner for unit tests

2018-05-25 Thread Joao De Almeida Pereira
Hello Dave > As part of the development environment we do not see the reasoning behind >> not add PYTHONPATH to the environment variables, specially because this >> looks like the way pytest was invisoned. >> > > Really? It's one more step that wasn't previously required, and for which > there is

Re: [pgadmin4][patch] Use pytest test runner for unit tests

2018-05-25 Thread Dave Page
Hi On Thu, May 24, 2018 at 8:36 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > As part of the development environment we do not see the reasoning behind > not add PYTHONPATH to the environment variables, specially because this > looks like the way pytest was invisoned. > Re

Re: [pgadmin4][patch] Use pytest test runner for unit tests

2018-05-24 Thread Joao De Almeida Pereira
As part of the development environment we do not see the reasoning behind not add PYTHONPATH to the environment variables, specially because this looks like the way pytest was invisoned. However please try the following patch instead. We've changed the pytest invocation to assume the relevant dir

Re: [pgadmin4][patch] Use pytest test runner for unit tests

2018-05-24 Thread Dave Page
On Thu, May 24, 2018 at 5:14 PM, Anthony Emengo wrote: > Here’s a followup patch with the relevant README and Makefile changes. To > be clear, both patches need to be applied in succession to run the tests. > > The error that you were running into was because the appropriate > PYTHONPATH environm

Re: [pgadmin4][patch] Use pytest test runner for unit tests

2018-05-24 Thread Anthony Emengo
Here’s a followup patch with the relevant README and Makefile changes. To be clear, both patches need to be applied in succession to run the tests. The error that you were running into was because the appropriate PYTHONPATH environment variable was not set. We updated the README to reflect that, b

Re: [pgadmin4][patch] Use pytest test runner for unit tests

2018-05-24 Thread Dave Page
Hi On Wed, May 23, 2018 at 10:48 PM, Anthony Emengo wrote: > Hey all, > > Attached is a rather large patch that attempts to introduce the Pytest > test runner and Grappah test matcher into our code base. The patch replaces > all of the previous python unit tests from the previous design. This is