Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

2017-07-21 Thread Dave Page
And... applied. Thanks. On Fri, Jul 21, 2017 at 1:28 PM, Dave Page wrote: > > > On Fri, Jul 21, 2017 at 12:34 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> >> >> On Jul 21, 2017 4:23 PM, "Dave Page" wrote: >> >> >> >> On Fri, Jul 21, 2017 at 11:05 AM, Harshal Dhumal < >> h

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

2017-07-21 Thread Dave Page
On Fri, Jul 21, 2017 at 12:34 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > > > On Jul 21, 2017 4:23 PM, "Dave Page" wrote: > > > > On Fri, Jul 21, 2017 at 11:05 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> On Fri, Jul 21, 2017 at 2:24 PM, Dave Pa

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

2017-07-21 Thread Harshal Dhumal
On Jul 21, 2017 4:23 PM, "Dave Page" wrote: On Fri, Jul 21, 2017 at 11:05 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > On Fri, Jul 21, 2017 at 2:24 PM, Dave Page wrote: > >> Hi >> >> On Fri, Jul 21, 2017 at 9:38 AM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

2017-07-21 Thread Dave Page
On Fri, Jul 21, 2017 at 11:05 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > On Fri, Jul 21, 2017 at 2:24 PM, Dave Page wrote: > >> Hi >> >> On Fri, Jul 21, 2017 at 9:38 AM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Currently if user cl

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

2017-07-21 Thread Harshal Dhumal
Hi, On Fri, Jul 21, 2017 at 2:24 PM, Dave Page wrote: > Hi > > On Fri, Jul 21, 2017 at 9:38 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Currently if user clicks on empty white area below history entry then >> arrow navigation does not work. >> Attached patch fix

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

2017-07-21 Thread Dave Page
Hi On Fri, Jul 21, 2017 at 9:38 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Currently if user clicks on empty white area below history entry then > arrow navigation does not work. > Attached patch fixes this issue. > This fixes that problem, but stops it working if I *

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

2017-07-21 Thread Harshal Dhumal
Hi, Currently if user clicks on empty white area below history entry then arrow navigation does not work. Attached patch fixes this issue. [image: Inline image 1] -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company O

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

2017-07-20 Thread Dave Page
Ah, OK - I was working on them one at a time. Thanks, patches applied! On Thu, Jul 20, 2017 at 7:01 PM, Matthew Kleiman wrote: > Hi Dave, > > In our previous email, the second patch fixed the linting issue from the > first patch. > However, we've remade these two patches so they both pass the l

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

2017-07-20 Thread Matthew Kleiman
Hi Dave, In our previous email, the second patch fixed the linting issue from the first patch. However, we've remade these two patches so they both pass the linting test. Thanks, Matt and João On Thu, Jul 20, 2017 at 12:56 PM, Dave Page wrote: > > > On Thu, Jul 20, 2017 at 2:18 PM, Joao De Al

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

2017-07-20 Thread Dave Page
On Thu, Jul 20, 2017 at 2:18 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Dave, > Did you use the latest one patch we sent? > We realised that this was an issue in the second email we sent. > Just checked again, and yes, that was the third and latest version I've rece

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

2017-07-20 Thread Joao De Almeida Pereira
Hello Dave, Did you use the latest one patch we sent? We realised that this was an issue in the second email we sent. Thanks Joao On Thu, Jul 20, 2017, 8:15 AM Dave Page wrote: > Hi > > On Wed, Jul 19, 2017 at 8:33 PM, Shruti Iyer wrote: > >> Hi again! >> >> Attached are the most updated patche

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

2017-07-20 Thread Dave Page
Hi On Wed, Jul 19, 2017 at 8:33 PM, Shruti Iyer wrote: > Hi again! > > Attached are the most updated patches. We found an issue with the previous > implementation. So we generated the new patches. > The 01 patch fails linting: /Users/dpage/git/pgadmin4/web/regression/javascript/history/query_h

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

2017-07-19 Thread Shruti Iyer
Hi again! Attached are the most updated patches. We found an issue with the previous implementation. So we generated the new patches. Thanks, Joao and Shruti On Wed, Jul 19, 2017 at 2:39 PM Shruti Iyer wrote: > Hi Hackers, > > One of the patches didn't include some changes. Please find the upd

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

2017-07-19 Thread Shruti Iyer
Hi Hackers, One of the patches didn't include some changes. Please find the updated patches attached to this email. Thanks, Shruti and Joao On Wed, Jul 19, 2017 at 11:48 AM Shruti Iyer wrote: > Hello Hackers, > > Attached are two patches. The first patch adds the ability to navigate > through