Re: [pgadmin-hackers][Patch] Change alert styling

2017-06-30 Thread Dave Page
OK, thanks - patch applied. Note to all hackers: As we modify our override CSS moving forwards, it should be migrated to SCSS, and use the defined colour variable names. Thanks. On Thu, Jun 29, 2017 at 2:25 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi! > > Are you c

Re: [pgadmin-hackers][Patch] Change alert styling

2017-06-29 Thread Joao De Almeida Pereira
Hi! Are you committing to migrating all the main CSS to SCSS? Whilst I can see > the advantages of SCSS, I don't want to end up with a mix and match mess of > the two (though, I'd be fine with keeping the smaller, module-specific CSS > if it doesn't make sense to migrate it). It makes more sense

Re: [pgadmin-hackers][Patch] Change alert styling

2017-06-28 Thread Dave Page
Hi On Wed, Jun 28, 2017 at 4:40 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > In this patch we are introducing SCSS that we generated for the style > guide. > [image: Inline image 1] > > The patch is split into 2 files: > - 01-add-scss-building-to-webp