Re: [pgAgent][Patch] Fixing connection pool leak

2017-10-25 Thread Dave Page
On Wed, Oct 25, 2017 at 5:44 AM, Ashesh Vashi wrote: > On Tue, Oct 24, 2017 at 8:59 PM, Rob Emery > wrote: > >> Awesome thanks. >> >> What's the release schedule like for pgagent? >> > I have no idea. > That can be answered by Dave only. > > Dave? > Basically as soon as Neel's work is complete

Re: [pgAgent][Patch] Fixing connection pool leak

2017-10-24 Thread Ashesh Vashi
On Tue, Oct 24, 2017 at 8:59 PM, Rob Emery wrote: > Awesome thanks. > > What's the release schedule like for pgagent? > I have no idea. That can be answered by Dave only. Dave? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company

Re: [pgAgent][Patch] Fixing connection pool leak

2017-10-24 Thread Rob Emery
Awesome thanks. What's the release schedule like for pgagent? Thanks, Rob On 24 October 2017 at 16:05, Ashesh Vashi wrote: > On Tue, Oct 24, 2017 at 8:30 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Tue, Oct 24, 2017 at 8:21 PM, Robert Emery < >> robertem...@codeweavers

Re: [pgAgent][Patch] Fixing connection pool leak

2017-10-24 Thread Ashesh Vashi
On Tue, Oct 24, 2017 at 8:30 PM, Ashesh Vashi wrote: > On Tue, Oct 24, 2017 at 8:21 PM, Robert Emery > wrote: > >> Hello again, >> >> I can't see any other way of solving this problem without either exposing >> a method on JobThread to delete the Job owned by the thread which is called >> by htt

Re: [pgAgent][Patch] Fixing connection pool leak

2017-10-24 Thread Ashesh Vashi
On Tue, Oct 24, 2017 at 8:21 PM, Robert Emery wrote: > Hello again, > > I can't see any other way of solving this problem without either exposing > a method on JobThread to delete the Job owned by the thread which is called > by https://github.com/postgres/pgagent/blob/master/pgAgent.cpp#L139 or

Re: [pgAgent][Patch] Fixing connection pool leak

2017-10-24 Thread Rob Emery
Hello again, I can't see any other way of solving this problem without either exposing a method on JobThread to delete the Job owned by the thread which is called by https://github.com/postgres/pgagent/blob/master/pgAgent.cpp#L139 or another method that only gives up the connection which is called

Re: [pgAgent][Patch] Fixing connection pool leak

2017-10-23 Thread Rob Emery
Hiya, I've just confirmed neither of these patches resolve the issue, it appears in the error case I'm experiencing the JobThread::Entry() never executes. To clarify I'm talking about the path entering the else in pgAgent.cpp:125 which will save into pga_joblog with jlgstatus = "i" This path exp

Re: [pgAgent][Patch] Fixing connection pool leak

2017-10-23 Thread Rob Emery
Hiya, Actually, on reflection (I've not tested yet) but I don't think that'll actually work. Looking at pgAgent.cpp:119, Create and Run are only executed if it's Runnable. I've never used WXWidgets before so I'm not sure but I would guess that Create and Run execute the Entry() method on the new t

Re: [pgAgent][Patch] Fixing connection pool leak

2017-10-23 Thread Rob Emery
Hiya, That seems absolutely fine. I've tested the patch I had over the weekend, the problem is pretty easy to reproduce with a job that runs every minute and 4 instances of pgagent. I'll give this version a test as well, but I'm confident it should be fine. Thanks, Rob On 23 October 2017 at 06:

Re: [pgAgent][Patch] Fixing connection pool leak

2017-10-23 Thread Neel Patel
Hi Ashesh, I just added condition before delete the job otherwise it looks good. Correct me if I am wrong. if (job != NULL) { delete job; job = NULL; } I have created two instances of pgagent on database cluster. As of now not able to see any leak and keep you updated if found anything.

Re: [pgAgent][Patch] Fixing connection pool leak

2017-10-22 Thread Ashesh Vashi
Hi Rob, How about this? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Sat, Oct 21, 2017 at 8:36 PM, Rob Emery wrote: > Hi, > > Following