Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Awesome, thanks! Akshay Joshi 于2017年8月17日 周四下午8:24写道： > Thanks patch applied. > > On Wed, Aug 16, 2017 at 11:30 AM, Violet Cheng wrote: > >> Thanks Surinder! Hope it could be committed soon :) >> >> On Wed, Aug 16, 2017 at 1:34 PM, Surinder Kumar < >> surinder.ku...@enterprisedb.com> wrote: >> >

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Thanks patch applied. On Wed, Aug 16, 2017 at 11:30 AM, Violet Cheng wrote: > Thanks Surinder! Hope it could be committed soon :) > > On Wed, Aug 16, 2017 at 1:34 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi Violet, >> >> I have already reviewed this patch. Here is the

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Thanks Surinder! Hope it could be committed soon :) On Wed, Aug 16, 2017 at 1:34 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Violet, > > I have already reviewed this patch. Here is the link >

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Hi Violet, I have already reviewed this patch. Here is the link . Thanks, Surinder On Wed, Aug 16, 2017 at 8:57 AM, Violet Cheng wrote: > Hi, > > Any update on this patch? Could it be c

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Hi, Any update on this patch? Could it be committed soon? Thanks, Violet On Fri, Aug 11, 2017 at 1:40 PM, Sarah McAlear wrote: > Hi! > > We fixed that issue and created a new patch >

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Hi! We fixed that issue and created a new patch . Thanks! On Thu, Aug 10, 2017 at 4:10 PM, Violet Cheng wrote: > Here's the Redmine link > > https://redmine.postgresql.org/issu

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Here's the Redmine link https://redmine.postgresql.org/issues/2644 On Thu, Aug 10, 2017 at 4:03 PM, Violet Cheng wrote: > Hi Surinder! > > Are you referring to the green message popup? If so, it also appears to be > happening on master. We'll log a bug in our backlog and Redmine and > prioritiz

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Hi Surinder! Are you referring to the green message popup? If so, it also appears to be happening on master. We'll log a bug in our backlog and Redmine and prioritize it. We agree that it needs to be fixed, but don't think it's unrelated to this patch. Thanks! Violet & Sarah On Thu, Aug 10, 2017

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Hi Sarah, We noticed that due to this patch, the alert style of "Database connected" message is changed. Can you please look into this? Thanks, Surinder On Wed, Aug 9, 2017 at 4:43 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > ​Hi, > > ​The updated patch looks good to me. > > O

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

​Hi, ​The updated patch looks good to me. On Wed, Aug 9, 2017 at 4:15 PM, Sarah McAlear wrote: > As discussed with Surinder, we have created a Redmine ticket for his 4th > comment regarding the error message not showing up when the app can't be > reached. This issue existed prior to this patch

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

As discussed with Surinder, we have created a Redmine ticket for his 4th comment regarding the error message not showing up when the app can't be reached. This issue existed prior to this patch and should be prioritized. https://redmine.postgresql.org/issues/2640 Thanks! Matt & Sarah On Wed, Aug

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Hi Surinder! I am not able to see anything different from what I see on Master with or without the patch applied. I tried adjusting the preferences. I did update the dashboard.js to instantiate a new object, great idea! Thanks, Sarah On Wed, Aug 9, 2017 at 1:42 PM, Surinder Kumar < surinder.ku

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Hi Wenlin, On Tue, Aug 8, 2017 at 3:15 PM, Wenlin Zhang wrote: > Hi Surinder, > >Thanks for your review. > >We have changed the indentation for _dashboard.scss file and also > removed the style about icon-postgres:before, like margin-top,etc, but we > are not sure if it is perfectly alig

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Hi Surinder, Thanks for your review. We have changed the indentation for _dashboard.scss file and also removed the style about icon-postgres:before, like margin-top,etc, but we are not sure if it is perfectly aligned now, you can add further change to it. As the second comment, I'm sor

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Hi Ashesh, That's correct. This patch just changed alert style in the 'tabs', such as Dependency and Dependents. Thanks Wenlin On Mon, Aug 7, 2017 at 12:51 PM, Ashesh Vashi wrote: > Surinder, > > Please take a look at this patch. > > If I recalls correctly, this patch is related to stylin

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Surinder, Please take a look at this patch. If I recalls correctly, this patch is related to styling of the 'tabs' shown on the main window. Wenlin - please correct me if my understanding is wrong. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Hi hackers, Could you please review this patch? Thanks Wenlin and Sarah On Wed, Aug 2, 2017 at 2:15 PM, Wenlin Zhang wrote: > Hi Hackers, > > This patch changes the alert style in the sub-navigation to match style > guide. > > Thanks, > Wenlin, Shirley & Sarah > > >