Re: [pgAdmin4][patch] Fix feature tests failure

2017-08-25 Thread Ashesh Vashi
On Wed, Aug 16, 2017 at 8:54 AM, Violet Cheng wrote: > Hi, > > Is there any update on this patch? Will it be committed soon? > > Hi Violet, I've committed the patch with some changes. Removed one more occurrence of '_assert_not_clickable_because_out_of_view' added later by Hao Wang in commit: 51

Re: [pgAdmin4][patch] Fix feature tests failure

2017-08-15 Thread Violet Cheng
Hi, Is there any update on this patch? Will it be committed soon? Thanks, Violet On Thu, Aug 10, 2017 at 11:32 AM, Wenlin Zhang wrote: > As Sarah discussed with Khushboo on slack (pgadminhackers.slack.com for > those who would like to join) yesterday, these errors seem to occur only on > her U

Re: [pgAdmin4][patch] Fix feature tests failure

2017-08-09 Thread Wenlin Zhang
As Sarah discussed with Khushboo on slack (pgadminhackers.slack.com for those who would like to join) yesterday, these errors seem to occur only on her Ubuntu system. We have not replicated them on Mac. But they exist before this patch, also. We notice that copy/paste functionality is being tested

Re: [pgAdmin4][patch] Fix feature tests failure

2017-08-08 Thread Khushboo Vashi
Hi Sarah, I am doing this and didn't reply on this thread as we are discussing this on the another thread (the History Update patch). Thanks, Khushboo On Wed, Aug 9, 2017 at 9:10 AM, Sarah McAlear wrote: > Hi Hackers! > > Could someone review this patch, please? > > Thanks so much! > Sarah > >

Re: [pgAdmin4][patch] Fix feature tests failure

2017-08-08 Thread Sarah McAlear
Hi Hackers! Could someone review this patch, please? Thanks so much! Sarah On Mon, Aug 7, 2017 at 4:42 PM, Wenlin Zhang wrote: > Hi Hackers, > > This patch is about fixing the feature tests failure. > > Thanks, > Wenlin, Violet & Hao >