Thanks, patch applied.
On Thu, Mar 19, 2020 at 12:10 PM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hello,
>
> PFA updated patch with new colors provided by Chethana, As discussed we
> will be using the same primary success color in both theme so we don't have
> add new varia
Hi Murtuza,
The patch looks good to me.
On Thu, Mar 19, 2020 at 12:10 PM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hello,
>
> PFA updated patch with new colors provided by Chethana, As discussed we
> will be using the same primary success color in both theme so we don't ha
Hello,
PFA updated patch with new colors provided by Chethana, As discussed we
will be using the same primary success color in both theme so we don't have
add new variable.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Wed, Mar 18
Hi Murtuza/Chethana,
Irrespective of what color you suggest, there is no need to add new
variables for switch buttons. It should use success for on and ternary for
off.
Having a separate green color for each and every control is absurd. If the
green changes, it should change for all.
On Wed, Mar
Let us discuss on a call for better clarity and the conclusion part we can
put it on mail.
---
Chethana kumar
On Wed, Mar 18, 2020 at 2:12 PM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi Chethana,
>
> No it is not, As per current dark theme implementation we have used
> pr
Hi Chethana,
No it is not, As per current dark theme implementation we have used primary
color '#1a522b' for switch but the color you suggested is '#43A047' for
both theme.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Wed, Mar 18
Hi Aditya,
On Wed, Mar 18, 2020 at 1:52 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Murtuza,
>
> Why do we need to add new variable swith-ternary ? What was the issue you
> were facing ?
>
Just to make both class names consistent, I missed to git add those changes
in the
Hi Murtuza,
The changes are already incorporated so no worries :)
Thanks,
---
Chethana kumar
On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hello,
>
> As per discussion with Chethana, We need to make switch box color change
> for light and dar
Hi Murtuza,
Why do we need to add new variable swith-ternary ? What was the issue you
were facing ?
On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hello,
>
> As per discussion with Chethana, We need to make switch box color change
> for light an
