Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-26 Thread Murtuza Zabuawala
Hi Joao, On Wed, Apr 25, 2018 at 6:55 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi, > @Murtuza: We didn't notice the issue, can you please advise on what need > to change to make it work? The only change we did was to make one test pass. > I moved to another project so

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-25 Thread Joao De Almeida Pereira
Hi, @Murtuza: We didn't notice the issue, can you please advise on what need to change to make it work? The only change we did was to make one test pass. @Hackers: In our point of view it is never good to fork a library. But if he really have to do it, then we should fork it in Github, make our co

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-25 Thread Dave Page
On Wed, Apr 25, 2018 at 12:13 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Wed, Apr 25, 2018 at 3:36 PM, Dave Page wrote: > >> All, >> >> We just had a brief discussion in our EDB sprint planning meeting about >> this. There is a non-zero chance that we're

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-25 Thread Murtuza Zabuawala
Hi Dave, On Wed, Apr 25, 2018 at 3:36 PM, Dave Page wrote: > All, > > We just had a brief discussion in our EDB sprint planning meeting about > this. There is a non-zero chance that we're going to have to fork wcDocker > in the near future, in order to update it to work with jQuery 3. If we do >

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-25 Thread Dave Page
All, We just had a brief discussion in our EDB sprint planning meeting about this. There is a non-zero chance that we're going to have to fork wcDocker in the near future, in order to update it to work with jQuery 3. If we do that, then it may be significantly easier to fix this issue in that fork

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-25 Thread Murtuza Zabuawala
Hi Akshay, On Wed, Apr 25, 2018 at 2:37 PM, Akshay Joshi wrote: > Hi Joao/Murtuza > > It break's the functionality, I am able to move "Data output", "Explain" > etc.. panel of Query Tool, even if "Lock layout?" is set to True. > ​It's working properly in v5 patch, Something went wrong while re

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-24 Thread Murtuza Zabuawala
Thank you Joao for reviewing. On Tue, Apr 24, 2018 at 9:11 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > haha, > Just joking, now we have a good version that passes tests and all. > > We found out that a test was failing in the patch version 5: > > HeadlessChrome 0.0.0 (Li

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-24 Thread Joao De Almeida Pereira
Hi Murtuza, We tested the patch and everything looks fine. We also refactors some parts to include things like strict equality and using let/const instead of var. The updated patch is attached. In the future, it will be more valuable to have the translation to ES6 and the feature work in separat

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-24 Thread Akshay Joshi
On Tue, Apr 24, 2018 at 1:17 PM, Dave Page wrote: > Akshay, could you review/commit this please? > > Please also update the release_notes_3_1.rst file when you commit > user-visible changes, to make it easier to build the release notes. > Sure > > Thanks. > > On Tue, Apr 24, 2018 at 8:45 AM,

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-24 Thread Dave Page
Akshay, could you review/commit this please? Please also update the release_notes_3_1.rst file when you commit user-visible changes, to make it easier to build the release notes. Thanks. On Tue, Apr 24, 2018 at 8:45 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, >

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-05 Thread Robert Eckhardt
On Wed, Apr 4, 2018 at 11:31 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, Apr 4, 2018 at 8:09 PM, Dave Page wrote: > >> >> >> On Wed, Apr 4, 2018 at 12:54 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> On Wed, Apr 4, 2018 at 5:00 PM, Dav

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-04 Thread Khushboo Vashi
On Wed, Apr 4, 2018 at 8:09 PM, Dave Page wrote: > > > On Wed, Apr 4, 2018 at 12:54 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> On Wed, Apr 4, 2018 at 5:00 PM, Dave Page wrote: >> >>> >>> >>> On Wed, Apr 4, 2018 at 10:45 AM, Murtuza Zabuawala < >>> murtuza.zabuaw...@enterprisedb.com> wr

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-04 Thread Dave Page
On Wed, Apr 4, 2018 at 4:46 PM, Victoria Henry wrote: > Hi Hackers, > > We just reread the issue in Redmine, and our take is a little bit > different. Looks like the problem the person is complaining the tabs > sticking to the mouse when clicked. We also experience that problem while > developing

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-04 Thread Victoria Henry
Hi Hackers, We just reread the issue in Redmine, and our take is a little bit different. Looks like the problem the person is complaining the tabs sticking to the mouse when clicked. We also experience that problem while developing. How hard would it be to eliminate the Drag and Drop of tabs in t

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-04 Thread Ashesh Vashi
On Wed, Apr 4, 2018 at 8:09 PM, Dave Page wrote: > > > On Wed, Apr 4, 2018 at 12:54 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> On Wed, Apr 4, 2018 at 5:00 PM, Dave Page wrote: >> >>> >>> >>> On Wed, Apr 4, 2018 at 10:45 AM, Murtuza Zabuawala < >>> murtuza.zabuaw...@enterprisedb.com> wr

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-04 Thread Dave Page
On Wed, Apr 4, 2018 at 12:54 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > On Wed, Apr 4, 2018 at 5:00 PM, Dave Page wrote: > >> >> >> On Wed, Apr 4, 2018 at 10:45 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> On Wed, Apr 4, 2018 at 2:47 PM, D

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-04 Thread Murtuza Zabuawala
On Wed, Apr 4, 2018 at 5:00 PM, Dave Page wrote: > > > On Wed, Apr 4, 2018 at 10:45 AM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> On Wed, Apr 4, 2018 at 2:47 PM, Dave Page wrote: >> >>> >>> >>> On Wed, Apr 4, 2018 at 7:20 AM, Murtuza Zabuawala < >>> murtuza.zabuaw...@

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-04 Thread Dave Page
On Wed, Apr 4, 2018 at 10:45 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > On Wed, Apr 4, 2018 at 2:47 PM, Dave Page wrote: > >> >> >> On Wed, Apr 4, 2018 at 7:20 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> On Tue, Apr 3, 20

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-04 Thread Murtuza Zabuawala
On Wed, Apr 4, 2018 at 2:47 PM, Dave Page wrote: > > > On Wed, Apr 4, 2018 at 7:20 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> On Tue, Apr 3, 2018 at 9:03 PM, Dave Page wrote: >> >>> Hi >>> >>> On Tue, Apr 3, 2018 at 12:56 PM, Murtuza Zabuawala < >>> murtuza.zabuaw...@ent

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-04 Thread Dave Page
On Wed, Apr 4, 2018 at 7:20 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Apr 3, 2018 at 9:03 PM, Dave Page wrote: > >> Hi >> >> On Tue, Apr 3, 2018 at 12:56 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Thanks

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-03 Thread Dave Page
Hi On Tue, Apr 3, 2018 at 12:56 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Thanks Joao for reviewing. > > PFA updated patch. > > On Tue, Apr 3, 2018 at 1:11 AM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello, >> >> On Mon, Apr 2, 2018

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-03 Thread Joao De Almeida Pereira
Hi Murtuza, Everything seems to work, the tests are all green and the linter is fixed. As we stated in an previous email, the direction we would love the application to go is a more robust Javascript Front-End that would rely in the Backend to provide data. Adding more things to templated Javascr

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-02 Thread Joao De Almeida Pereira
Hello, On Mon, Apr 2, 2018 at 10:07 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > > ​Hello, > > Please find updated patch, > > Now layout will be locked after user updates its preferences, w > e have used ​ > templated variable in the javascript file > ​ because we do not ha

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-03-29 Thread Joao De Almeida Pereira
Hi Murtuza, After changing the setting in the preferences nothing happened, we had to reset the layout or refresh the app to see it working. It only looks the right side. Was this the intended behavior? Not sure if this is the expected behavior or not. I would expect that any change I do in the p