Re: [pgAdmin4][Patch]: To fix the issue in Debugger module

2017-12-04 Thread Dave Page
Thanks, patch applied! On Mon, Dec 4, 2017 at 6:13 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch. > > On Sat, Dec 2, 2017 at 10:42 AM, Dave Page wrote: > >> Hi >> >> On Thursday, November 30, 2017, Murtuza Zabuawala < >> murtuza.zabuaw...@ent

Re: [pgAdmin4][Patch]: To fix the issue in Debugger module

2017-12-04 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch. On Sat, Dec 2, 2017 at 10:42 AM, Dave Page wrote: > Hi > > On Thursday, November 30, 2017, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to fix the issue where debugger failed to run when user tries >> to debug the function

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

2017-06-27 Thread Dave Page
Thanks, patch applied. On Tue, Jun 27, 2017 at 4:21 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave > > Please find updated patch, > > On Fri, Jun 23, 2017 at 7:09 PM, Dave Page wrote: > >> Hi >> >> I'm unable to properly test this, as the debugger doesn't even seem

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

2017-06-27 Thread Murtuza Zabuawala
Hi Dave Please find updated patch, On Fri, Jun 23, 2017 at 7:09 PM, Dave Page wrote: > Hi > > I'm unable to properly test this, as the debugger doesn't even seem to > launch for a non-superuser. I just get a white tab, and a whole lot of > polling indefinitely. Can you debug if you're not a sup

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

2017-06-23 Thread Dave Page
Hi I'm unable to properly test this, as the debugger doesn't even seem to launch for a non-superuser. I just get a white tab, and a whole lot of polling indefinitely. Can you debug if you're not a superuser, but you own the function? Looking at the patch itself, I wonder if the logic is still a l

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

2017-06-23 Thread Murtuza Zabuawala
Hi Dave, Please find updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jun 23, 2017 at 2:38 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Yes, I'm looking into it, I will send updated patch. >

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

2017-06-23 Thread Murtuza Zabuawala
Yes, I'm looking into it, I will send updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jun 23, 2017 at 2:32 PM, Dave Page wrote: > On Fri, Jun 23, 2017 at 9:56 AM, Murtuza Zabuawala > wrote: > > Yes Dave, > > > > Y

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

2017-06-23 Thread Dave Page
On Fri, Jun 23, 2017 at 9:56 AM, Murtuza Zabuawala wrote: > Yes Dave, > > You are right, I tested and found that indirect debugging is not working. > But otherwise for direct debugging it works properly. Does the patch take that into account, or are you modifying it? > On Fri, Jun 23, 2017 at 1:

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

2017-06-23 Thread Murtuza Zabuawala
Yes Dave, You are right, I tested and found that indirect debugging is not working. But otherwise for direct debugging it works properly. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jun 23, 2017 at 1:20 PM, Dave Page wrote:

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

2017-06-23 Thread Dave Page
On Fri, Jun 23, 2017 at 7:16 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue in Debugger module where it was unable to start > debugging if 'plugin_debugger' can not found in shared_preload_libraries. > RM#2162 > > Original patch by: Kit Yam Tse > (who reported the issue) > > I j