Re: [pgAdmin4][Patch]: SonarQube Fixes

Thanks, the patch applied. On Thu, Jan 27, 2022 at 3:31 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the Sonarqube issues which are > assigned to me. > > Thanks, > Khushboo > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | P

Re: [pgAdmin4][Patch] - SonarQube Fixes

Thanks, patch applied. On Thu, Sep 3, 2020 at 4:39 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find more fixes for the sonarqube code smells having the rule "String > literals should not be duplicated". > > Thanks, > Khushboo > > On Wed, Aug 19, 2020 at 2:27 PM Ak

Re: [pgAdmin4][Patch] - SonarQube Fixes

Hi, Please find more fixes for the sonarqube code smells having the rule "String literals should not be duplicated". Thanks, Khushboo On Wed, Aug 19, 2020 at 2:27 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Aug 19, 2020 at 2:01 PM Khushboo Vashi < > khushboo.va...@enterprisedb.

Re: [pgAdmin4][Patch] - SonarQube Fixes #2

Hi Akshay, Please find the updated patch attached in this email. On Wed, Aug 19, 2020 at 2:40 PM Akshay Joshi wrote: > Hi Rahul > > I have committed Khushboo's patch where she has introduced a new method > 'not_found_error_msg', so instead of creating a new constant > 'TABLE_NOT_FOUND_MSG' use

Re: [pgAdmin4][Patch] - SonarQube Fixes #2

Hi Rahul I have committed Khushboo's patch where she has introduced a new method 'not_found_error_msg', so instead of creating a new constant 'TABLE_NOT_FOUND_MSG' use self.not_found_error_msg. Also, instead of _NODE_CSS = ‘node.css’ _COLLECTION_CSS = ‘collection.css’ We can use the following: _

Re: [pgAdmin4][Patch] - SonarQube Fixes

Thanks, patch applied. On Wed, Aug 19, 2020 at 2:01 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > > On Tue, Aug 4, 2020 at 12:10 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> As per offline disc

Re: [pgAdmin4][Patch] - SonarQube Fixes

Hi, Please find the attached updated patch. On Tue, Aug 4, 2020 at 12:10 PM Akshay Joshi wrote: > Hi Khushboo > > As per offline discussion, multiple developers declaring the constant for > the same string and error messages. To avoid that only one developer should > work on this task. > Sugge

Re: [pgAdmin4][Patch] - SonarQube Fixes

Hi Khushboo As per offline discussion, multiple developers declaring the constant for the same string and error messages. To avoid that only one developer should work on this task. Suggestions: - We should have a common class for Constants (which are not module specific). - For module sp

Re: [pgAdmin4][Patch] - SonarQube Fixes

Thanks, patch applied. On Wed, Jul 15, 2020 at 12:04 PM Satish V wrote: > Hi Hackers, > > Please find the patch which fixes sonarQube issues related to variable > shadowing. > Files altered - backgird.js, backgrid.pgadmin.js > > Kindly review and share your feedback. > > Thanks, > Sathish V >

Re: [pgAdmin4][Patch] - SonarQube Fixes

Thanks, patch applied. On Tue, Jul 14, 2020 at 6:34 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the more fixes for the SonarQube Code smells having Rule > "*Functions, > methods and lambdas should not have too many parameters*". > > Thanks, > Khushboo > > >

Re: [pgAdmin4][Patch] - SonarQube Fixes

Hi, Please find the more fixes for the SonarQube Code smells having Rule "*Functions, methods and lambdas should not have too many parameters*". Thanks, Khushboo On Fri, Jul 3, 2020 at 2:40 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Fri, Jul 3, 2020 at 1:12 PM Khushboo Vashi < > k

Re: [pgAdmin4][Patch] - SonarQube Fixes

Thanks, patch applied. On Wed, Jul 8, 2020 at 3:00 PM Rahul Shirsat wrote: > Hi Hackers, > > Please find the attached patch to fix the SonarQube Code smells having > Rule "Refactor this function to reduce its Cognitive Complexity from 18 > to the 15 allowed". > > -- > *Rahul Shirsat* > Software

Re: [pgAdmin4][Patch] - SonarQube Fixes

Thanks, patch applied. On Fri, Jul 3, 2020 at 1:12 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the SonarQube Code smells having > Rule "*Functions, methods and lambdas should not have too many parameters* > ". > > In this patch, I ha

Re: [pgAdmin4][Patch] SonarQube Fixes

Thanks, patch applied. On Thu, Jun 25, 2020 at 5:55 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the code smells having rule (PYTHON) > NESTED BLOCKS OF CODE SHOULD NOT BE LEFT EMPTY. > > Thanks, > Khushboo > -- *Thanks & Regards*