Thanks, applied.
On Wed, Sep 13, 2017 at 1:26 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi Dave,
>
> If we set 'NODE_ENV' to 'production' variable in definePlugin, the React
> will always build in production mode.
>
> Please find an attached patch.
>
> Thanks,
> Surinder
>
>
Hi Dave,
If we set 'NODE_ENV' to 'production' variable in definePlugin, the React
will always build in production mode.
Please find an attached patch.
Thanks,
Surinder
On Wed, Sep 13, 2017 at 4:36 PM, Dave Page wrote:
>
>
> On Wed, Sep 13, 2017 at 10:34 AM, Surinder Kumar <
> surinder.ku...
On Wed, Sep 13, 2017 at 10:34 AM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> On Wed, Sep 13, 2017 at 2:52 PM, Dave Page wrote:
>
>>
>>
>> On Wed, Sep 13, 2017 at 10:06 AM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Wed, Sep 13, 2017 at 2:18 PM,
On Wed, Sep 13, 2017 at 2:52 PM, Dave Page wrote:
>
>
> On Wed, Sep 13, 2017 at 10:06 AM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>>
>>
>> On Wed, Sep 13, 2017 at 2:18 PM, Dave Page wrote:
>>
>>> Thanks, committed - though I did add a bundle-dev target to the Makefile
>>>
On Wed, Sep 13, 2017 at 10:06 AM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
>
>
> On Wed, Sep 13, 2017 at 2:18 PM, Dave Page wrote:
>
>> Thanks, committed - though I did add a bundle-dev target to the Makefile
>> for convenience.
>>
>> I'm a little concerned though that the query
On Wed, Sep 13, 2017 at 2:18 PM, Dave Page wrote:
> Thanks, committed - though I did add a bundle-dev target to the Makefile
> for convenience.
>
> I'm a little concerned though that the query history still doesn't work in
> dev mode. Is that fixable?
>
That's an issue with ReactJS and I had l
Thanks, committed - though I did add a bundle-dev target to the Makefile
for convenience.
I'm a little concerned though that the query history still doesn't work in
dev mode. Is that fixable?
On Tue, Sep 12, 2017 at 11:57 AM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi Dave,
>
Hi Dave,
I had discussed this with Ashesh and according to him, running `yarn run
bundle` should always build prod bundle. So, I made changes accordingly.
Following changes are made in package.json script commands:
1) Running `yarn run bundle` will build prod bundle.
2) Running `yarn run bundle
Hi
This is over-complicating things. As I said, we never build packages in dev
mode - there's just no need.
All we need is easy-to-use Makefile targets that allow us to do either a
prod or a dev bundle. The packages should always use prod bundles.
I assume with the (to-be-updated) version of thi
Hi
As per the review comment given by Ashesh:
1) The test cases with target `check:` must run in `prod` mode by default.
2) Add another target `check-dev:` to run test cases in `dev` mode.
So, the patch is updated with fixed review comments.
Please find an updated patch and review.
Thanks,
Su
Hi Dave,
I have added a new target to run build in 'dev' mode. By default, it will
run in production mode.
By dev mode it means, run `yarn run bundle:dev` and by prod mode, run `yarn
run bundle:prod`.
In Mac bundle, added new target `make appbundle-dev` to generate build with
command `yarn run b
No, let's just have two targets in one makefile. It's only for our convenience.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company
> On 8 Sep 2017, at 05:34, Surinder Kumar
> wrote:
>
> Hi
>
>> On Th
Hi
On Thu, Sep 7, 2017 at 8:48 PM, Dave Page wrote:
> Hi
>
> On Thu, Sep 7, 2017 at 7:28 AM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> When we run Webpack in production mode, it performs optimization on code
>> while in development we don't optimize generated JS a
Hi
On Thu, Sep 7, 2017 at 7:28 AM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi,
>
> When we run Webpack in production mode, it performs optimization on code
> while in development we don't optimize generated JS and CSS bundles as dev
> mode is for developer use.
>
> So we should
14 matches
Mail list logo
