The patch looks good to me.
On Wed, Jan 30, 2019 at 1:05 PM Akshay Joshi
wrote:
> Hi Khushboo
>
> On Wed, Jan 30, 2019 at 10:17 AM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Akshay,
>>
>> The issue has been fixed with this patch but I feel we need code
>> refactoring of t
Hi Khushboo
On Wed, Jan 30, 2019 at 10:17 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi Akshay,
>
> The issue has been fixed with this patch but I feel we need code
> refactoring of the existing code especially the loop in which we find the
> required string.
> What's your thou
Hi Akshay,
The issue has been fixed with this patch but I feel we need code
refactoring of the existing code especially the loop in which we find the
required string.
What's your thought?
Also, please remove the datagrid/__init__.py file from the patch which I
assume you have sent by mistake.
Th
Khushboo, can you review this please? If you're happy with it, Akshay
can commit.
Thanks.
On Mon, Jan 28, 2019 at 12:33 PM Akshay Joshi
wrote:
>
> Hi Hackers,
>
> Attached is the patch to fix RM 3927 "Unable to debug the procedure inside
> package". Problem with the existing code is we assume t
