Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-10-08 Thread Dave Page
Thanks - committed! On Fri, Oct 5, 2018 at 5:24 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > I found one issue with the selecting previous selected node which I was > fixed and attached the updated patch. > Please let me know if you find any specific scenario which i

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-10-04 Thread Khushboo Vashi
Hi Dave, I found one issue with the selecting previous selected node which I was fixed and attached the updated patch. Please let me know if you find any specific scenario which is not covered. While testing the patch, please clear your sqlite entry from the setting table as we have changed the s

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-10-04 Thread Khushboo Vashi
On Thu, Oct 4, 2018 at 7:52 PM Dave Page wrote: > Hi > > On Thu, Oct 4, 2018 at 1:12 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached updated patch. >> > > This seems to behave quite strangely - only sporadically saving the > treeview state, an

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-10-04 Thread Dave Page
Hi On Thu, Oct 4, 2018 at 1:12 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > This seems to behave quite strangely - only sporadically saving the treeview state, and then not always (maybe ever?) restoring the selected node. When I

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-10-04 Thread Khushboo Vashi
Hi, Please find the attached updated patch. Thanks, Khushboo On Mon, Oct 1, 2018 at 7:14 PM Dave Page wrote: > Hi > > On Mon, Oct 1, 2018 at 1:53 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave >> >> >> On Mon, Oct 1, 2018 at 4:02 PM Dave Page wrote: >> >>> >>> >>>

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-10-01 Thread Dave Page
Hi On Mon, Oct 1, 2018 at 1:53 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave > > > On Mon, Oct 1, 2018 at 4:02 PM Dave Page wrote: > >> >> >> On Mon, Oct 1, 2018 at 11:06 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Tue, Sep 25, 2018 at

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-10-01 Thread Khushboo Vashi
Hi Dave On Mon, Oct 1, 2018 at 4:02 PM Dave Page wrote: > > > On Mon, Oct 1, 2018 at 11:06 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Tue, Sep 25, 2018 at 6:26 PM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Tue, Sep 25, 2018 at

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-10-01 Thread Dave Page
On Mon, Oct 1, 2018 at 11:06 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Tue, Sep 25, 2018 at 6:26 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Tue, Sep 25, 2018 at 6:17 PM Dave Page wrote: >> >>> >>> >>> On Tue, Sep 25, 2018 at 3:00 AM Khus

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-10-01 Thread Khushboo Vashi
On Tue, Sep 25, 2018 at 6:26 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Tue, Sep 25, 2018 at 6:17 PM Dave Page wrote: > >> >> >> On Tue, Sep 25, 2018 at 3:00 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> On Tue, Sep 25, 2018 at 12

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-09-25 Thread Dave Page
On Tue, Sep 25, 2018 at 8:57 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Tue, Sep 25, 2018 at 6:17 PM Dave Page wrote: > >> >> >> On Tue, Sep 25, 2018 at 3:00 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> On Tue, Sep 25, 2018 at 12

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-09-25 Thread Khushboo Vashi
On Tue, Sep 25, 2018 at 6:17 PM Dave Page wrote: > > > On Tue, Sep 25, 2018 at 3:00 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Tue, Sep 25, 2018 at 12:15 AM Dave Page wrote: >> >>> Hi >>> On Mon, Sep 24, 2018 at 2:05 AM Khushboo Vashi < >>> khushboo.va..

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-09-25 Thread Dave Page
On Tue, Sep 25, 2018 at 3:00 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Sep 25, 2018 at 12:15 AM Dave Page wrote: > >> Hi >> On Mon, Sep 24, 2018 at 2:05 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attac

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-09-25 Thread Khushboo Vashi
Hi Dave, On Tue, Sep 25, 2018 at 12:15 AM Dave Page wrote: > Hi > On Mon, Sep 24, 2018 at 2:05 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached updated patch. >> >> Feature Details: >> - The current tree state as well as the previous will be s

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-09-24 Thread Dave Page
Hi On Mon, Sep 24, 2018 at 2:05 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > Feature Details: > - The current tree state as well as the previous will be stored in the > sqlite database. > - The time interval to store the tree sta

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-09-23 Thread Khushboo Vashi
Hi, Please find the attached updated patch. Feature Details: - The current tree state as well as the previous will be stored in the sqlite database. - The time interval to store the tree state is configurable via preferences and the default is 30 secs. -1 can be used to stop the tree saving fu

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-08-30 Thread Dave Page
Hi On Tue, Aug 28, 2018 at 1:40 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Aug 27, 2018 at 1:19 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> Patch looks good to me, following are my review comments: >> >>- Logic doesn't work

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-08-28 Thread Khushboo Vashi
On Mon, Aug 27, 2018 at 1:19 PM, Akshay Joshi wrote: > Hi Khushboo > > Patch looks good to me, following are my review comments: > >- Logic doesn't work when we disconnect and re-connect to the database >server. We have duplicated RM #1335. > > I have saved the current state of the tree.

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-08-27 Thread Akshay Joshi
Hi Khushboo Patch looks good to me, following are my review comments: - Logic doesn't work when we disconnect and re-connect to the database server. We have duplicated RM #1335. - Instead of -1 we should use 0 to stop the tree saving functionality. Send request at 0 second doesn't mak

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-08-26 Thread Aditya Toshniwal
Hi Khushboo, Cheers, the patch looks good to me. I have few suggestions: 1) Expand the tree -> Go to server properties and rename the server -> the tree closes. It should expand to last state. Same applies to other nodes which can be renamed. 2) It would be nice if we can also save the last select