Re: [pgAdmin4][Patch]: RM #4362 trigger function create script

2019-06-20 Thread Dave Page
Thanks, applied. On Thu, Jun 20, 2019 at 7:48 AM Akshay Joshi wrote: > Hi Dave > > On Wed, Jun 19, 2019 at 8:47 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Wed, 19 Jun, 2019, 19:57 Dave Page, wrote: >> >>> Hi >>> >>> On Wed, Jun 19, 2019 at 9:55 AM Akshay Jos

Re: [pgAdmin4][Patch]: RM #4362 trigger function create script

2019-06-19 Thread Akshay Joshi
Hi Dave On Wed, Jun 19, 2019 at 8:47 PM Akshay Joshi wrote: > Hi Dave > > On Wed, 19 Jun, 2019, 19:57 Dave Page, wrote: > >> Hi >> >> On Wed, Jun 19, 2019 at 9:55 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to fix RM #4362 trigger

Re: [pgAdmin4][Patch]: RM #4362 trigger function create script

2019-06-19 Thread Akshay Joshi
Hi Dave On Wed, 19 Jun, 2019, 19:57 Dave Page, wrote: > Hi > > On Wed, Jun 19, 2019 at 9:55 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix RM #4362 trigger function create script. >> Please review it. >> > > While I can see how this

Re: [pgAdmin4][Patch]: RM #4362 trigger function create script

2019-06-19 Thread Dave Page
Hi On Wed, Jun 19, 2019 at 9:55 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix RM #4362 trigger function create script. > Please review it. > While I can see how this works, I question why we have the string "SETOF" in prorettypname anyway? That's a separate property, so