Re: [pgAdmin4][Patch]: RM #3420 Merge latest code of pgcli with pgAdmin4

2018-08-27 Thread Akshay Joshi
Thanks patch applied. On Mon, Aug 27, 2018 at 4:22 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Akshay, > > Attached is the patch to make autocomplete changes python 2.6 compatible. > Please note, this patch should be applied over your patch. > > On Mon, Aug 27, 2018 at 2

Re: [pgAdmin4][Patch]: RM #3420 Merge latest code of pgcli with pgAdmin4

2018-08-27 Thread Aditya Toshniwal
Hi Akshay, Attached is the patch to make autocomplete changes python 2.6 compatible. Please note, this patch should be applied over your patch. On Mon, Aug 27, 2018 at 2:28 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Did a basic testing. Looks good to me. Test cases

Re: [pgAdmin4][Patch]: RM #3420 Merge latest code of pgcli with pgAdmin4

2018-08-27 Thread Aditya Toshniwal
Hi, Did a basic testing. Looks good to me. Test cases run successfully. On Fri, Aug 24, 2018 at 10:55 AM Akshay Joshi wrote: > Hi Hackers > > I have merged the latest code of "*pgcli*" used for auto complete feature > in pgAdmin4. We haven't merged that code since last 2 years and they have > f