Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Thanks, applied. On Mon, Jan 15, 2018 at 11:35 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Mon, Jan 15, 2018 at 2:57 PM, Dave Page wrote: > >> Hi >> >> Unfortunately there's variation in the spec of the images. Can you please >> check with Chethana on the

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Hi Unfortunately there's variation in the spec of the images. Can you please check with Chethana on the correct sizing and resolution etc? For example, query_sql_editor.png was previously 755x209, but now is 2042x402. Thanks! On Mon, Jan 15, 2018 at 7:21 AM, Murtuza Zabuawala < murtuza.zabuaw...

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Sure, I'll do that. On Fri, Jan 12, 2018 at 8:05 PM, Dave Page wrote: > Thanks - patch applied! > > Can you please update the docs for the new config options, and any > screenshot updates that are required? > > On Fri, Jan 12, 2018 at 2:10 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> ​Hi

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Thanks - patch applied! Can you please update the docs for the new config options, and any screenshot updates that are required? On Fri, Jan 12, 2018 at 2:10 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > ​Hi Dave, > > PFA updated patch with additional checks to prevent unn

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

​Hi Dave, PFA updated patch with additional checks to prevent unnecessary ​polling added as suggested. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jan 11, 2018 at 2:33 PM, Dave Page wrote: > > > On Thu, Jan 1

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

On Thu, Jan 11, 2018 at 7:00 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > On Thu, Jan 11, 2018 at 12:06 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> User can open Query tool in new browser window where we'll not have >> wcDocker panel. >> > > In that case we can use windo

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

On Thu, Jan 11, 2018 at 12:06 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > User can open Query tool in new browser window where we'll not have > wcDocker panel. > In that case we can use window onfocus and onblur events

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

User can open Query tool in new browser window where we'll not have wcDocker panel. On Thu, Jan 11, 2018 at 12:00 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Murtuza, I think we should only poll if sqleditor/datagrid is visible. > We've *wcDocker.EVENT.VISIBILITY_CHANGED *event

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Murtuza, I think we should only poll if sqleditor/datagrid is visible. We've *wcDocker.EVENT.VISIBILITY_CHANGED *event when panel visibility changes. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jan 10, 201

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Hi Dave, PFA updated patch. On Tue, Jan 9, 2018 at 7:57 PM, Dave Page wrote: > Hi > > On Tue, Jan 9, 2018 at 6:33 AM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find updated patch. >> > > I turned off the status option, but polling is still happe

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Hi On Tue, Jan 9, 2018 at 6:33 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch. > I turned off the status option, but polling is still happening. This should definitely stop! :-) Can you also reverse the enable/disable switch and the i

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Hi Dave, Please find updated patch. On Mon, Jan 8, 2018 at 7:21 PM, Dave Page wrote: > > > On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi Dave, >> >> PFA updated patch. >> >> On Mon, Jan 8, 2018 at 5:11 PM, Dave Page wrote: >> >>> Hi >>

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

On Mon, Jan 8, 2018 at 2:04 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Yes, I agree, it's a good idea to have it optional, I'll work on it and > send updated patch. > by the way what should be default behaviour? Should we make it disabled by > default? > No - users proba

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Yes, I agree, it's a good idea to have it optional, I'll work on it and send updated patch. by the way what should be default behaviour? Should we make it disabled by default? On Mon, Jan 8, 2018 at 7:26 PM, Ashesh Vashi wrote: > On Mon, Jan 8, 2018 at 7:21 PM, Dave Page wrote: > >> >> >> On M

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

On Mon, Jan 8, 2018 at 7:21 PM, Dave Page wrote: > > > On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> PFA updated patch. >> >> On Mon, Jan 8, 2018 at 5:11 PM, Dave Page wrote: >> >>> Hi >>> >>> On Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala < >

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch. > > On Mon, Jan 8, 2018 at 5:11 PM, Dave Page wrote: > >> Hi >> >> On Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >>

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Hi Dave, PFA updated patch. On Mon, Jan 8, 2018 at 5:11 PM, Dave Page wrote: > Hi > > On Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> PFA updated patch, >> >> >> On Wed, Jan 3, 2018 at 10:44 PM, Dave Page wrote: >> >>> Hi >>> >>> On Thu, Dec 28,

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Hi On Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch, > > > On Wed, Jan 3, 2018 at 10:44 PM, Dave Page wrote: > >> Hi >> >> On Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wr

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

On Fri, Jan 5, 2018 at 2:57 PM, Dave Page wrote: > > > On Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi Dave, >> >> PFA updated patch, >> >> >> On Wed, Jan 3, 2018 at 10:44 PM, Dave Page wrote: >> >>> Hi >>> >>> On Thu, Dec 28, 2017 at 9:38

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

On Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch, > > > On Wed, Jan 3, 2018 at 10:44 PM, Dave Page wrote: > >> Hi >> >> On Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote:

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Hi Dave, PFA updated patch, On Wed, Jan 3, 2018 at 10:44 PM, Dave Page wrote: > Hi > > On Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> PFA updated patch based on new design suggested by Chethana. >> The patch also includes some m

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Hi On Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA updated patch based on new design suggested by Chethana. > The patch also includes some misc fixes related to object validation. > RM#2475 > This seems much nicer, but I still think t

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Hi, PFA updated patch based on new design suggested by Chethana. The patch also includes some misc fixes related to object validation. RM#2475 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Dec 22, 2017 at 11:53

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Hi Chetana, We have all the suggested icons in font awesome icon pack :) Connected: http://fontawesome.io/icon/link Disconnected: http://fontawesome.io/icon/chain-broken/ Idle in TX: http://fontawesome.io/icon/clock-o/ Busy: http://fontawesome.io/icon/hourglass-half/ Error in TX: http://fontaweso

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Hi There are 2 icons that look the same except for colour. That’s not going to work for some users with colour blindness. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 21 Dec 2017, at 15:32,

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

On Wed, Dec 20, 2017 at 12:17 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Tue, Dec 19, 2017 at 7:47 PM, Murtuza Zabuawala enterpris

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

-- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Dec 19, 2017 at 7:47 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > > > On Tue, Dec 19, 2017 at 7:24 PM, Dave Page wrote: > >> Hi >> >> In

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

What are thoughts on switching the colors between currently running and idle? I think if the session is currently running, and its still open during the session time limit, it should be green. Perhaps idle sessions should be yellow or grey to indicate that the window should be (and can be) closed w

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Hi On Tue, Dec 19, 2017 at 2:17 PM, Murtuza Zabuawala wrote: > > > On Tue, Dec 19, 2017 at 7:24 PM, Dave Page wrote: > >> Hi >> >> Interesting. A few thoughts: >> >> - The pulsating icon is very off-putting. I think we need to make it only >> flash a couple of times when we actually need to att

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

On Tue, Dec 19, 2017 at 7:24 PM, Dave Page wrote: > Hi > > Interesting. A few thoughts: > > - The pulsating icon is very off-putting. I think we need to make it only > flash a couple of times when we actually need to attract the attention of > the user. > ​As per my discussion with Chethana, In h

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Hi Interesting. A few thoughts: - The pulsating icon is very off-putting. I think we need to make it only flash a couple of times when we actually need to attract the attention of the user. - We shouldn't really use tooltips like this, as it may confuse folks with screen readers. Should we make