On Thu, Jul 27, 2017 at 1:32 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi Ashesh,
>
> I have removed changes which are not relevant to the moving file to static
> directory.
>
Committed the code for moving the javascript files from 'templates' to
'static' directory for most of
On Thu, Jul 27, 2017 at 12:57 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi Ashesh,
>
> Please find attached patch 'move_js_files_static_dir' with --binary option.
>
As discussed, this patch should include changes related to moving the file
to static directory only, and not rel
Ok. I will send rebased patch.
On Thu, Jul 27, 2017 at 10:32 AM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:
>
>
> On Thu, Jul 27, 2017 at 10:22 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Hi Surinder,
>>
>> 'delete_template_files.patch' is applied any more.
>> Please
On Thu, Jul 27, 2017 at 10:22 AM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:
> Hi Surinder,
>
> 'delete_template_files.patch' is applied any more.
> Please send the rebased patches.
>
> I have also noticed in the 'move_js_files_to_static_directory.patch',
> couple of modules have two def
Hi Surinder,
'delete_template_files.patch' is applied any more.
Please send the rebased patches.
I have also noticed in the 'move_js_files_to_static_directory.patch',
couple of modules have two definitions for 'module_use_template_javascript'
method.
--
Thanks & Regards,
Ashesh Vashi
Enterpri
Thanks, applied.
On Thu, Jul 20, 2017 at 1:35 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi Dave,
>
> Can you please review this patch please? I guess it was missed as i send 2
> patches back to back in same email chain.
> Please find inline detailed description of issue.
>
>
Hi Dave,
Can you please review this patch please? I guess it was missed as i send 2
patches back to back in same email chain.
Please find inline detailed description of issue.
On Thu, Jul 20, 2017 at 12:37 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi
>
> The loading icon ima
Hi
*Changes:*
Add proper comments in webpack configuration files.
Rename lib_css to style.css
Please find attached patch and review
Thanks,
Surinder
On Thu, Jul 20, 2017 at 12:37 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi
>
> The loading icon image is used in FileManage
Hi
The loading icon image is used in FileManager and it is still referenced
from vendor `aciTree`(which is removed) so it gives 404 not found when
FileManager is opened from Query tool/Backup utility.
Please find attached patch and review.
Thanks,
Surinder Kumar
webpack_file_manager_icon_issue
Thanks, applied.
On Wed, Jul 19, 2017 at 2:40 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi,
>
> PFA patch for few code review comments given by Ashesh.
>
> Thanks,
> Surinder
>
>
> On Wed, Jul 19, 2017 at 4:36 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>
Hi,
PFA patch for few code review comments given by Ashesh.
Thanks,
Surinder
On Wed, Jul 19, 2017 at 4:36 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> On Wed, Jul 19, 2017 at 4:27 PM, Dave Page wrote:
>
>> That was a fun one to spot I'm sure!
>>
> Indeed, i had setup pgAdmi
On Wed, Jul 19, 2017 at 4:27 PM, Dave Page wrote:
> That was a fun one to spot I'm sure!
>
Indeed, i had setup pgAdmin evn on Linux(as it works on Mac) and then i
did `ls path/to/jquery.contextmenu.js`, it was spotted :)
>
> Thanks, committed.
>
> On Wed, Jul 19, 2017 at 11:21 AM, Surinder Kuma
That was a fun one to spot I'm sure!
Thanks, committed.
On Wed, Jul 19, 2017 at 11:21 AM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi
>
> Fix library path reference for `jquery.contextmenu'. This issue was only
> reproducible on Linux machine.
> So, i setup pgAdmin4 on Ubuntu V
Hi
Fix library path reference for `jquery.contextmenu'. This issue was only
reproducible on Linux machine.
So, i setup pgAdmin4 on Ubuntu VM and tested the patch and it works.
Please find attached patch.
Thanks,
Surinder
On Tue, Jul 18, 2017 at 9:05 PM, Murtuza Zabuawala wrote:
> Great job Su
Great job Surinder, Load time ~2 sec on browser :)
[image: Inline image 1]
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Tue, Jul 18, 2017 at 9:01 PM, Dave Page wrote:
> Thanks, applied.
>
> On Tue, Jul 18, 2017 at 4:12 PM, Surind
Thanks, applied.
On Tue, Jul 18, 2017 at 4:12 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi
>
> 1. As Slickgrid has dependency of `jQuery-ui`, it was missed. now added.
> 2. Column sorting for collection nodes sometimes failing when clicked on
> different collection nodes.
>
>
Hi
1. As Slickgrid has dependency of `jQuery-ui`, it was missed. now added.
2. Column sorting for collection nodes sometimes failing when clicked on
different collection nodes.
Please find attached patch.
Thanks
Surinder
On Tue, Jul 18, 2017 at 8:20 PM, Khushboo Vashi <
khushboo.va...@enterpris
On Tue, Jul 18, 2017 at 7:46 PM, Dave Page wrote:
> Thanks - applied!
>
> Awesome work - on an average of 3 tests on my Mac, load time reduced from
> 11.55s with v1.6 to 5.53s with GIT Head.
>
> Surinder, great work...
> On Mon, Jul 17, 2017 at 5:57 PM, Surinder Kumar <
> surinder.ku...@enterpr
Thanks - applied!
Awesome work - on an average of 3 tests on my Mac, load time reduced from
11.55s with v1.6 to 5.53s with GIT Head.
On Mon, Jul 17, 2017 at 5:57 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi
>
> Now all test cases are executing.
> Please find updated patch.
>
On Mon, Jul 17, 2017 at 4:52 PM, Dave Page wrote:
> Hi
>
> No errors now, but do you know why JS tests are being skipped?
>
No errors/warning in console even after settings `logLevel:
config.LOG_DEBUG`. I am still debugging.
>
> PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 4 of 216 (skipped 212)
Hi
No errors now, but do you know why JS tests are being skipped?
PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 4 of 216 (skipped 212) SUCCESS
(0.085 secs / 0.046 secs)
Thanks!
On Mon, Jul 17, 2017 at 12:07 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi Dave,
>
> I didn't remo
Hi
I'm currently working on first TODO: "Automatically handle static and
template JS files"
As discussed with Ashesh, currently the paths to module id are written
manually in webpack.config.js, instead the path defined in moudle's `def
get_own_javascript()` should be used.
So, we will be genera
On Mon, Jul 17, 2017 at 2:15 PM, Dave Page wrote:
> Hi
>
> On Wed, Jul 12, 2017 at 4:04 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi
>>
>> While this patch is in review, i have not attached patch for "unvendored
>> libs" which is around 10MB in size and needs not to revi
Hi
On Wed, Jul 12, 2017 at 4:04 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi
>
> While this patch is in review, i have not attached patch for "unvendored
> libs" which is around 10MB in size and needs not to review.
> Attached is the patch which can be reviewed.
>
> *Changes:
> On 12 Jul 2017, at 02:56, Ashesh Vashi wrote:
>
>> On Tue, Jul 11, 2017 at 10:29 PM, Surinder Kumar
>> wrote:
>> Robert,
>>
>> I have attached two patches:
>>
>> 1. webpack_bundles.patch
>>
>> 2. unvendor_files.patch
>>
>> in this email chain.
>>
>> If you didn't received those patche
On Tue, Jul 11, 2017 at 10:29 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Robert,
>
> I have attached two patches:
>
> 1. webpack_bundles.patch
>
> 2. unvendor_files.patch
>
> in this email chain.
>
> If you didn't received those patches possibly due to large size of patch,
> le
Robert,
I have attached two patches:
1. webpack_bundles.patch
2. unvendor_files.patch
in this email chain.
If you didn't received those patches possibly due to large size of patch,
let me know i will send again.
On Tue, Jul 11, 2017 at 10:24 PM, Robert Eckhardt
wrote:
> Surinder,
>
> Sorry
Surinder,
Sorry I'm missing the email can you tell me the name please.
-- Rob
On Tue, Jul 11, 2017 at 12:51 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> On Tue, Jul 11, 2017 at 10:18 PM, Robert Eckhardt
> wrote:
>
>> The last email on this chain from Surinder says that it isn
On Tue, Jul 11, 2017 at 10:18 PM, Robert Eckhardt
wrote:
> The last email on this chain from Surinder says that it isn't working on
> IE and he will submit another patch. Are we missing that patch? Would you
> like us to look at the previous patch?
>
Yes previous patch includes fix related to IE
The last email on this chain from Surinder says that it isn't working on IE
and he will submit another patch. Are we missing that patch? Would you like
us to look at the previous patch?
-- Rob
On Jul 11, 2017 11:37 AM, "Dave Page" wrote:
> Pivotal team; you guys are far more familiar with webp
Hi Dave,
I have tested Surinder's patch in my local machine with Qt 5.9.1 Webkit on
Windows and we are getting improvements with this patch. :)
Below performance tested with Qt 5.9.1 with annulen webkit v 5.212.0 Alpha2.
*Before Webpack patch:-*
It took ~20 seconds. This 20 seconds includes whe
Hi
I found this patch won't work on IE, so i have fixed it and will send
updated patch.
On Tue, Jul 11, 2017 at 1:25 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
>
> On Tue, Jul 11, 2017 at 1:22 PM, Dave Page wrote:
>
>> When you say "un-vendorising", do you mean removing them f
On Tue, Jul 11, 2017 at 1:22 PM, Dave Page wrote:
> When you say "un-vendorising", do you mean removing them from the vendor
> directory and adding them to packages.json so they're pulled in via
> npm/yarn? (if so, good :-) )
>
Yes.
>
> On Tue, Jul 11, 2017 at 7:34 AM, Surinder Kumar <
> surin
When you say "un-vendorising", do you mean removing them from the vendor
directory and adding them to packages.json so they're pulled in via
npm/yarn? (if so, good :-) )
On Tue, Jul 11, 2017 at 7:34 AM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi
>
> *Detailed changes:*
>
> 1)
Hello,
> *Things to discuss:*
>
> How to differentiate between a static and template JS
>
> .
>
What is the advantage of webpacking templated JS? It seems as though this
creates a system in which the bundled dependencies have to refer back to
the backend to load the templates.
If there is a
Hi All,
*Things to discuss:*
How to differentiate between a static and template JS
.
In Webpack we have to resolve paths to the modules same as in
requirejs.config(base.html). but previously we were using
'current_app.javascripts' which holds the the path references for modules
registered.
Awesome work. Do you have an ETA for a feature complete test patch?
On Fri, Jun 30, 2017 at 11:41 AM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi
>
> So far, I have been able to generate bundled
> 'sources/generated/browser.js' which contains only three browser modules
> (Server
Hi
So far, I have been able to generate bundled 'sources/generated/browser.js'
which contains only three browser modules (Server-group, Server, Database)
and load it from 'browser/index.html'(entry point) and it works(except few
JS error present in file). so will fix them.
Then I will add one by
Hi
On Fri, Jun 30, 2017 at 2:29 AM, George Gelashvili
wrote:
> Hey Surinder,
>
>
> 1.
>> Tools
>> (tools.js) - It will contain all JS modules under tools directory
>>
>>
>> 2.
>> Browser
>> (browser.js) - It will contain all JS modules under browser directory
>>
>
> By under, do you m
Hey Surinder,
1.
> Tools
> (tools.js) - It will contain all JS modules under tools directory
>
>
> 2.
> Browser
> (browser.js) - It will contain all JS modules under browser directory
>
By under, do you mean every javascript file recursively under the browser
directory?
> 4. Common
40 matches
Mail list logo
