Re: [pgAdmin][RM6677 & RM6632] [React] Port Procedure and Function node to react

2021-09-30 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Sep 30, 2021 at 4:13 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached patch for #6838 and #6841. > Issues are: > >1. System procedure should not be visible in the properties tab for >function. >2.

Re: [pgAdmin][RM6677 & RM6632] [React] Port Procedure and Function node to react

2021-09-30 Thread Pradip Parkale
Hi Akshay, Please find the attached patch for #6838 and #6841. Issues are: 1. System procedure should not be visible in the properties tab for function. 2. Estimated cost option should be editable in edit mode for Procedure. 3. Should give an error when language is not specified. On

Re: [pgAdmin][RM6677 & RM6632] [React] Port Procedure and Function node to react

2021-08-25 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Aug 26, 2021 at 11:53 AM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached patch. I have improved the code coverage of > Function node and also fixed the test cases which were failing for Cast > ,Subscription and

Re: [pgAdmin][RM6677 & RM6632] [React] Port Procedure and Function node to react

2021-08-25 Thread Pradip Parkale
Hi Akshay, Please find the attached patch. I have improved the code coverage of Function node and also fixed the test cases which were failing for Cast ,Subscription and Publication node. On Tue, Aug 24, 2021 at 10:54 AM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > >